From 2ecb4b0a4ff8c45ae69fa3f2327ac15e435162ff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ivar=20Conradi=20=C3=98sthus?= <ivar@getunleash.io>
Date: Fri, 20 Jun 2025 13:18:50 +0200
Subject: [PATCH] Chore/remove flag disable bulk toggle (#10183)

Prompt used:

![image](https://github.com/user-attachments/assets/17d35ab4-cc2c-4f90-9bee-7fdc3550e1ec)

LLM: Gemini 2.5 Pro (preview)

@kwasniew do we still need this kill-switch?
---
 .../ProjectFeaturesBatchActions.tsx           | 41 +++++++------------
 frontend/src/interfaces/uiConfig.ts           |  1 -
 .../feature-toggle-controller.ts              | 10 -----
 src/lib/types/experimental.ts                 |  5 ---
 4 files changed, 14 insertions(+), 43 deletions(-)

diff --git a/frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeaturesBatchActions/ProjectFeaturesBatchActions.tsx b/frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeaturesBatchActions/ProjectFeaturesBatchActions.tsx
index 5f9bc5bbc8..75e58e01f8 100644
--- a/frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeaturesBatchActions/ProjectFeaturesBatchActions.tsx
+++ b/frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeaturesBatchActions/ProjectFeaturesBatchActions.tsx
@@ -9,7 +9,6 @@ import { usePlausibleTracker } from 'hooks/usePlausibleTracker';
 import { BulkDisableDialog } from 'component/feature/FeatureToggleList/BulkDisableDialog';
 import { BulkEnableDialog } from 'component/feature/FeatureToggleList/BulkEnableDialog';
 import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
-import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
 
 interface IProjectFeaturesBatchActionsProps {
     selectedIds: string[];
@@ -72,32 +71,20 @@ export const ProjectFeaturesBatchActions: FC<
 
     return (
         <>
-            <ConditionallyRender
-                condition={Boolean(uiConfig?.flags?.disableBulkToggle)}
-                show={null}
-                elseShow={
-                    <Button
-                        variant='outlined'
-                        size='small'
-                        onClick={() => setShowBulkEnableDialog(true)}
-                    >
-                        Enable
-                    </Button>
-                }
-            />
-            <ConditionallyRender
-                condition={Boolean(uiConfig?.flags?.disableBulkToggle)}
-                show={null}
-                elseShow={
-                    <Button
-                        variant='outlined'
-                        size='small'
-                        onClick={() => setShowBulkDisableDialog(true)}
-                    >
-                        Disable
-                    </Button>
-                }
-            />
+            <Button
+                variant='outlined'
+                size='small'
+                onClick={() => setShowBulkEnableDialog(true)}
+            >
+                Enable
+            </Button>
+            <Button
+                variant='outlined'
+                size='small'
+                onClick={() => setShowBulkDisableDialog(true)}
+            >
+                Disable
+            </Button>
             <ArchiveButton
                 projectId={projectId}
                 featureIds={selectedIds}
diff --git a/frontend/src/interfaces/uiConfig.ts b/frontend/src/interfaces/uiConfig.ts
index a96e647889..4ddb37bc1c 100644
--- a/frontend/src/interfaces/uiConfig.ts
+++ b/frontend/src/interfaces/uiConfig.ts
@@ -59,7 +59,6 @@ export type UiFlags = {
     personalAccessTokensKillSwitch?: boolean;
     demo?: boolean;
     googleAuthEnabled?: boolean;
-    disableBulkToggle?: boolean;
     advancedPlayground?: boolean;
     strategyVariant?: boolean;
     doraMetrics?: boolean;
diff --git a/src/lib/features/feature-toggle/feature-toggle-controller.ts b/src/lib/features/feature-toggle/feature-toggle-controller.ts
index 1b2bdcd6cf..3380a61a09 100644
--- a/src/lib/features/feature-toggle/feature-toggle-controller.ts
+++ b/src/lib/features/feature-toggle/feature-toggle-controller.ts
@@ -918,11 +918,6 @@ export default class ProjectFeaturesController extends Controller {
         const { shouldActivateDisabledStrategies } = req.query;
         const { features } = req.body;
 
-        if (this.flagResolver.isEnabled('disableBulkToggle')) {
-            res.status(403).end();
-            return;
-        }
-
         await this.transactionalFeatureToggleService.transactional((service) =>
             service.bulkUpdateEnabled(
                 projectId,
@@ -950,11 +945,6 @@ export default class ProjectFeaturesController extends Controller {
         const { shouldActivateDisabledStrategies } = req.query;
         const { features } = req.body;
 
-        if (this.flagResolver.isEnabled('disableBulkToggle')) {
-            res.status(403).end();
-            return;
-        }
-
         await this.transactionalFeatureToggleService.transactional((service) =>
             service.bulkUpdateEnabled(
                 projectId,
diff --git a/src/lib/types/experimental.ts b/src/lib/types/experimental.ts
index cc3a22d432..5d2f714e73 100644
--- a/src/lib/types/experimental.ts
+++ b/src/lib/types/experimental.ts
@@ -17,7 +17,6 @@ export type IFlagKey =
     | 'migrationLock'
     | 'demo'
     | 'googleAuthEnabled'
-    | 'disableBulkToggle'
     | 'advancedPlayground'
     | 'filterInvalidClientMetrics'
     | 'disableMetrics'
@@ -105,10 +104,6 @@ const flags: IFlags = {
         process.env.GOOGLE_AUTH_ENABLED,
         false,
     ),
-    disableBulkToggle: parseEnvVarBoolean(
-        process.env.DISABLE_BULK_TOGGLE,
-        false,
-    ),
     filterInvalidClientMetrics: parseEnvVarBoolean(
         process.env.FILTER_INVALID_CLIENT_METRICS,
         false,