Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-11-24 20:06:55 +01:00
Code Issues Projects Releases Wiki Activity

fix: should be allowed to change strategy (#10441)

Browse Source 
## About the changes
Previous PR: https://github.com/Unleash/unleash/pull/10439 introduced a
bug not allowing to update the strategy name

This PR modifies a test to also validate the change of strategy and
fixes the problem
This commit is contained in:
Gastón Fournier 2025-07-30 17:25:17 +02:00 committed by GitHub
parent 0d0257bbdc
commit 2f1ca50bc4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/lib/features/feature-toggle/feature-toggle-service.ts
View File

@ -698,8 +698,8 @@ export class FeatureToggleService {
strategyConfig: Unsaved<IStrategyConfig>, strategyConfig: Unsaved<IStrategyConfig>,
existing?: IFeatureStrategy, existing?: IFeatureStrategy,
): Promise< ): Promise<
{ strategyName: string } & Pick< { name: string } & Pick<
Partial<IFeatureStrategy>, Partial<IStrategyConfig>,
| 'title' | 'title'
| 'disabled' | 'disabled'
| 'variants' | 'variants'
@ -731,7 +731,7 @@ export class FeatureToggleService {
} }
return { return {
strategyName: name, name,
title, title,
disabled, disabled,
sortOrder, sortOrder,
@ -770,6 +770,7 @@ export class FeatureToggleService {
const newFeatureStrategy = const newFeatureStrategy =
await this.featureStrategiesStore.createStrategyFeatureEnv({ await this.featureStrategiesStore.createStrategyFeatureEnv({
...standardizedConfig, ...standardizedConfig,
strategyName: standardizedConfig.name,
constraints: standardizedConfig.constraints || [], constraints: standardizedConfig.constraints || [],
variants: standardizedConfig.variants || [], variants: standardizedConfig.variants || [],
parameters: standardizedConfig.parameters || {}, parameters: standardizedConfig.parameters || {},

7
src/lib/features/feature-toggle/tests/feature-toggle-service.e2e.test.ts
View File

@ -136,13 +136,18 @@ test('Should be able to update existing strategy configuration', async () => {
expect(createdConfig.name).toEqual('default'); expect(createdConfig.name).toEqual('default');
const updatedConfig = await service.updateStrategy( const updatedConfig = await service.updateStrategy(
createdConfig.id, createdConfig.id,
{ parameters: { b2b: 'true' } }, { name: 'flexibleRollout', parameters: { b2b: 'true' } },
{ projectId, featureName, environment: DEFAULT_ENV }, { projectId, featureName, environment: DEFAULT_ENV },
TEST_AUDIT_USER, TEST_AUDIT_USER,
); );
expect(createdConfig.id).toEqual(updatedConfig.id); expect(createdConfig.id).toEqual(updatedConfig.id);
expect(updatedConfig.name).toEqual('flexibleRollout');
expect(updatedConfig.parameters).toEqual({ expect(updatedConfig.parameters).toEqual({
b2b: 'true', b2b: 'true',
// flexible rollout default parameters
rollout: '100',
groupId: featureName,
stickiness: 'default',
}); });
}); });