Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: PAT not taking into account expires_at (#2167)

Browse Source
This commit is contained in:
Nuno Góis 2022-10-10 15:38:47 +01:00 committed by GitHub
parent 0651c83bd1
commit 2fa86ef97f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/db/user-store.ts
View File

@ -215,6 +215,7 @@ class UserStore implements IUserStore {
`${TABLE}.id`,
)
.where('secret', secret)
.andWhere('expires_at', '>', 'now()')
.first();
return rowToUser(row);
}

18
src/test/e2e/api/admin/user/pat.e2e.test.ts
View File

@ -2,9 +2,11 @@ import { IUnleashTest, setupAppWithAuth } from '../../../helpers/test-helper';
import dbInit, { ITestDb } from '../../../helpers/database-init';
import getLogger from '../../../../fixtures/no-logger';
import { IPat } from '../../../../../lib/types/models/pat';
import { IPatStore } from '../../../../../lib/types/stores/pat-store';
let app: IUnleashTest;
let db: ITestDb;
let patStore: IPatStore;
let tomorrow = new Date();
let firstSecret;
@ -13,6 +15,7 @@ tomorrow.setDate(tomorrow.getDate() + 1);
beforeAll(async () => {
db = await dbInit('user_pat', getLogger);
patStore = db.stores.patStore;
app = await setupAppWithAuth(db.stores, {
experimental: { flags: { personalAccessTokens: true } },
});
@ -188,3 +191,18 @@ test('should not get user with invalid token', async () => {
.set('Authorization', 'randomtoken')
.expect(401);
});
test('should not get user with expired token', async () => {
const token = await patStore.create({
id: 1,
secret: 'user:expired-token',
description: 'expired-token',
userId: 1,
expiresAt: new Date('2020-01-01'),
});
await app.request
.get('/api/admin/user')
.set('Authorization', token.secret)
.expect(401);
});