Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-05-22 01:16:07 +02:00
Code Issues Projects Releases Wiki Activity

feat: always show features table (#9446)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2025-03-10 10:19:36 +01:00 committed by GitHub
parent 6d02e33680
commit 3059d23446
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 104 additions and 124 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.tsx
View File

@ -148,14 +148,9 @@ export const ProjectFeatureToggles = ({
'hide-setup' | 'show-setup' 'hide-setup' | 'show-setup'
>(`onboarding-state:v1-${projectId}`, 'hide-setup'); >(`onboarding-state:v1-${projectId}`, 'hide-setup');
const notOnboarding =
project.onboardingStatus.status === 'onboarded' ||
onboardingFlow === 'closed';
const isOnboarding = const isOnboarding =
project.onboardingStatus.status !== 'onboarded' && project.onboardingStatus.status !== 'onboarded' &&
onboardingFlow === 'visible'; onboardingFlow === 'visible';
const noFeaturesExistInProject = project.featureTypeCounts?.length === 0;
const showFeaturesTable = !noFeaturesExistInProject || notOnboarding;
const trackOnboardingFinish = (sdkName: string) => { const trackOnboardingFinish = (sdkName: string) => {
if (!isOnboarding) { if (!isOnboarding) {
@ -495,9 +490,6 @@ export const ProjectFeatureToggles = ({
/> />
} }
/> />
<ConditionallyRender
condition={showFeaturesTable}
show={
<PageContent <PageContent
disableLoading disableLoading
disablePadding disablePadding
@ -517,39 +509,33 @@ export const ProjectFeatureToggles = ({
{ {
header: 'Name', header: 'Name',
id: 'name', id: 'name',
isVisible: isVisible: columnVisibility.name,
columnVisibility.name,
isStatic: true, isStatic: true,
}, },
{ {
header: 'Created', header: 'Created',
id: 'createdAt', id: 'createdAt',
isVisible: isVisible: columnVisibility.createdAt,
columnVisibility.createdAt,
}, },
{ {
header: 'By', header: 'By',
id: 'createdBy', id: 'createdBy',
isVisible: isVisible: columnVisibility.createdBy,
columnVisibility.createdBy,
}, },
{ {
header: 'Last seen', header: 'Last seen',
id: 'lastSeenAt', id: 'lastSeenAt',
isVisible: isVisible: columnVisibility.lastSeenAt,
columnVisibility.lastSeenAt,
}, },
{ {
header: 'Lifecycle', header: 'Lifecycle',
id: 'lifecycle', id: 'lifecycle',
isVisible: isVisible: columnVisibility.lifecycle,
columnVisibility.lifecycle,
}, },
{ {
id: 'divider', id: 'divider',
}, },
...environments.map( ...environments.map((environment) => ({
(environment) => ({
header: environment, header: environment,
id: formatEnvironmentColumnId( id: formatEnvironmentColumnId(
environment, environment,
@ -560,8 +546,7 @@ export const ProjectFeatureToggles = ({
environment, environment,
) )
], ],
}), })),
),
]} ]}
onToggle={onToggleColumnVisibility} onToggle={onToggleColumnVisibility}
/> />
@ -595,9 +580,7 @@ export const ProjectFeatureToggles = ({
</PermissionIconButton> </PermissionIconButton>
</ButtonGroup> </ButtonGroup>
</FilterRow> </FilterRow>
<SearchHighlightProvider <SearchHighlightProvider value={tableState.query || ''}>
value={tableState.query || ''}
>
<PaginatedTable <PaginatedTable
tableInstance={table} tableInstance={table}
totalItems={total} totalItems={total}
@ -606,17 +589,14 @@ export const ProjectFeatureToggles = ({
<ConditionallyRender <ConditionallyRender
condition={!data.length && !isPlaceholder} condition={!data.length && !isPlaceholder}
show={ show={
<TableEmptyState <TableEmptyState query={tableState.query || ''} />
query={tableState.query || ''}
/>
} }
/> />
{rowActionsDialogs} {rowActionsDialogs}
{featureToggleModals} {featureToggleModals}
</div> </div>
</PageContent> </PageContent>
}
/>
<ConnectSdkDialog <ConnectSdkDialog
open={connectSdkOpen} open={connectSdkOpen}
onClose={() => { onClose={() => {