Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2026-01-05 20:06:22 +01:00
Code Issues Projects Releases Wiki Activity

feat: add error handling to release plan changes (#11030)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2025-11-26 17:29:38 +01:00 committed by GitHub
parent 3d2a4616c6
commit 312591d826
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 44 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

79
frontend/src/component/changeRequest/ChangeRequest/Changes/Change/ReleasePlanChange.tsx
View File

@ -347,7 +347,7 @@ export const ReleasePlanChange: FC<{
usePendingChangeRequests(projectId);
const { setToastData, setToastApiError } = useToast();
const handleChangeSafeguardSubmit = async (data: CreateSafeguardSchema) => {
const changeSafeguardSubmit = async (data: CreateSafeguardSchema) => {
try {
await addChange(projectId, environmentName, {
feature: featureName,
@ -362,47 +362,56 @@ export const ReleasePlanChange: FC<{
type: 'success',
text: 'Added to draft',
});
onRefetch?.();
} catch (error: unknown) {
setToastApiError(formatUnknownError(error));
}
};
const handleUpdateChangeRequestSubmit = async (
const changeMilestoneProgressionSubmit = async (
sourceMilestoneId: string,
payload: ChangeMilestoneProgressionSchema,
) => {
await addChange(projectId, environmentName, {
feature: featureName,
action: 'changeMilestoneProgression',
payload: {
sourceMilestone: sourceMilestoneId,
...payload,
},
});
await refetchChangeRequests();
setToastData({
type: 'success',
text: 'Added to draft',
});
onRefetch?.();
try {
await addChange(projectId, environmentName, {
feature: featureName,
action: 'changeMilestoneProgression',
payload: {
sourceMilestone: sourceMilestoneId,
...payload,
},
});
await refetchChangeRequests();
setToastData({
type: 'success',
text: 'Added to draft',
});
onRefetch?.();
} catch (error) {
setToastApiError(formatUnknownError(error));
}
};
const handleDeleteChangeRequestSubmit = async (
const deleteMilestonProgressionSubmit = async (
sourceMilestoneId: string,
) => {
await addChange(projectId, environmentName, {
feature: featureName,
action: 'deleteMilestoneProgression',
payload: {
sourceMilestone: sourceMilestoneId,
},
});
await refetchChangeRequests();
setToastData({
type: 'success',
text: 'Added to draft',
});
await onRefetch?.();
try {
await addChange(projectId, environmentName, {
feature: featureName,
action: 'deleteMilestoneProgression',
payload: {
sourceMilestone: sourceMilestoneId,
},
});
await refetchChangeRequests();
setToastData({
type: 'success',
text: 'Added to draft',
});
onRefetch?.();
} catch (error) {
setToastApiError(formatUnknownError(error));
}
};
// If this is a progression change and we have the full feature object,
@ -435,8 +444,8 @@ export const ReleasePlanChange: FC<{
feature={feature}
currentReleasePlan={currentReleasePlan}
changeRequestState={changeRequestState}
onUpdateChangeRequestSubmit={handleUpdateChangeRequestSubmit}
onDeleteChangeRequestSubmit={handleDeleteChangeRequestSubmit}
onUpdateChangeRequestSubmit={changeMilestoneProgressionSubmit}
onDeleteChangeRequestSubmit={deleteMilestonProgressionSubmit}
/>
);
}
@ -474,7 +483,7 @@ export const ReleasePlanChange: FC<{
currentReleasePlan={currentReleasePlan}
changeRequestState={changeRequestState}
environmentName={environmentName}
onSubmit={handleChangeSafeguardSubmit}
onSubmit={changeSafeguardSubmit}
actions={actions}
/>
)}
@ -485,10 +494,10 @@ export const ReleasePlanChange: FC<{
actions={actions}
changeRequestState={changeRequestState}
onUpdateChangeRequestSubmit={
handleUpdateChangeRequestSubmit
changeMilestoneProgressionSubmit
}
onDeleteChangeRequestSubmit={
handleDeleteChangeRequestSubmit
deleteMilestonProgressionSubmit
}
/>
)}