1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-23 00:22:19 +01:00

feat: Make multiple roles per group/user GA by removing the flag (#5109)

To prepare for 5.6 GA, 
I've done a find through both Frontend and Backend here to remove the
usages of the flag. Seems like the flag was only in use in the frontend.
@nunogois can you confirm?
This commit is contained in:
Christopher Kolstad 2023-10-23 14:32:15 +02:00 committed by GitHub
parent 69d050a70f
commit 314a08b4e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 29 deletions

View File

@ -441,29 +441,12 @@ export const ProjectAccessAssign = ({
Select the role to assign for this project Select the role to assign for this project
</StyledInputDescription> </StyledInputDescription>
<StyledAutocompleteWrapper> <StyledAutocompleteWrapper>
<ConditionallyRender
condition={Boolean(
uiConfig.flags.multipleRoles,
)}
show={() => (
<MultipleRoleSelect <MultipleRoleSelect
data-testid={PA_ROLE_ID} data-testid={PA_ROLE_ID}
roles={roles} roles={roles}
value={selectedRoles} value={selectedRoles}
setValue={setRoles} setValue={setRoles}
/> />
)}
elseShow={() => (
<RoleSelect
data-testid={PA_ROLE_ID}
roles={roles}
value={selectedRoles[0]}
setValue={(role) =>
setRoles(role ? [role] : [])
}
/>
)}
/>
</StyledAutocompleteWrapper> </StyledAutocompleteWrapper>
</div> </div>

View File

@ -106,7 +106,6 @@ exports[`should create default config 1`] = `
}, },
}, },
"migrationLock": true, "migrationLock": true,
"multipleRoles": false,
"personalAccessTokensKillSwitch": false, "personalAccessTokensKillSwitch": false,
"playgroundImprovements": false, "playgroundImprovements": false,
"privateProjects": false, "privateProjects": false,
@ -151,7 +150,6 @@ exports[`should create default config 1`] = `
}, },
}, },
"migrationLock": true, "migrationLock": true,
"multipleRoles": false,
"personalAccessTokensKillSwitch": false, "personalAccessTokensKillSwitch": false,
"playgroundImprovements": false, "playgroundImprovements": false,
"privateProjects": false, "privateProjects": false,

View File

@ -23,7 +23,6 @@ export type IFlagKey =
| 'filterInvalidClientMetrics' | 'filterInvalidClientMetrics'
| 'lastSeenByEnvironment' | 'lastSeenByEnvironment'
| 'customRootRolesKillSwitch' | 'customRootRolesKillSwitch'
| 'multipleRoles'
| 'featureNamingPattern' | 'featureNamingPattern'
| 'doraMetrics' | 'doraMetrics'
| 'variantTypeNumber' | 'variantTypeNumber'
@ -117,10 +116,6 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_CUSTOM_ROOT_ROLES_KILL_SWITCH, process.env.UNLEASH_EXPERIMENTAL_CUSTOM_ROOT_ROLES_KILL_SWITCH,
false, false,
), ),
multipleRoles: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_MULTIPLE_ROLES,
false,
),
featureNamingPattern: parseEnvVarBoolean( featureNamingPattern: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_FEATURE_NAMING_PATTERN, process.env.UNLEASH_EXPERIMENTAL_FEATURE_NAMING_PATTERN,
false, false,