From 31a23db05eb3164605be41cd08e234d878ea3e13 Mon Sep 17 00:00:00 2001
From: Jaanus Sellin <sellinjaanus@gmail.com>
Date: Tue, 13 May 2025 10:19:11 +0300
Subject: [PATCH] chore: clarify deleted legal values warning (#9969)

---
 .../RestrictiveLegalValues.test.tsx                       | 2 +-
 .../RestrictiveLegalValues/RestrictiveLegalValues.tsx     | 8 ++++----
 .../cells/FeatureOverviewCell/FeatureOverviewCell.tsx     | 1 -
 .../FeatureStrategyConstraints/LegalValuesSelector.tsx    | 7 ++++---
 .../FeatureOverview/FeatureOverviewMetaData/TagRow.tsx    | 2 --
 frontend/src/component/tags/TagTypeForm/useTagTypeForm.ts | 1 -
 frontend/src/component/tags/TagTypeList/TagTypeList.tsx   | 1 -
 7 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/RestrictiveLegalValues/RestrictiveLegalValues.test.tsx b/frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/RestrictiveLegalValues/RestrictiveLegalValues.test.tsx
index 71d0fb103d..43f3e7dbb8 100644
--- a/frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/RestrictiveLegalValues/RestrictiveLegalValues.test.tsx
+++ b/frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/RestrictiveLegalValues/RestrictiveLegalValues.test.tsx
@@ -28,7 +28,7 @@ test('should show alert when you have illegal legal values', async () => {
     );
 
     await screen.findByText(
-        'This constraint is using legal values that have been deleted as valid options. If you save changes on this constraint and then save the strategy the following values will be removed:',
+        'This constraint is currently using values that were valid in the past but have since been deleted. If you save changes on this constraint and then save the strategy the following values will be removed:',
     );
 });
 
diff --git a/frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/RestrictiveLegalValues/RestrictiveLegalValues.tsx b/frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/RestrictiveLegalValues/RestrictiveLegalValues.tsx
index 3893efc8cc..b61e799bff 100644
--- a/frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/RestrictiveLegalValues/RestrictiveLegalValues.tsx
+++ b/frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/RestrictiveLegalValues/RestrictiveLegalValues.tsx
@@ -173,10 +173,10 @@ export const RestrictiveLegalValues = ({
                 condition={Boolean(illegalValues && illegalValues.length > 0)}
                 show={
                     <Alert severity='warning'>
-                        This constraint is using legal values that have been
-                        deleted as valid options. If you save changes on this
-                        constraint and then save the strategy the following
-                        values will be removed:
+                        This constraint is currently using values that were
+                        valid in the past but have since been deleted. If you
+                        save changes on this constraint and then save the
+                        strategy the following values will be removed:
                         <ul>
                             {illegalValues?.map((value) => (
                                 <li key={value}>{value}</li>
diff --git a/frontend/src/component/common/Table/cells/FeatureOverviewCell/FeatureOverviewCell.tsx b/frontend/src/component/common/Table/cells/FeatureOverviewCell/FeatureOverviewCell.tsx
index 999104ca86..ff5c9085b2 100644
--- a/frontend/src/component/common/Table/cells/FeatureOverviewCell/FeatureOverviewCell.tsx
+++ b/frontend/src/component/common/Table/cells/FeatureOverviewCell/FeatureOverviewCell.tsx
@@ -17,7 +17,6 @@ import { useFeature } from 'hooks/api/getters/useFeature/useFeature';
 import { useLocationSettings } from 'hooks/useLocationSettings';
 import { getLocalizedDateString } from '../../../util';
 import { Tag } from 'component/common/Tag/Tag';
-import { useUiFlag } from 'hooks/useUiFlag';
 import { formatTag } from 'utils/format-tag';
 
 interface IFeatureNameCellProps {
diff --git a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/LegalValuesSelector.tsx b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/LegalValuesSelector.tsx
index 15bc4ef08c..9bdc15972b 100644
--- a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/LegalValuesSelector.tsx
+++ b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/LegalValuesSelector.tsx
@@ -77,9 +77,10 @@ const BaseLegalValueSelector: FC<BaseProps> = ({
         <LegalValuesSelectorWidget>
             {deletedLegalValues?.size ? (
                 <Alert id={alertId} severity='warning'>
-                    This constraint is using legal values that have been deleted
-                    as valid options. If you save changes on this constraint and
-                    then save the strategy the following values will be removed:
+                    This constraint is currently using values that were valid in
+                    the past but have since been deleted. If you save changes on
+                    this constraint and then save the strategy the following
+                    values will be removed:
                     <ul>
                         {[...deletedLegalValues].map((value) => (
                             <li key={value}>{value}</li>
diff --git a/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewMetaData/TagRow.tsx b/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewMetaData/TagRow.tsx
index aa4c4ccffd..0749775eca 100644
--- a/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewMetaData/TagRow.tsx
+++ b/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewMetaData/TagRow.tsx
@@ -2,7 +2,6 @@ import type { IFeatureToggle } from 'interfaces/featureToggle';
 import { useContext, useState } from 'react';
 import { styled, Tooltip, Chip } from '@mui/material';
 import useFeatureTags from 'hooks/api/getters/useFeatureTags/useFeatureTags';
-import DeleteTagIcon from '@mui/icons-material/Cancel';
 import ClearIcon from '@mui/icons-material/Clear';
 import { ManageTagsDialog } from 'component/feature/FeatureView/FeatureOverview/ManageTagsDialog/ManageTagsDialog';
 import { UPDATE_FEATURE } from 'component/providers/AccessProvider/permissions';
@@ -15,7 +14,6 @@ import { formatUnknownError } from 'utils/formatUnknownError';
 import { StyledMetaDataItem } from './FeatureOverviewMetaData';
 import { AddTagButton } from './AddTagButton';
 import { Tag } from 'component/common/Tag/Tag';
-import { useUiFlag } from 'hooks/useUiFlag';
 import { formatTag } from 'utils/format-tag';
 
 const StyledLabel = styled('span')(({ theme }) => ({
diff --git a/frontend/src/component/tags/TagTypeForm/useTagTypeForm.ts b/frontend/src/component/tags/TagTypeForm/useTagTypeForm.ts
index 75d5a4417f..168d305de1 100644
--- a/frontend/src/component/tags/TagTypeForm/useTagTypeForm.ts
+++ b/frontend/src/component/tags/TagTypeForm/useTagTypeForm.ts
@@ -1,7 +1,6 @@
 import { useEffect, useState } from 'react';
 import useTagTypesApi from 'hooks/api/actions/useTagTypesApi/useTagTypesApi';
 import { formatUnknownError } from 'utils/formatUnknownError';
-import { useUiFlag } from 'hooks/useUiFlag';
 
 interface TagTypePayload {
     name: string;
diff --git a/frontend/src/component/tags/TagTypeList/TagTypeList.tsx b/frontend/src/component/tags/TagTypeList/TagTypeList.tsx
index 7b23c83281..7be94af237 100644
--- a/frontend/src/component/tags/TagTypeList/TagTypeList.tsx
+++ b/frontend/src/component/tags/TagTypeList/TagTypeList.tsx
@@ -31,7 +31,6 @@ import { LinkCell } from 'component/common/Table/cells/LinkCell/LinkCell';
 import { sortTypes } from 'utils/sortTypes';
 import { AddTagTypeButton } from './AddTagTypeButton/AddTagTypeButton';
 import { Search } from 'component/common/Search/Search';
-import { useUiFlag } from 'hooks/useUiFlag';
 
 const StyledColorDot = styled('div')<{ $color: string }>(
     ({ theme, $color }) => ({