Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

fix: ignore metrics for non-existent features (#6945)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-04-26 10:30:12 +02:00 committed by GitHub
parent 8ed15165d2
commit 31ab38e162
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/lib/features/feature-lifecycle/feature-lifecycle-store.ts
View File

@ -22,9 +22,22 @@ export class FeatureLifecycleStore implements IFeatureLifecycleStore {
async insert(
featureLifecycleStages: FeatureLifecycleStage[],
): Promise<void> {
const existingFeatures = await this.db('features')
.select('name')
.whereIn(
'name',
featureLifecycleStages.map((stage) => stage.feature),
);
const existingFeaturesSet = new Set(
existingFeatures.map((item) => item.name),
);
const validStages = featureLifecycleStages.filter((stage) =>
existingFeaturesSet.has(stage.feature),
);
await this.db('feature_lifecycles')
.insert(
featureLifecycleStages.map((stage) => ({
validStages.map((stage) => ({
feature: stage.feature,
stage: stage.stage,
})),

7
src/lib/features/feature-lifecycle/feature-lifecycle.e2e.test.ts
View File

@ -87,7 +87,12 @@ test('should return lifecycle stages', async () => {
await reachedStage('initial');
await expectFeatureStage('initial');
eventBus.emit(CLIENT_METRICS, {
bucket: { toggles: { my_feature_a: 'irrelevant' } },
bucket: {
toggles: {
my_feature_a: 'irrelevant',
non_existent_feature: 'irrelevent',
},
},
environment: 'default',
});
// missing feature