From 32996460df24980cb61514d87dae89e792bfe963 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nuno=20G=C3=B3is?= Date: Wed, 30 Jul 2025 10:17:03 +0100 Subject: [PATCH] chore: adapt configuration modal to standard and advanced strategies (#10434) https://linear.app/unleash/issue/2-3730/adapt-modal-to-new-standard-and-advanced-strategies-split Adapts our "add configuration" modal to the new concept of standard and advanced strategies. Follow-up to: https://github.com/Unleash/unleash/pull/10433 image --- .../FeatureStrategyMenuCards.tsx | 48 +++++++++++-------- 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyMenu/FeatureStrategyMenuCards/FeatureStrategyMenuCards.tsx b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyMenu/FeatureStrategyMenuCards/FeatureStrategyMenuCards.tsx index ec5c86ead3..37a3f4bdd4 100644 --- a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyMenu/FeatureStrategyMenuCards/FeatureStrategyMenuCards.tsx +++ b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyMenu/FeatureStrategyMenuCards/FeatureStrategyMenuCards.tsx @@ -130,12 +130,16 @@ export const FeatureStrategyMenuCards = ({ const { templates } = useReleasePlanTemplates(); const navigate = useNavigate(); - const preDefinedStrategies = strategies.filter( - (strategy) => !strategy.deprecated && !strategy.editable, + const activeStrategies = strategies.filter( + (strategy) => !strategy.deprecated, ); - const customStrategies = strategies.filter( - (strategy) => !strategy.deprecated && strategy.editable, + const standardStrategies = activeStrategies.filter( + (strategy) => !strategy.advanced && !strategy.editable, + ); + + const advancedAndCustomStrategies = activeStrategies.filter( + (strategy) => strategy.editable || strategy.advanced, ); const defaultStrategy = { @@ -225,7 +229,7 @@ export const FeatureStrategyMenuCards = ({ Standard strategies @@ -240,7 +244,7 @@ export const FeatureStrategyMenuCards = ({ onClose={onClose} /> - {preDefinedStrategies.map((strategy) => ( + {standardStrategies.map((strategy) => ( {renderReleasePlanTemplates()} - {customStrategies.length > 0 && ( + {advancedAndCustomStrategies.length > 0 && ( - Custom strategies + Custom and advanced strategies - {customStrategies.map((strategy) => ( - - - - ))} + {advancedAndCustomStrategies.map( + (strategy) => ( + + + + ), + )} )}