Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: Use knex whereLike instead of whereRaw to fix escaping (#6041)

Browse Source 
This escape with `??` double escaped the LIKE query causing no results.
This updates to using whereLike, which does the correct escaping for
string query.
This commit is contained in:
Christopher Kolstad 2024-01-26 10:44:53 +01:00 committed by GitHub
parent 32484460ef
commit 32dd377c3e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/db/client-instance-store.ts
View File

@ -167,10 +167,11 @@ export default class ClientInstanceStore implements IClientInstanceStore {
} }
async getBySdkName(sdkName: string): Promise<IClientInstance[]> { async getBySdkName(sdkName: string): Promise<IClientInstance[]> {
const sdkPrefix = `${sdkName}%`;
const rows = await this.db const rows = await this.db
.select() .select()
.from(TABLE) .from(TABLE)
.whereRaw(`sdk_version LIKE '??%'`, [sdkName]) .whereLike('sdk_version', sdkPrefix)
.orderBy('last_seen', 'desc'); .orderBy('last_seen', 'desc');
return rows.map(mapRow); return rows.map(mapRow);
} }