From 33288caae42733328b09dc37cd94c8e751b3a2f4 Mon Sep 17 00:00:00 2001
From: andreas-unleash <104830839+andreas-unleash@users.noreply.github.com>
Date: Fri, 5 Aug 2022 12:16:51 +0300
Subject: [PATCH] PR comments

---
 .../PlaygroundResultFeatureDetails.styles.ts          |  6 +++---
 .../PlaygroundResultFeatureDetails.tsx                |  4 ++--
 ...undConstraintAccordionViewHeaderMultipleValues.tsx |  4 ++--
 ...groundConstraintAccordionViewHeaderSingleValue.tsx |  4 ++--
 .../PlaygroundResultStrategyExecution/helepers.ts     | 11 ++++-------
 5 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureDetails/PlaygroundResultFeatureDetails.styles.ts b/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureDetails/PlaygroundResultFeatureDetails.styles.ts
index 947511f64e..307018fdc8 100644
--- a/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureDetails/PlaygroundResultFeatureDetails.styles.ts
+++ b/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureDetails/PlaygroundResultFeatureDetails.styles.ts
@@ -10,8 +10,8 @@ export const useStyles = makeStyles()(theme => ({
         display: 'inline-flex',
         alignItems: 'flex-start',
         justifyContent: 'center',
-        gap: '12px',
-        marginTop: '12px',
+        gap: theme.spacing(1.5),
+        marginTop: theme.spacing(1.5),
     },
     alertRow: {
         margin: theme.spacing(1, 0),
@@ -21,7 +21,7 @@ export const useStyles = makeStyles()(theme => ({
     },
     name: {
         fontWeight: 600,
-        padding: '4px',
+        padding: theme.spacing(0.5),
     },
     icon: {
         textAlign: 'right',
diff --git a/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureDetails/PlaygroundResultFeatureDetails.tsx b/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureDetails/PlaygroundResultFeatureDetails.tsx
index 5eee35de8f..f49242d74e 100644
--- a/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureDetails/PlaygroundResultFeatureDetails.tsx
+++ b/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureDetails/PlaygroundResultFeatureDetails.tsx
@@ -36,8 +36,8 @@ export const PlaygroundResultFeatureDetails = ({
         : !feature.isEnabledInCurrentEnvironment
         ? 'the environment is disabled'
         : hasOnlyCustomStrategies(feature)
-        ? 'all strategies are Unevaluated'
-        : 'all strategies are False or Uneavaluated';
+        ? 'no strategies could be fully evaluated'
+        : 'all strategies are either False or could not be fully evaluated';
 
     const color = feature.isEnabled
         ? theme.palette.success.main
diff --git a/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/PlaygroundResultConstraintExecution/PlaygroundResultConstraintAccordion/PlaygroundResultConstraintAccordionView/PlaygroundConstraintAccordionViewHeader/PlaygroundConstraintAccordionViewHeaderInfo/PlaygroundContraintAccordionViewHeaderMultipleValues/PLaygroundConstraintAccordionViewHeaderMultipleValues.tsx b/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/PlaygroundResultConstraintExecution/PlaygroundResultConstraintAccordion/PlaygroundResultConstraintAccordionView/PlaygroundConstraintAccordionViewHeader/PlaygroundConstraintAccordionViewHeaderInfo/PlaygroundContraintAccordionViewHeaderMultipleValues/PLaygroundConstraintAccordionViewHeaderMultipleValues.tsx
index 7342803411..73e11367e1 100644
--- a/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/PlaygroundResultConstraintExecution/PlaygroundResultConstraintAccordion/PlaygroundResultConstraintAccordionView/PlaygroundConstraintAccordionViewHeader/PlaygroundConstraintAccordionViewHeaderInfo/PlaygroundContraintAccordionViewHeaderMultipleValues/PLaygroundConstraintAccordionViewHeaderMultipleValues.tsx
+++ b/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/PlaygroundResultConstraintExecution/PlaygroundResultConstraintAccordion/PlaygroundResultConstraintAccordionView/PlaygroundConstraintAccordionViewHeader/PlaygroundConstraintAccordionViewHeaderInfo/PlaygroundContraintAccordionViewHeaderMultipleValues/PLaygroundConstraintAccordionViewHeaderMultipleValues.tsx
@@ -19,7 +19,7 @@ const StyledValuesSpan = styled('span')(({ theme }) => ({
     },
 }));
 
-interface ConstraintSingleValueProps {
+interface PLaygroundConstraintAccordionViewHeaderMultipleValueProps {
     constraint: PlaygroundConstraintSchema;
     expanded: boolean;
     maxLength: number;
@@ -31,7 +31,7 @@ export const PLaygroundConstraintAccordionViewHeaderMultipleValues = ({
     expanded,
     allowExpand,
     maxLength,
-}: ConstraintSingleValueProps) => {
+}: PLaygroundConstraintAccordionViewHeaderMultipleValueProps) => {
     const { classes: styles } = useStyles();
 
     const [expandable, setExpandable] = useState(false);
diff --git a/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/PlaygroundResultConstraintExecution/PlaygroundResultConstraintAccordion/PlaygroundResultConstraintAccordionView/PlaygroundConstraintAccordionViewHeader/PlaygroundConstraintAccordionViewHeaderInfo/PlaygroundContraintAccordionViewHeaderSingleValue/PlaygroundConstraintAccordionViewHeaderSingleValue.tsx b/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/PlaygroundResultConstraintExecution/PlaygroundResultConstraintAccordion/PlaygroundResultConstraintAccordionView/PlaygroundConstraintAccordionViewHeader/PlaygroundConstraintAccordionViewHeaderInfo/PlaygroundContraintAccordionViewHeaderSingleValue/PlaygroundConstraintAccordionViewHeaderSingleValue.tsx
index 82e706de36..ac2bad077e 100644
--- a/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/PlaygroundResultConstraintExecution/PlaygroundResultConstraintAccordion/PlaygroundResultConstraintAccordionView/PlaygroundConstraintAccordionViewHeader/PlaygroundConstraintAccordionViewHeaderInfo/PlaygroundContraintAccordionViewHeaderSingleValue/PlaygroundConstraintAccordionViewHeaderSingleValue.tsx
+++ b/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/PlaygroundResultConstraintExecution/PlaygroundResultConstraintAccordion/PlaygroundResultConstraintAccordionView/PlaygroundConstraintAccordionViewHeader/PlaygroundConstraintAccordionViewHeaderInfo/PlaygroundContraintAccordionViewHeaderSingleValue/PlaygroundConstraintAccordionViewHeaderSingleValue.tsx
@@ -13,7 +13,7 @@ const StyledSingleValueChip = styled(Chip)(({ theme }) => ({
     },
 }));
 
-interface ConstraintSingleValueProps {
+interface PlaygroundConstraintAccordionViewHeaderSingleValueProps {
     constraint: PlaygroundConstraintSchema;
     allowExpand: (shouldExpand: boolean) => void;
 }
@@ -21,7 +21,7 @@ interface ConstraintSingleValueProps {
 export const PlaygroundConstraintAccordionViewHeaderSingleValue = ({
     constraint,
     allowExpand,
-}: ConstraintSingleValueProps) => {
+}: PlaygroundConstraintAccordionViewHeaderSingleValueProps) => {
     const { locationSettings } = useLocationSettings();
     const { classes: styles } = useStyles();
 
diff --git a/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/helepers.ts b/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/helepers.ts
index 8a40068ec3..7e741a8f52 100644
--- a/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/helepers.ts
+++ b/frontend/src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultStrategyExecution/helepers.ts
@@ -1,13 +1,10 @@
 export const getMappedParam = (key: string) => {
-    switch (key) {
-        case 'userIds':
-        case 'UserIds':
+    switch (key.toUpperCase()) {
+        case 'USERIDS':
             return 'userId';
-        case 'hostNames':
-        case 'HostNames':
-            return 'hostname';
-        case 'IPs':
+        case 'IPS':
             return 'remoteAddress';
+        case 'HOSTNAMES':
         default:
             return key;
     }