Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-05-03 01:18:43 +02:00
Code Issues Projects Releases Wiki Activity

Fix/strategy permissions (#337)

Browse Source 
* fix: only show actions if applicable to the current user

* fix: remove API access from admin settings

* fix: update snapshot
This commit is contained in:
Fredrik Strand Oseberg 2021-09-20 16:59:04 +02:00 committed by GitHub
parent 0baa7b22e9
commit 34df8617d2
3 changed files with 58 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

100
frontend/src/component/feature/strategy/StrategyCard/StrategyCardHeader/StrategyCardHeader.jsx
View File

@ -1,4 +1,4 @@
import React from 'react';
import React, { useContext } from 'react';
import PropTypes from 'prop-types';
import { CardHeader, Typography, IconButton, Tooltip } from '@material-ui/core';
@ -7,6 +7,8 @@ import { Edit, Delete } from '@material-ui/icons';
import { useStyles } from './StrategyCardHeader.styles.js';
import { ReactComponent as ReorderIcon } from '../../../../../assets/icons/reorder.svg';
import ConditionallyRender from '../../../../common/ConditionallyRender/ConditionallyRender';
import AccessContext from '../../../../../contexts/AccessContext';
import { UPDATE_FEATURE } from '../../../../AccessProvider/permissions';
const StrategyCardHeader = ({
name,
@ -15,6 +17,8 @@ const StrategyCardHeader = ({
editStrategy,
disableDelete,
}) => {
const { hasAccess } = useContext(AccessContext);
const styles = useStyles();
return (
@ -33,54 +37,64 @@ const StrategyCardHeader = ({
{name}
</Typography>
</Tooltip>
<div className={styles.strategyCardHeaderActions}>
<Tooltip title="Edit strategy">
<IconButton onClick={editStrategy}>
<Edit
className={styles.strateyCardHeaderIcon}
/>
</IconButton>
</Tooltip>
{connectDragSource(
<span>
<Tooltip title="Drag and drop strategy to reorder. This only affects the order of which your strategies are evaluated.">
<IconButton>
<ReorderIcon />
</IconButton>
</Tooltip>
</span>
)}
<ConditionallyRender
condition={disableDelete}
show={
<Tooltip title="One strategy must always be applied. You can not delete this strategy.">
<span>
<IconButton
onClick={removeStrategy}
disabled={disableDelete}
>
<Delete
className={
styles.strateyCardHeaderIcon
}
/>
</IconButton>
</span>
</Tooltip>
}
elseShow={
<Tooltip title="Delete strategy">
<IconButton onClick={removeStrategy}>
<Delete
<ConditionallyRender
condition={hasAccess(UPDATE_FEATURE)}
show={
<div className={styles.strategyCardHeaderActions}>
<Tooltip title="Edit strategy">
<IconButton onClick={editStrategy}>
<Edit
className={
styles.strateyCardHeaderIcon
}
/>
</IconButton>
</Tooltip>
}
/>
</div>
{connectDragSource(
<span>
<Tooltip title="Drag and drop strategy to reorder. This only affects the order of which your strategies are evaluated.">
<IconButton>
<ReorderIcon />
</IconButton>
</Tooltip>
</span>
)}
<ConditionallyRender
condition={disableDelete}
show={
<Tooltip title="One strategy must always be applied. You can not delete this strategy.">
<span>
<IconButton
onClick={removeStrategy}
disabled={disableDelete}
>
<Delete
className={
styles.strateyCardHeaderIcon
}
/>
</IconButton>
</span>
</Tooltip>
}
elseShow={
<Tooltip title="Delete strategy">
<IconButton
onClick={removeStrategy}
>
<Delete
className={
styles.strateyCardHeaderIcon
}
/>
</IconButton>
</Tooltip>
}
/>
</div>
}
/>
</>
}
disableTypography

1
frontend/src/component/menu/__tests__/__snapshots__/routes-test.jsx.snap
View File

@ -333,7 +333,6 @@ Array [
"component": [Function],
"layout": "main",
"menu": Object {
"adminSettings": true,
"advanced": true,
"mobile": true,
},

2
frontend/src/component/menu/routes.js
View File

@ -380,7 +380,7 @@ export const routes = [
component: AdminApi,
type: 'protected',
layout: 'main',
menu: { mobile: true, advanced: true, adminSettings: true },
menu: { mobile: true, advanced: true },
},
{
path: '/admin/users',