Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-05 17:53:12 +02:00
Code Issues Projects Releases Wiki Activity

fix: add inital support for bulk save metrics

Browse Source
This commit is contained in:
Ivar Conradi Østhus 2021-10-29 09:11:07 +02:00
parent 0e3813f5f6
commit 35286345c4
No known key found for this signature in database
GPG Key ID: 31AC596886B0BD09
1 changed files with 28 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/lib/services/client-metrics/client-metrics-service-v2.ts
View File

@ -9,33 +9,38 @@ import {
} from '../../types/stores/client-metrics-store-v2'; } from '../../types/stores/client-metrics-store-v2';
import { clientMetricsSchema } from './client-metrics-schema'; import { clientMetricsSchema } from './client-metrics-schema';
const FIVE_MINUTES = 5 * 60 * 1000; const DEFAULT_BULK_INTERVAL = 30 * 1000;
const ONE_DAY = 24 * 60 * 60 * 1000; const ONE_DAY = 24 * 60 * 60 * 1000;
export default class ClientMetricsServiceV2 { export default class ClientMetricsServiceV2 {
private timer: NodeJS.Timeout; private timer: NodeJS.Timeout;
private bulkTimer: NodeJS.Timeout;
private clientMetricsStoreV2: IClientMetricsStoreV2; private clientMetricsStoreV2: IClientMetricsStoreV2;
private logger: Logger; private logger: Logger;
private bulkInterval: number; private unsavedMetics: IClientMetricsEnv[] = [];
constructor( constructor(
{ clientMetricsStoreV2 }: Pick<IUnleashStores, 'clientMetricsStoreV2'>, { clientMetricsStoreV2 }: Pick<IUnleashStores, 'clientMetricsStoreV2'>,
{ getLogger }: Pick<IUnleashConfig, 'getLogger'>, { getLogger }: Pick<IUnleashConfig, 'getLogger'>,
bulkInterval = FIVE_MINUTES, bulkInterval = DEFAULT_BULK_INTERVAL,
) { ) {
this.clientMetricsStoreV2 = clientMetricsStoreV2; this.clientMetricsStoreV2 = clientMetricsStoreV2;
this.logger = getLogger('/services/client-metrics/index.ts'); this.logger = getLogger('/services/client-metrics/index.ts');
this.bulkInterval = bulkInterval;
this.timer = setInterval(() => { this.timer = setInterval(() => {
console.log('Clear metrics');
this.clientMetricsStoreV2.clearMetrics(48); this.clientMetricsStoreV2.clearMetrics(48);
}, ONE_DAY); }, ONE_DAY);
this.timer.unref(); this.timer.unref();
this.bulkTimer = setInterval(async () => {
await this.saveMetrics();
}, bulkInterval);
this.bulkTimer.unref();
} }
async registerClientMetrics( async registerClientMetrics(
@ -58,8 +63,22 @@ export default class ClientMetricsServiceV2 {
})) }))
.filter((item) => !(item.yes === 0 && item.no === 0)); .filter((item) => !(item.yes === 0 && item.no === 0));
// TODO: should we aggregate for a few minutes (bulkInterval) before pushing to DB? this.unsavedMetics = this.unsavedMetics.concat(clientMetrics);
await this.clientMetricsStoreV2.batchInsertMetrics(clientMetrics); }
async saveMetrics(): Promise<void> {
if (this.unsavedMetics.length === 0) {
return;
}
const metrics = this.unsavedMetics;
this.unsavedMetics = [];
try {
this.logger.debug('storing metrics');
await this.clientMetricsStoreV2.batchInsertMetrics(metrics);
} catch (error: any) {
this.logger.error(error);
this.unsavedMetics = this.unsavedMetics.concat(metrics);
}
} }
// Overview over usage last "hour" bucket and all applications using the toggle // Overview over usage last "hour" bucket and all applications using the toggle
@ -107,5 +126,7 @@ export default class ClientMetricsServiceV2 {
destroy(): void { destroy(): void {
clearInterval(this.timer); clearInterval(this.timer);
this.timer = null; this.timer = null;
clearInterval(this.bulkTimer);
this.bulkTimer = null;
} }
} }