Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-05-03 01:18:43 +02:00
Code Issues Projects Releases Wiki Activity

fix: exclude favorites from the client api (#3276)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2023-03-08 14:56:51 +01:00 committed by GitHub
parent 9422dce9d5
commit 352ace1e6e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/db/feature-toggle-client-store.ts
View File

@ -198,7 +198,6 @@ export default class FeatureToggleClientStore
feature.impressionData = r.impression_data; feature.impressionData = r.impression_data;
feature.enabled = !!r.enabled; feature.enabled = !!r.enabled;
feature.name = r.name; feature.name = r.name;
feature.favorite = r.favorite;
feature.description = r.description; feature.description = r.description;
feature.project = r.project; feature.project = r.project;
feature.stale = r.stale; feature.stale = r.stale;
@ -206,6 +205,7 @@ export default class FeatureToggleClientStore
feature.variants = r.variants || []; feature.variants = r.variants || [];
feature.project = r.project; feature.project = r.project;
if (isAdmin) { if (isAdmin) {
feature.favorite = r.favorite;
feature.lastSeenAt = r.last_seen_at; feature.lastSeenAt = r.last_seen_at;
feature.createdAt = r.created_at; feature.createdAt = r.created_at;
} }

13
src/test/e2e/api/client/feature.e2e.test.ts
View File

@ -1,4 +1,7 @@
import { IUnleashTest, setupApp } from '../../helpers/test-helper'; import {
IUnleashTest,
setupAppWithCustomConfig,
} from '../../helpers/test-helper';
import dbInit, { ITestDb } from '../../helpers/database-init'; import dbInit, { ITestDb } from '../../helpers/database-init';
import getLogger from '../../../fixtures/no-logger'; import getLogger from '../../../fixtures/no-logger';
import { DEFAULT_ENV } from '../../../../lib/util/constants'; import { DEFAULT_ENV } from '../../../../lib/util/constants';
@ -8,7 +11,13 @@ let db: ITestDb;
beforeAll(async () => { beforeAll(async () => {
db = await dbInit('feature_api_client', getLogger); db = await dbInit('feature_api_client', getLogger);
app = await setupApp(db.stores); app = await setupAppWithCustomConfig(db.stores, {
experimental: {
flags: {
strictSchemaValidation: true,
},
},
});
await app.services.featureToggleServiceV2.createFeatureToggle( await app.services.featureToggleServiceV2.createFeatureToggle(
'default', 'default',
{ {