Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

refactor: fix a few eslint module boundary type overrides (#1542)

Browse Source
This commit is contained in:
olav 2022-04-28 12:40:38 +02:00 committed by GitHub
parent 3e40cb935e
commit 36922d156d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 12 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/routes/admin-api/archive.ts
View File

@ -50,7 +50,6 @@ export default class ArchiveController extends Controller {
);
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async getArchivedFeatures(
req: Request,
res: Response<FeaturesSchema>,
@ -71,7 +70,6 @@ export default class ArchiveController extends Controller {
res.status(200).end();
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async reviveFeatureToggle(req: IAuthRequest, res: Response): Promise<void> {
const userName = extractUsername(req);
const { featureName } = req.params;

7
src/lib/routes/admin-api/email.ts
View File

@ -2,6 +2,7 @@ import { ADMIN } from '../../types/permissions';
import { TemplateFormat } from '../../services/email-service';
import { IUnleashConfig } from '../../types/option';
import { IUnleashServices } from '../../types/services';
import { Request, Response } from 'express';
const Controller = require('../controller');
@ -17,8 +18,7 @@ export default class EmailController extends Controller {
this.get('/preview/text/:template', this.getTextPreview, ADMIN);
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async getHtmlPreview(req, res): Promise<void> {
async getHtmlPreview(req: Request, res: Response): Promise<void> {
const { template } = req.params;
const ctx = req.query;
const data = await this.emailService.compileTemplate(
@ -32,8 +32,7 @@ export default class EmailController extends Controller {
res.end();
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async getTextPreview(req, res) {
async getTextPreview(req: Request, res: Response): Promise<void> {
const { template } = req.params;
const ctx = req.query;
const data = await this.emailService.compileTemplate(

23
src/lib/routes/admin-api/strategy.ts
View File

@ -12,6 +12,8 @@ import {
CREATE_STRATEGY,
UPDATE_STRATEGY,
} from '../../types/permissions';
import { Request, Response } from 'express';
import { IAuthRequest } from '../unleash-types';
const version = 1;
@ -45,8 +47,7 @@ class StrategyController extends Controller {
);
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async getAllStrategies(req, res): Promise<void> {
async getAllStrategies(req: Request, res: Response): Promise<void> {
try {
const strategies = await this.strategyService.getStrategies();
res.json({ version, strategies });
@ -55,8 +56,7 @@ class StrategyController extends Controller {
}
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async getStrategy(req, res): Promise<void> {
async getStrategy(req: Request, res: Response): Promise<void> {
try {
const { name } = req.params;
const strategy = await this.strategyService.getStrategy(name);
@ -66,8 +66,7 @@ class StrategyController extends Controller {
}
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async removeStrategy(req, res): Promise<void> {
async removeStrategy(req: IAuthRequest, res: Response): Promise<void> {
const strategyName = req.params.name;
const userName = extractUsername(req);
@ -79,8 +78,7 @@ class StrategyController extends Controller {
}
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async createStrategy(req, res): Promise<void> {
async createStrategy(req: IAuthRequest, res: Response): Promise<void> {
const userName = extractUsername(req);
try {
await this.strategyService.createStrategy(req.body, userName);
@ -90,8 +88,7 @@ class StrategyController extends Controller {
}
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async updateStrategy(req, res): Promise<void> {
async updateStrategy(req: IAuthRequest, res: Response): Promise<void> {
const userName = extractUsername(req);
try {
await this.strategyService.updateStrategy(req.body, userName);
@ -101,8 +98,7 @@ class StrategyController extends Controller {
}
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async deprecateStrategy(req, res): Promise<void> {
async deprecateStrategy(req: IAuthRequest, res: Response): Promise<void> {
const userName = extractUsername(req);
const { strategyName } = req.params;
if (strategyName === 'default') {
@ -120,8 +116,7 @@ class StrategyController extends Controller {
}
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async reactivateStrategy(req, res): Promise<void> {
async reactivateStrategy(req: IAuthRequest, res: Response): Promise<void> {
const userName = extractUsername(req);
const { strategyName } = req.params;
try {

2
src/lib/server-impl.ts
View File

@ -118,7 +118,6 @@ async function createApp(
});
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async function start(opts: IUnleashOptions = {}): Promise<IUnleash> {
const config = createConfig(opts);
const logger = config.getLogger('server-impl.js');
@ -143,7 +142,6 @@ async function start(opts: IUnleashOptions = {}): Promise<IUnleash> {
return unleash;
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async function create(opts: IUnleashOptions): Promise<IUnleash> {
const config = createConfig(opts);
const logger = config.getLogger('server-impl.js');

1
src/lib/services/state-service.ts
View File

@ -646,7 +646,6 @@ export default class StateService {
);
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async export({
includeFeatureToggles = true,
includeStrategies = true,