From 37533e334ba6143bab23374e9519ffe014e80a1b Mon Sep 17 00:00:00 2001 From: Thomas Heartman Date: Fri, 29 Aug 2025 10:45:49 +0200 Subject: [PATCH] fix: Show `100%` instead of `Infinity%` if you've not created any flags JS gives you positive infinity if you divide a positive number by 0, which isn't very helpful here. Instead, let's show 100%. --- .../CreationArchiveChart/CreationArchiveRatioTooltip.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx b/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx index d88783627c..54e7a240b3 100644 --- a/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx +++ b/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx @@ -49,7 +49,11 @@ export const CreationArchiveRatioTooltip: FC< const rawData = tooltip.dataPoints[0].raw as WeekData; const archivedCount = rawData.archivedFlags || 0; const createdCount = rawData.totalCreatedFlags || 0; - const ratio = Math.round((archivedCount / createdCount) * 100); + + const ratio = Math.min( + Math.round((archivedCount / createdCount) * 100), + 100, + ); return (