Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-28 00:17:12 +01:00
Code Issues Projects Releases Wiki Activity

chore: fix smaller broken UI things in release templates (#9084)

Browse Source
This commit is contained in:
David Leek 2025-01-13 13:02:06 +01:00 committed by GitHub
parent b0b2836c67
commit 3759b5a75d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/component/releases/ReleasePlanTemplate/EditReleasePlanTemplate.tsx
View File

@ -29,7 +29,7 @@ export const EditReleasePlanTemplate = () => {
const templateId = useRequiredPathParam('templateId'); const templateId = useRequiredPathParam('templateId');
const { template, loading, error, refetch } = const { template, loading, error, refetch } =
useReleasePlanTemplate(templateId); useReleasePlanTemplate(templateId);
usePageTitle(`Edit template: ${template.name}`); usePageTitle(`Edit release template`);
const navigate = useNavigate(); const navigate = useNavigate();
const { setToastApiError, setToastData } = useToast(); const { setToastApiError, setToastData } = useToast();
const { updateReleasePlanTemplate } = useReleasePlanTemplatesApi(); const { updateReleasePlanTemplate } = useReleasePlanTemplatesApi();
@ -96,7 +96,7 @@ export const EditReleasePlanTemplate = () => {
setMilestones={setMilestones} setMilestones={setMilestones}
errors={errors} errors={errors}
clearErrors={clearErrors} clearErrors={clearErrors}
formTitle={`Edit template ${template.name}`} formTitle={`Edit release template`}
formatApiCode={formatApiCode} formatApiCode={formatApiCode}
handleSubmit={handleSubmit} handleSubmit={handleSubmit}
loading={loading} loading={loading}

4
frontend/src/component/releases/ReleasePlanTemplate/TemplateForm/MilestoneList/MilestoneCard/MilestoneCard.tsx
View File

@ -256,7 +256,7 @@ export const MilestoneCard = ({
> >
<StyledMilestoneCardBody> <StyledMilestoneCardBody>
<Grid container> <Grid container>
<StyledGridItem item xs={8} md={9}> <StyledGridItem item xs={6} md={6}>
<MilestoneCardName <MilestoneCardName
milestone={milestone} milestone={milestone}
errors={errors} errors={errors}
@ -264,7 +264,7 @@ export const MilestoneCard = ({
milestoneNameChanged={milestoneNameChanged} milestoneNameChanged={milestoneNameChanged}
/> />
</StyledGridItem> </StyledGridItem>
<StyledMilestoneActionGrid item xs={4} md={3}> <StyledMilestoneActionGrid item xs={6} md={6}>
<Button <Button
variant='outlined' variant='outlined'
color='primary' color='primary'

13
frontend/src/component/releases/ReleasePlanTemplate/TemplateForm/MilestoneStrategy/ReleasePlanTemplateAddStrategyForm.tsx
View File

@ -25,6 +25,11 @@ import { MilestoneStrategyTitle } from './MilestoneStrategyTitle';
import { MilestoneStrategyConstraints } from './MilestoneStrategyConstraints'; import { MilestoneStrategyConstraints } from './MilestoneStrategyConstraints';
import { MilestoneStrategyVariants } from './MilestoneStrategyVariants'; import { MilestoneStrategyVariants } from './MilestoneStrategyVariants';
import { MilestoneStrategyType } from './MilestoneStrategyType'; import { MilestoneStrategyType } from './MilestoneStrategyType';
import {
featureStrategyDocsLink,
featureStrategyDocsLinkLabel,
featureStrategyHelp,
} from 'component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit';
const StyledCancelButton = styled(Button)(({ theme }) => ({ const StyledCancelButton = styled(Button)(({ theme }) => ({
marginLeft: theme.spacing(3), marginLeft: theme.spacing(3),
@ -236,7 +241,9 @@ export const ReleasePlanTemplateAddStrategyForm = ({
return ( return (
<FormTemplate <FormTemplate
modal modal
description='Add a strategy to your release plan template.' description={featureStrategyHelp}
documentationLink={featureStrategyDocsLink}
documentationLinkLabel={featureStrategyDocsLinkLabel}
> >
<StyledHeaderBox> <StyledHeaderBox>
<StyledTitle> <StyledTitle>
@ -316,6 +323,8 @@ export const ReleasePlanTemplateAddStrategyForm = ({
<StyledTargetingHeader> <StyledTargetingHeader>
Segmentation and constraints allow you to set Segmentation and constraints allow you to set
filters on your strategies, so that they will only filters on your strategies, so that they will only
be evaluated for users and applications that match
the specified preconditions.
<MilestoneStrategySegment <MilestoneStrategySegment
segments={segments} segments={segments}
setSegments={setSegments} setSegments={setSegments}
@ -328,8 +337,6 @@ export const ReleasePlanTemplateAddStrategyForm = ({
strategy={currentStrategy} strategy={currentStrategy}
setStrategy={setCurrentStrategy} setStrategy={setCurrentStrategy}
/> />
be evaluated for users and applications that match
the specified preconditions.
</StyledTargetingHeader> </StyledTargetingHeader>
</> </>
)} )}