Prettier/lint

.eslintrc

@@ -1,12 +1,22 @@
 {
     "extends": [
         "finn",
-        "finn/node"
+        "finn/node",
+        "finn-prettier"
     ],
     "parserOptions": {
         "ecmaVersion": "2017"
     },
     "rules": {
-        "max-nested-callbacks": "off"
+        "max-nested-callbacks": "off",
+        "new-cap": [
+            "error",
+            {
+                "capIsNewExceptions": [
+                    "Router",
+                    "Mitm"
+                ]
+            }
+        ]
     }
 }

lib/app.js

@@ -34,10 +34,17 @@ module.exports = function (config) {
         app.use(favicon(path.join(publicFolder, 'favicon.ico')));
     }
 
-    app.use(responseTime((req, res, time) => {
+    app.use(
-        const timingInfo = { path: req.path, method: req.method, statusCode: res.statusCode, time };
+        responseTime((req, res, time) => {
+            const timingInfo = {
+                path: req.path,
+                method: req.method,
+                statusCode: res.statusCode,
+                time,
+            };
             config.eventBus.emit(REQUEST_TIME, timingInfo);
-    }));
+        })
+    );
 
     app.use(validator([]));
 
@@ -48,10 +55,12 @@ module.exports = function (config) {
     app.use(bodyParser.json({ strict: false }));
 
     if (config.enableRequestLogger) {
-        app.use(log4js.connectLogger(logger, {
+        app.use(
+            log4js.connectLogger(logger, {
                 format: ':status :method :url :response-timems',
                 level: 'auto', // 3XX=WARN, 4xx/5xx=ERROR
-        }));
+            })
+        );
     }
 
     if (typeof config.preRouterHook === 'function') {

lib/app.test.js

@@ -16,16 +16,20 @@ test('should not throw when valid config', t => {
 
 test('should call preHook', t => {
     let called = 0;
-    getApp({ preHook: () => {
+    getApp({
+        preHook: () => {
             called++;
-    } });
+        },
+    });
     t.true(called === 1);
 });
 
 test('should call preRouterHook', t => {
     let called = 0;
-    getApp({ preRouterHook: () => {
+    getApp({
+        preRouterHook: () => {
             called++;
-    } });
+        },
+    });
     t.true(called === 1);
 });

lib/client-metrics/client-metrics.test.js

@@ -10,7 +10,7 @@ const { EventEmitter } = require('events');
 const appName = 'appName';
 const instanceId = 'instanceId';
 
-test('should work without state', (t) => {
+test('should work without state', t => {
     const store = new EventEmitter();
     const metrics = new UnleashClientMetrics(store);
 
@@ -20,7 +20,7 @@ test('should work without state', (t) => {
     metrics.destroy();
 });
 
-test.cb('data should expire', (t) => {
+test.cb('data should expire', t => {
     const clock = sinon.useFakeTimers();
 
     const store = new EventEmitter();
@@ -84,9 +84,14 @@ test('should listen to metrics from store', t => {
     t.truthy(metrics.apps[appName].count === 123);
     t.truthy(metrics.globalCount === 123);
 
-    t.deepEqual(metrics.getTogglesMetrics().lastHour.toggleX, { yes: 123, no: 0 });
+    t.deepEqual(metrics.getTogglesMetrics().lastHour.toggleX, {
-    t.deepEqual(metrics.getTogglesMetrics().lastMinute.toggleX, { yes: 123, no: 0 });
+        yes: 123,
-
+        no: 0,
+    });
+    t.deepEqual(metrics.getTogglesMetrics().lastMinute.toggleX, {
+        yes: 123,
+        no: 0,
+    });
 
     metrics.addPayload({
         appName,
@@ -104,8 +109,14 @@ test('should listen to metrics from store', t => {
     });
 
     t.truthy(metrics.globalCount === 143);
-    t.deepEqual(metrics.getTogglesMetrics().lastHour.toggleX, { yes: 133, no: 10 });
+    t.deepEqual(metrics.getTogglesMetrics().lastHour.toggleX, {
-    t.deepEqual(metrics.getTogglesMetrics().lastMinute.toggleX, { yes: 133, no: 10 });
+        yes: 133,
+        no: 10,
+    });
+    t.deepEqual(metrics.getTogglesMetrics().lastMinute.toggleX, {
+        yes: 133,
+        no: 10,
+    });
 
     metrics.destroy();
 });
@@ -146,7 +157,6 @@ test('should build up list of seend toggles when new metrics arrives', t => {
     metrics.destroy();
 });
 
-
 test('should handle a lot of toggles', t => {
     const store = new EventEmitter();
     const metrics = new UnleashClientMetrics(store);
@@ -244,7 +254,6 @@ test('should have correct values for lastMinute', t => {
     clock.restore();
 });
 
-
 test('should have correct values for lastHour', t => {
     const clock = sinon.useFakeTimers();
 

lib/client-metrics/index.js

@@ -21,17 +21,23 @@ module.exports = class UnleashClientMetrics {
             expireAmount: 1,
         });
 
-        this.lastHourList.on('expire', (toggles) => {
+        this.lastHourList.on('expire', toggles => {
             Object.keys(toggles).forEach(toggleName => {
-                this.lastHourProjection.substract(toggleName, toggles[toggleName]);
+                this.lastHourProjection.substract(
+                    toggleName,
+                    toggles[toggleName]
+                );
             });
         });
-        this.lastMinuteList.on('expire', (toggles) => {
+        this.lastMinuteList.on('expire', toggles => {
             Object.keys(toggles).forEach(toggleName => {
-                this.lastMinuteProjection.substract(toggleName, toggles[toggleName]);
+                this.lastMinuteProjection.substract(
+                    toggleName,
+                    toggles[toggleName]
+                );
             });
         });
-        clientMetricsStore.on('metrics', (m) => this.addPayload(m));
+        clientMetricsStore.on('metrics', m => this.addPayload(m));
     }
 
     getAppsWithToggles() {
@@ -44,13 +50,17 @@ module.exports = class UnleashClientMetrics {
         return apps;
     }
     getSeenTogglesByAppName(appName) {
-        return this.apps[appName] ? Object.keys(this.apps[appName].seenToggles) : [];
+        return this.apps[appName]
+            ? Object.keys(this.apps[appName].seenToggles)
+            : [];
     }
 
     getSeenAppsPerToggle() {
         const toggles = {};
         Object.keys(this.apps).forEach(appName => {
-            Object.keys(this.apps[appName].seenToggles).forEach((seenToggleName) => {
+            Object.keys(
+                this.apps[appName].seenToggles
+            ).forEach(seenToggleName => {
                 if (!toggles[seenToggleName]) {
                     toggles[seenToggleName] = [];
                 }
@@ -74,7 +84,10 @@ module.exports = class UnleashClientMetrics {
     }
 
     getApp(appName) {
-        this.apps[appName] = this.apps[appName] || { seenToggles: {}, count: 0 };
+        this.apps[appName] = this.apps[appName] || {
+            seenToggles: {},
+            count: 0,
+        };
         return this.apps[appName];
     }
 
@@ -85,11 +98,11 @@ module.exports = class UnleashClientMetrics {
 
         const toggleNames = Object.keys(toggles);
 
-        toggleNames.forEach((n) => {
+        toggleNames.forEach(n => {
             const entry = toggles[n];
             this.lastHourProjection.add(n, entry);
             this.lastMinuteProjection.add(n, entry);
-            count += (entry.yes + entry.no);
+            count += entry.yes + entry.no;
         });
 
         this.lastHourList.add(toggles, stop);

lib/client-metrics/list.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const test = require('ava');
+const { test } = require('ava');
 const List = require('./list');
 
 function getList() {
@@ -15,10 +15,10 @@ function getList () {
     return list;
 }
 
-test('should emit "evicted" events for objects leaving list', (t) => {
+test('should emit "evicted" events for objects leaving list', t => {
     const list = getList();
     const evictedList = [];
-    list.on('evicted', (value) => {
+    list.on('evicted', value => {
         evictedList.push(value);
     });
 
@@ -43,7 +43,7 @@ test('should emit "evicted" events for objects leaving list', (t) => {
     t.true(evictedList.length === 8);
 });
 
-test('list should be able remove until given value', (t) => {
+test('list should be able remove until given value', t => {
     const list = getList();
 
     t.true(list.toArray().length === 7);
@@ -58,7 +58,7 @@ test('list should be able remove until given value', (t) => {
     t.true(list.toArray().length === 3);
 });
 
-test('list can be cleared and re-add entries', (t) => {
+test('list can be cleared and re-add entries', t => {
     const list = getList();
 
     list.add(8);
@@ -77,7 +77,7 @@ test('list can be cleared and re-add entries', (t) => {
     t.true(list.toArray().length === 3);
 });
 
-test('should not iterate empty list ', (t) => {
+test('should not iterate empty list ', t => {
     const list = new List();
 
     let iterateCount = 0;
@@ -87,8 +87,7 @@ test('should not iterate empty list ', (t) => {
     t.true(iterateCount === 0);
 });
 
-
+test('should iterate', t => {
-test('should iterate', (t) => {
     const list = getList();
 
     let iterateCount = 0;
@@ -102,7 +101,7 @@ test('should iterate', (t) => {
     t.true(iterateCount === 4);
 });
 
-test('should reverse iterate', (t) => {
+test('should reverse iterate', t => {
     const list = getList();
 
     let iterateCount = 0;
@@ -116,7 +115,7 @@ test('should reverse iterate', (t) => {
     t.true(iterateCount === 5);
 });
 
-test('should not reverse iterate empty list', (t) => {
+test('should not reverse iterate empty list', t => {
     const list = new List();
 
     let iterateCount = 0;

lib/client-metrics/ttl-list.js

@@ -6,11 +6,9 @@ const moment = require('moment');
 
 // this list must have entries with sorted ttl range
 module.exports = class TTLList extends EventEmitter {
-    constructor ({
+    constructor(
-        interval = 1000,
+        { interval = 1000, expireAmount = 1, expireType = 'hours' } = {}
-        expireAmount = 1,
+    ) {
-        expireType = 'hours',
-    } = {}) {
         super();
         this.interval = interval;
         this.expireAmount = expireAmount;
@@ -46,7 +44,9 @@ module.exports = class TTLList extends EventEmitter {
 
     timedCheck() {
         const now = moment();
-        this.list.reverseRemoveUntilTrue(({ value }) => now.isBefore(value.ttl));
+        this.list.reverseRemoveUntilTrue(({ value }) =>
+            now.isBefore(value.ttl)
+        );
         this.startTimer();
     }
 

lib/client-metrics/ttl-list.test.js

@@ -1,18 +1,18 @@
 'use strict';
 
-const test = require('ava');
+const { test } = require('ava');
 const TTLList = require('./ttl-list');
 const moment = require('moment');
 const sinon = require('sinon');
 
-test.cb('should emit expire', (t) => {
+test.cb('should emit expire', t => {
     const list = new TTLList({
         interval: 20,
         expireAmount: 10,
         expireType: 'milliseconds',
     });
 
-    list.on('expire', (entry) => {
+    list.on('expire', entry => {
         list.destroy();
         t.true(entry.n === 1);
         t.end();
@@ -21,7 +21,7 @@ test.cb('should emit expire', (t) => {
     list.add({ n: 1 });
 });
 
-test.cb('should slice off list', (t) => {
+test.cb('should slice off list', t => {
     const clock = sinon.useFakeTimers();
 
     const list = new TTLList({
@@ -30,7 +30,6 @@ test.cb('should slice off list', (t) => {
         expireType: 'milliseconds',
     });
 
-
     list.add({ n: '1' }, moment().add(1, 'milliseconds'));
     list.add({ n: '2' }, moment().add(50, 'milliseconds'));
     list.add({ n: '3' }, moment().add(200, 'milliseconds'));
@@ -38,7 +37,7 @@ test.cb('should slice off list', (t) => {
 
     const expired = [];
 
-    list.on('expire', (entry) => {
+    list.on('expire', entry => {
         // console.timeEnd(entry.n);
         expired.push(entry);
     });

lib/db/client-applications-store.js

@@ -1,10 +1,19 @@
 /* eslint camelcase:off */
 'use strict';
 
-const COLUMNS = ['app_name', 'created_at', 'updated_at', 'description', 'strategies', 'url', 'color', 'icon'];
+const COLUMNS = [
+    'app_name',
+    'created_at',
+    'updated_at',
+    'description',
+    'strategies',
+    'url',
+    'color',
+    'icon',
+];
 const TABLE = 'client_applications';
 
-const mapRow = (row) => ({
+const mapRow = row => ({
     appName: row.app_name,
     createdAt: row.created_at,
     updatedAt: row.updated_at,
@@ -25,7 +34,6 @@ const remapRow = (input, old = {}) => ({
     strategies: JSON.stringify(input.strategies || old.strategies),
 });
 
-
 class ClientApplicationsDb {
     constructor(db) {
         this.db = db;
@@ -59,10 +67,7 @@ class ClientApplicationsDb {
     }
 
     getAll() {
-        return this.db
+        return this.db.select(COLUMNS).from(TABLE).map(mapRow);
-            .select(COLUMNS)
-            .from(TABLE)
-            .map(mapRow);
     }
 
     getApplication(appName) {
@@ -88,14 +93,16 @@ class ClientApplicationsDb {
             .select(COLUMNS)
             .from(TABLE)
             .map(mapRow)
-            .then(apps => apps
+            .then(apps =>
-                .filter(app => app.strategies.includes(strategyName)));
+                apps.filter(app => app.strategies.includes(strategyName))
+            );
     }
 
     getApplications(filter) {
-        return filter && filter.strategyName ?
+        return filter && filter.strategyName
-            this.getAppsForStrategy(filter.strategyName) : this.getAll();
+            ? this.getAppsForStrategy(filter.strategyName)
+            : this.getAll();
+    }
 }
-};
 
 module.exports = ClientApplicationsDb;

lib/db/client-instance-store.js

@@ -2,10 +2,16 @@
 'use strict';
 
 const logger = require('../logger');
-const COLUMNS = ['app_name', 'instance_id', 'client_ip', 'last_seen', 'created_at'];
+const COLUMNS = [
+    'app_name',
+    'instance_id',
+    'client_ip',
+    'last_seen',
+    'created_at',
+];
 const TABLE = 'client_instances';
 
-const mapRow = (row) => ({
+const mapRow = row => ({
     appName: row.app_name,
     instanceId: row.instance_id,
     clientIp: row.client_ip,
@@ -19,18 +25,20 @@ const mapRow = (row) => ({
 // });
 
 class ClientInstanceStore {
-
     constructor(db) {
         this.db = db;
         setTimeout(() => this._removeInstancesOlderThanTwoDays(), 10).unref();
-        setInterval(() => this._removeInstancesOlderThanTwoDays(), 24 * 61 * 60 * 1000).unref();
+        setInterval(
+            () => this._removeInstancesOlderThanTwoDays(),
+            24 * 61 * 60 * 1000
+        ).unref();
     }
 
     _removeInstancesOlderThanTwoDays() {
         this.db(TABLE)
-            .whereRaw('created_at < now() - interval \'2 days\'')
+            .whereRaw("created_at < now() - interval '2 days'")
             .del()
-            .then((res) => res > 0 && logger.info(`Deleted ${res} instances`));
+            .then(res => res > 0 && logger.info(`Deleted ${res} instances`));
     }
 
     updateRow(details) {
@@ -91,6 +99,6 @@ class ClientInstanceStore {
             .orderBy('app_name', 'desc')
             .map(mapRow);
     }
-};
+}
 
 module.exports = ClientInstanceStore;

lib/db/client-metrics-db.js

@@ -5,7 +5,7 @@ const logger = require('../logger');
 const METRICS_COLUMNS = ['id', 'created_at', 'metrics'];
 const TABLE = 'client_metrics';
 
-const mapRow = (row) => ({
+const mapRow = row => ({
     id: row.id,
     createdAt: row.created_at,
     metrics: row.metrics,
@@ -17,14 +17,17 @@ class ClientMetricsDb {
 
         // Clear old metrics regulary
         setTimeout(() => this.removeMetricsOlderThanOneHour(), 10).unref();
-        setInterval(() => this.removeMetricsOlderThanOneHour(), 60 * 1000).unref();
+        setInterval(
+            () => this.removeMetricsOlderThanOneHour(),
+            60 * 1000
+        ).unref();
     }
 
     removeMetricsOlderThanOneHour() {
         this.db(TABLE)
-            .whereRaw('created_at < now() - interval \'1 hour\'')
+            .whereRaw("created_at < now() - interval '1 hour'")
             .del()
-            .then((res) => res > 0 && logger.info(`Deleted ${res} metrics`));
+            .then(res => res > 0 && logger.info(`Deleted ${res} metrics`));
     }
 
     // Insert new client metrics
@@ -38,7 +41,7 @@ class ClientMetricsDb {
             .select(METRICS_COLUMNS)
             .from(TABLE)
             .limit(2000)
-            .whereRaw('created_at > now() - interval \'1 hour\'')
+            .whereRaw("created_at > now() - interval '1 hour'")
             .orderBy('created_at', 'asc')
             .map(mapRow);
     }
@@ -53,6 +56,6 @@ class ClientMetricsDb {
             .orderBy('created_at', 'asc')
             .map(mapRow);
     }
-};
+}
 
 module.exports = ClientMetricsDb;

lib/db/client-metrics-store.js

@@ -7,18 +7,18 @@ const { EventEmitter } = require('events');
 const TEN_SECONDS = 10 * 1000;
 
 class ClientMetricsStore extends EventEmitter {
-
     constructor(metricsDb, pollInterval = TEN_SECONDS) {
         super();
         this.metricsDb = metricsDb;
         this.highestIdSeen = 0;
 
         // Build internal state
-        metricsDb.getMetricsLastHour()
+        metricsDb
-            .then((metrics) => this._emitMetrics(metrics))
+            .getMetricsLastHour()
+            .then(metrics => this._emitMetrics(metrics))
             .then(() => this._startPoller(pollInterval))
             .then(() => this.emit('ready'))
-            .catch((err) => logger.error(err));
+            .catch(err => logger.error(err));
     }
 
     _startPoller(pollInterval) {
@@ -27,8 +27,9 @@ class ClientMetricsStore extends EventEmitter {
     }
 
     _fetchNewAndEmit() {
-        this.metricsDb.getNewMetrics(this.highestIdSeen)
+        this.metricsDb
-            .then((metrics) => this._emitMetrics(metrics));
+            .getNewMetrics(this.highestIdSeen)
+            .then(metrics => this._emitMetrics(metrics));
     }
 
     _emitMetrics(metrics) {
@@ -48,6 +49,6 @@ class ClientMetricsStore extends EventEmitter {
             clearInterval(this.timer);
         } catch (e) {}
     }
-};
+}
 
 module.exports = ClientMetricsStore;

lib/db/client-metrics-store.test.js

@@ -21,16 +21,14 @@ function getMockDb () {
     };
 }
 
-
+test.cb('should call database on startup', t => {
-test.cb('should call database on startup', (t) => {
     const mock = getMockDb();
 
     const store = new ClientMetricStore(mock);
 
     t.plan(2);
 
-
+    store.on('metrics', metrics => {
-    store.on('metrics', (metrics) => {
         t.true(store.highestIdSeen === 1);
         t.true(metrics.appName === 'test');
         store.destroy();
@@ -39,15 +37,14 @@ test.cb('should call database on startup', (t) => {
     });
 });
 
-
+test.cb('should poll for updates', t => {
-test.cb('should poll for updates', (t) => {
     const clock = sinon.useFakeTimers();
 
     const mock = getMockDb();
     const store = new ClientMetricStore(mock, 100);
 
     const metrics = [];
-    store.on('metrics', (m) => metrics.push(m));
+    store.on('metrics', m => metrics.push(m));
 
     t.true(metrics.length === 0);
 
@@ -63,4 +60,3 @@ test.cb('should poll for updates', (t) => {
         });
     });
 });
-

lib/db/db-pool.js

@@ -2,7 +2,12 @@
 
 const knex = require('knex');
 
-module.exports.createDb = function ({ databaseUrl, poolMin = 2, poolMax = 20, databaseSchema = 'public' }) {
+module.exports.createDb = function({
+    databaseUrl,
+    poolMin = 2,
+    poolMax = 20,
+    databaseSchema = 'public',
+}) {
     const db = knex({
         client: 'pg',
         connection: databaseUrl,

lib/db/event-store.js

@@ -5,14 +5,14 @@ const { EventEmitter } = require('events');
 const EVENT_COLUMNS = ['id', 'type', 'created_by', 'created_at', 'data'];
 
 class EventStore extends EventEmitter {
-
     constructor(db) {
         super();
         this.db = db;
     }
 
     store(event) {
-        return this.db('events').insert({
+        return this.db('events')
+            .insert({
                 type: event.type,
             created_by: event.createdBy, // eslint-disable-line
                 data: event.data,
@@ -34,7 +34,7 @@ class EventStore extends EventEmitter {
             .select(EVENT_COLUMNS)
             .from('events')
             .limit(100)
-        .whereRaw('data ->> \'name\' = ?', [name])
+            .whereRaw("data ->> 'name' = ?", [name])
             .orderBy('created_at', 'desc')
             .map(this.rowToEvent);
     }
@@ -48,7 +48,6 @@ class EventStore extends EventEmitter {
             data: row.data,
         };
     }
-};
+}
 
 module.exports = EventStore;
-

lib/db/feature-toggle-store.js

@@ -1,18 +1,37 @@
 'use strict';
 
-const { FEATURE_CREATED, FEATURE_UPDATED, FEATURE_ARCHIVED, FEATURE_REVIVED } = require('../event-type');
+const {
+    FEATURE_CREATED,
+    FEATURE_UPDATED,
+    FEATURE_ARCHIVED,
+    FEATURE_REVIVED,
+} = require('../event-type');
 const logger = require('../logger');
 const NotFoundError = require('../error/notfound-error');
-const FEATURE_COLUMNS = ['name', 'description', 'enabled', 'strategies', 'created_at'];
+const FEATURE_COLUMNS = [
+    'name',
+    'description',
+    'enabled',
+    'strategies',
+    'created_at',
+];
 const TABLE = 'features';
 
 class FeatureToggleStore {
     constructor(db, eventStore) {
         this.db = db;
-        eventStore.on(FEATURE_CREATED, event => this._createFeature(event.data));
+        eventStore.on(FEATURE_CREATED, event =>
-        eventStore.on(FEATURE_UPDATED, event => this._updateFeature(event.data));
+            this._createFeature(event.data)
-        eventStore.on(FEATURE_ARCHIVED, event => this._archiveFeature(event.data));
+        );
-        eventStore.on(FEATURE_REVIVED, event => this._reviveFeature(event.data));
+        eventStore.on(FEATURE_UPDATED, event =>
+            this._updateFeature(event.data)
+        );
+        eventStore.on(FEATURE_ARCHIVED, event =>
+            this._archiveFeature(event.data)
+        );
+        eventStore.on(FEATURE_REVIVED, event =>
+            this._reviveFeature(event.data)
+        );
     }
 
     getFeatures() {
@@ -67,29 +86,37 @@ class FeatureToggleStore {
     _createFeature(data) {
         return this.db(TABLE)
             .insert(this.eventDataToRow(data))
-            .catch(err => logger.error('Could not insert feature, error was: ', err));
+            .catch(err =>
+                logger.error('Could not insert feature, error was: ', err)
+            );
     }
 
     _updateFeature(data) {
         return this.db(TABLE)
             .where({ name: data.name })
             .update(this.eventDataToRow(data))
-            .catch(err => logger.error('Could not update feature, error was: ', err));
+            .catch(err =>
+                logger.error('Could not update feature, error was: ', err)
+            );
     }
 
     _archiveFeature({ name }) {
         return this.db(TABLE)
             .where({ name })
             .update({ archived: 1 })
-            .catch(err => logger.error('Could not archive feature, error was: ', err));
+            .catch(err =>
+                logger.error('Could not archive feature, error was: ', err)
+            );
     }
 
     _reviveFeature({ name }) {
         return this.db(TABLE)
             .where({ name })
             .update({ archived: 0, enabled: 0 })
-            .catch(err => logger.error('Could not archive feature, error was: ', err));
+            .catch(err =>
+                logger.error('Could not archive feature, error was: ', err)
+            );
+    }
 }
-};
 
 module.exports = FeatureToggleStore;

lib/db/index.js

@@ -9,7 +9,7 @@ const ClientMetricsDb = require('./client-metrics-db');
 const ClientMetricsStore = require('./client-metrics-store');
 const ClientApplicationsStore = require('./client-applications-store');
 
-module.exports.createStores = (config) => {
+module.exports.createStores = config => {
     const db = createDb(config);
     const eventStore = new EventStore(db);
     const clientMetricsDb = new ClientMetricsDb(db);

lib/db/strategy-store.js

@@ -1,6 +1,10 @@
 'use strict';
 
-const { STRATEGY_CREATED, STRATEGY_DELETED, STRATEGY_UPDATED } = require('../event-type');
+const {
+    STRATEGY_CREATED,
+    STRATEGY_DELETED,
+    STRATEGY_UPDATED,
+} = require('../event-type');
 const logger = require('../logger');
 const NotFoundError = require('../error/notfound-error');
 const STRATEGY_COLUMNS = ['name', 'description', 'parameters'];
@@ -9,13 +13,14 @@ const TABLE = 'strategies';
 class StrategyStore {
     constructor(db, eventStore) {
         this.db = db;
-        eventStore.on(STRATEGY_CREATED, event => this._createStrategy(event.data));
+        eventStore.on(STRATEGY_CREATED, event =>
-        eventStore.on(STRATEGY_UPDATED, event => this._updateStrategy(event.data));
+            this._createStrategy(event.data)
+        );
+        eventStore.on(STRATEGY_UPDATED, event =>
+            this._updateStrategy(event.data)
+        );
         eventStore.on(STRATEGY_DELETED, event => {
-            db(TABLE)
+            db(TABLE).where('name', event.data.name).del().catch(err => {
-                .where('name', event.data.name)
-                .del()
-                .catch(err => {
                 logger.error('Could not delete strategy, error was: ', err);
             });
         });
@@ -60,16 +65,19 @@ class StrategyStore {
     _createStrategy(data) {
         this.db(TABLE)
             .insert(this.eventDataToRow(data))
-            .catch(err => logger.error('Could not insert strategy, error was: ', err));
+            .catch(err =>
+                logger.error('Could not insert strategy, error was: ', err)
+            );
     }
 
     _updateStrategy(data) {
         this.db(TABLE)
             .where({ name: data.name })
             .update(this.eventDataToRow(data))
-            .catch(err => logger.error('Could not update strategy, error was: ', err));
+            .catch(err =>
+                logger.error('Could not update strategy, error was: ', err)
+            );
+    }
 }
-};
 
 module.exports = StrategyStore;
-

lib/event-differ.js

@@ -11,11 +11,7 @@ const {
 } = require('./event-type');
 const diff = require('deep-diff').diff;
 
-const strategyTypes = [
+const strategyTypes = [STRATEGY_CREATED, STRATEGY_DELETED, STRATEGY_UPDATED];
-    STRATEGY_CREATED,
-    STRATEGY_DELETED,
-    STRATEGY_UPDATED,
-];
 
 const featureTypes = [
     FEATURE_CREATED,
@@ -40,7 +36,8 @@ function groupByBaseTypeAndName (events) {
         const baseType = baseTypeFor(event);
 
         groups[baseType] = groups[baseType] || {};
-        groups[baseType][event.data.name] = groups[baseType][event.data.name] || [];
+        groups[baseType][event.data.name] =
+            groups[baseType][event.data.name] || [];
 
         groups[baseType][event.data.name].push(event);
     });
@@ -81,7 +78,6 @@ function addDiffs (events) {
     });
 }
 
-
 module.exports = {
     addDiffs,
 };

lib/event-differ.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const test = require('ava');
+const { test } = require('ava');
 const eventDiffer = require('./event-differ');
 const { FEATURE_CREATED, FEATURE_UPDATED } = require('./event-type');
 const logger = require('./logger');
@@ -27,11 +27,23 @@ test('diffs a feature-update event', t => {
     const events = [
         {
             type: FEATURE_UPDATED,
-            data: { name: feature, description: desc, strategy: 'default', enabled: true, parameters: { value: 2 } },
+            data: {
+                name: feature,
+                description: desc,
+                strategy: 'default',
+                enabled: true,
+                parameters: { value: 2 },
+            },
         },
         {
             type: FEATURE_CREATED,
-            data: { name: feature, description: desc, strategy: 'default', enabled: false, parameters: { value: 1 } },
+            data: {
+                name: feature,
+                description: desc,
+                strategy: 'default',
+                enabled: false,
+                parameters: { value: 1 },
+            },
         },
     ];
 
@@ -57,19 +69,43 @@ test('diffs only against features with the same name', t => {
     const events = [
         {
             type: FEATURE_UPDATED,
-            data: { name: 'bar', description: 'desc', strategy: 'default', enabled: true, parameters: {} },
+            data: {
+                name: 'bar',
+                description: 'desc',
+                strategy: 'default',
+                enabled: true,
+                parameters: {},
+            },
         },
         {
             type: FEATURE_UPDATED,
-            data: { name: 'foo', description: 'desc', strategy: 'default', enabled: false, parameters: {} },
+            data: {
+                name: 'foo',
+                description: 'desc',
+                strategy: 'default',
+                enabled: false,
+                parameters: {},
+            },
         },
         {
             type: FEATURE_CREATED,
-            data: { name: 'bar', description: 'desc', strategy: 'default', enabled: false, parameters: {} },
+            data: {
+                name: 'bar',
+                description: 'desc',
+                strategy: 'default',
+                enabled: false,
+                parameters: {},
+            },
         },
         {
             type: FEATURE_CREATED,
-            data: { name: 'foo', description: 'desc', strategy: 'default', enabled: true, parameters: {} },
+            data: {
+                name: 'foo',
+                description: 'desc',
+                strategy: 'default',
+                enabled: true,
+                parameters: {},
+            },
         },
     ];
 
@@ -85,11 +121,23 @@ test('sets an empty array of diffs if nothing was changed', t => {
     const events = [
         {
             type: FEATURE_UPDATED,
-            data: { name: 'foo', description: 'desc', strategy: 'default', enabled: true, parameters: {} },
+            data: {
+                name: 'foo',
+                description: 'desc',
+                strategy: 'default',
+                enabled: true,
+                parameters: {},
+            },
         },
         {
             type: FEATURE_CREATED,
-            data: { name: 'foo', description: 'desc', strategy: 'default', enabled: true, parameters: {} },
+            data: {
+                name: 'foo',
+                description: 'desc',
+                strategy: 'default',
+                enabled: true,
+                parameters: {},
+            },
         },
     ];
 
@@ -101,11 +149,16 @@ test('sets diffs to null if there was nothing to diff against', t => {
     const events = [
         {
             type: FEATURE_UPDATED,
-            data: { name: 'foo', description: 'desc', strategy: 'default', enabled: true, parameters: {} },
+            data: {
+                name: 'foo',
+                description: 'desc',
+                strategy: 'default',
+                enabled: true,
+                parameters: {},
+            },
         },
     ];
 
     eventDiffer.addDiffs(events);
     t.true(events[0].diffs === null);
 });
-

lib/logger.js

@@ -2,9 +2,7 @@
 
 const log4js = require('log4js');
 log4js.configure({
-    appenders: [
+    appenders: [{ type: 'console' }],
-    { type: 'console' },
-    ],
 });
 
 const logger = log4js.getLogger('unleash');

lib/metrics.js

@@ -9,9 +9,14 @@ exports.startMonitoring = (enable, eventBus) => {
 
     const client = require('prom-client');
 
-    const requestDuration = new client.Summary('http_request_duration_milliseconds', 'App response time', ['path', 'method', 'status'], {
+    const requestDuration = new client.Summary(
+        'http_request_duration_milliseconds',
+        'App response time',
+        ['path', 'method', 'status'],
+        {
             percentiles: [0.1, 0.5, 0.9, 0.99],
-    });
+        }
+    );
 
     eventBus.on(events.REQUEST_TIME, ({ path, method, time, statusCode }) => {
         requestDuration.labels(path, method, statusCode).observe(time);

lib/metrics.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const test = require('ava');
+const { test } = require('ava');
 const { EventEmitter } = require('events');
 const eventBus = new EventEmitter();
 const { REQUEST_TIME } = require('./events');
@@ -9,8 +9,16 @@ const prometheusRegister = require('prom-client/lib/register');
 
 test('should collect metrics for requests', t => {
     startMonitoring(true, eventBus);
-    eventBus.emit(REQUEST_TIME, { path: 'somePath', method: 'GET', statusCode: 200, time: 1337 });
+    eventBus.emit(REQUEST_TIME, {
+        path: 'somePath',
+        method: 'GET',
+        statusCode: 200,
+        time: 1337,
+    });
 
     const metrics = prometheusRegister.metrics();
-    t.regex(metrics, /http_request_duration_milliseconds{quantile="0.99",status="200",method="GET",path="somePath"} 1337/);
+    t.regex(
+        metrics,
+        /http_request_duration_milliseconds{quantile="0.99",status="200",method="GET",path="somePath"} 1337/
+    );
 });

lib/options.js

@@ -14,16 +14,19 @@ const DEFAULT_OPTIONS = {
 };
 
 module.exports = {
-    createOptions: (opts) => {
+    createOptions: opts => {
         const options = Object.assign({}, DEFAULT_OPTIONS, opts);
 
         // If we are running in development we should assume local db
         if (isDev() && !options.databaseUrl) {
-            options.databaseUrl = 'postgres://unleash_user:passord@localhost:5432/unleash';
+            options.databaseUrl =
+                'postgres://unleash_user:passord@localhost:5432/unleash';
         }
 
         if (!options.databaseUrl) {
-            throw new Error('You must either pass databaseUrl option or set environemnt variable DATABASE_URL');
+            throw new Error(
+                'You must either pass databaseUrl option or set environemnt variable DATABASE_URL'
+            );
         }
         return options;
     },

lib/options.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const test = require('ava');
+const { test } = require('ava');
 
 delete process.env.DATABASE_URL;
 
@@ -18,7 +18,10 @@ test('should set default databaseUrl for develpment', t => {
 
     const options = createOptions({});
 
-    t.true(options.databaseUrl === 'postgres://unleash_user:passord@localhost:5432/unleash');
+    t.true(
+        options.databaseUrl ===
+            'postgres://unleash_user:passord@localhost:5432/unleash'
+    );
 });
 
 test('should not override provided options', t => {

lib/server-impl.js

@@ -15,10 +15,13 @@ function createApp (options) {
     const stores = createStores(options);
     const eventBus = new EventEmitter();
 
-    const config = Object.assign({
+    const config = Object.assign(
+        {
             stores,
             eventBus,
-    }, options);
+        },
+        options
+    );
 
     const app = getApp(config);
     const server = app.listen(app.get('port'), () => {

lib/server-impl.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const test = require('ava');
+const { test } = require('ava');
 const proxyquire = require('proxyquire');
 
 const getApp = proxyquire('./app', {