Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-10 17:53:36 +02:00
Code Issues Projects Releases Wiki Activity

openapi: automate 404s

Browse Source
This commit is contained in:
Thomas Heartman 2023-08-17 08:38:58 +02:00
parent 2761f243ed
commit 3836732e2c
No known key found for this signature in database
GPG Key ID: BD1F880DAED1EE78
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/routes/admin-api/addon.ts
View File

@ -18,10 +18,7 @@ import { OpenApiService } from '../../services/openapi-service';
import { AddonSchema, addonSchema } from '../../openapi/spec/addon-schema'; import { AddonSchema, addonSchema } from '../../openapi/spec/addon-schema';
import { serializeDates } from '../../types/serialize-dates'; import { serializeDates } from '../../types/serialize-dates';
import { AddonsSchema, addonsSchema } from '../../openapi/spec/addons-schema'; import { AddonsSchema, addonsSchema } from '../../openapi/spec/addons-schema';
import { import { emptyResponse } from '../../openapi/util/standard-responses';
emptyResponse,
getStandardResponses,
} from '../../openapi/util/standard-responses';
import { AddonCreateUpdateSchema } from 'lib/openapi/spec/addon-create-update-schema'; import { AddonCreateUpdateSchema } from 'lib/openapi/spec/addon-create-update-schema';
type AddonServices = Pick<IUnleashServices, 'addonService' | 'openApiService'>; type AddonServices = Pick<IUnleashServices, 'addonService' | 'openApiService'>;
@ -56,7 +53,6 @@ class AddonController extends Controller {
tags: ['Addons'], tags: ['Addons'],
operationId: 'getAddons', operationId: 'getAddons',
responses: { responses: {
...getStandardResponses(401),
200: createResponseSchema('addonsSchema'), 200: createResponseSchema('addonsSchema'),
}, },
}, },
@ -112,7 +108,6 @@ Note: passing \`null\` as a value for the description property will set it to an
requestBody: createRequestSchema('addonCreateUpdateSchema'), requestBody: createRequestSchema('addonCreateUpdateSchema'),
responses: { responses: {
200: createResponseSchema('addonSchema'), 200: createResponseSchema('addonSchema'),
...getStandardResponses(404),
}, },
}, },
}); });
@ -131,7 +126,6 @@ Note: passing \`null\` as a value for the description property will set it to an
operationId: 'deleteAddon', operationId: 'deleteAddon',
responses: { responses: {
200: emptyResponse, 200: emptyResponse,
...getStandardResponses(404),
}, },
}, },
}); });

4
src/lib/routes/controller.ts
View File

@ -129,6 +129,10 @@ export default class Controller {
errorCodes.add(415); errorCodes.add(415);
} }
if (options.path.includes(':')) {
errorCodes.add(404);
}
if (options.permission !== NONE) { if (options.permission !== NONE) {
errorCodes.add(403); errorCodes.add(403);
} }