Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-04-19 01:17:18 +02:00
Code Issues Projects Releases Wiki Activity

feat: remove bulk operations flag (#3643)

Browse Source
This commit is contained in:
Jaanus Sellin 2023-04-28 11:18:03 +03:00 committed by GitHub
parent 108eee91f1
commit 383aa3dde4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
13 changed files with 25 additions and 73 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
frontend/src/component/archive/ArchiveTable/ArchiveTable.tsx
View File

@ -95,24 +95,18 @@ export const ArchiveTable = ({
const columns = useMemo( const columns = useMemo(
() => [ () => [
...(uiConfig?.flags?.bulkOperations {
? [ id: 'Select',
{ Header: ({ getToggleAllRowsSelectedProps }: any) => (
id: 'Select', <Checkbox {...getToggleAllRowsSelectedProps()} />
Header: ({ getToggleAllRowsSelectedProps }: any) => ( ),
<Checkbox {...getToggleAllRowsSelectedProps()} /> Cell: ({ row }: any) => (
), <RowSelectCell {...row?.getToggleRowSelectedProps?.()} />
Cell: ({ row }: any) => ( ),
<RowSelectCell maxWidth: 50,
{...row?.getToggleRowSelectedProps?.()} disableSortBy: true,
/> hideInMenu: true,
), },
maxWidth: 50,
disableSortBy: true,
hideInMenu: true,
},
]
: []),
{ {
Header: 'Seen', Header: 'Seen',
width: 85, width: 85,

7
frontend/src/component/archive/ArchiveTable/ArchivedFeatureActionCell/ArchivedFeatureDeleteConfirm/ArchivedFeatureDeleteConfirm.tsx
View File

@ -43,12 +43,7 @@ export const ArchivedFeatureDeleteConfirm = ({
if (deletedFeatures.length === 0) { if (deletedFeatures.length === 0) {
return; return;
} }
await deleteFeatures(projectId, deletedFeatures);
if (uiConfig?.flags?.bulkOperations) {
await deleteFeatures(projectId, deletedFeatures);
} else {
await deleteFeature(deletedFeatures[0]);
}
await refetch(); await refetch();
setToastData({ setToastData({

30
frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeatureToggles.tsx
View File

@ -240,24 +240,18 @@ export const ProjectFeatureToggles = ({
const columns = useMemo( const columns = useMemo(
() => [ () => [
...(uiConfig?.flags?.bulkOperations {
? [ id: 'Select',
{ Header: ({ getToggleAllRowsSelectedProps }: any) => (
id: 'Select', <Checkbox {...getToggleAllRowsSelectedProps()} />
Header: ({ getToggleAllRowsSelectedProps }: any) => ( ),
<Checkbox {...getToggleAllRowsSelectedProps()} /> Cell: ({ row }: any) => (
), <RowSelectCell {...row?.getToggleRowSelectedProps?.()} />
Cell: ({ row }: any) => ( ),
<RowSelectCell maxWidth: 50,
{...row?.getToggleRowSelectedProps?.()} disableSortBy: true,
/> hideInMenu: true,
), },
maxWidth: 50,
disableSortBy: true,
hideInMenu: true,
},
]
: []),
{ {
id: 'favorite', id: 'favorite',
Header: ( Header: (

1
frontend/src/interfaces/uiConfig.ts
View File

@ -45,7 +45,6 @@ export interface IFlags {
crOnVariants?: boolean; crOnVariants?: boolean;
proPlanAutoCharge?: boolean; proPlanAutoCharge?: boolean;
notifications?: boolean; notifications?: boolean;
bulkOperations?: boolean;
personalAccessTokensKillSwitch?: boolean; personalAccessTokensKillSwitch?: boolean;
demo?: boolean; demo?: boolean;
strategyTitle?: boolean; strategyTitle?: boolean;

2
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -67,7 +67,6 @@ exports[`should create default config 1`] = `
}, },
"flags": { "flags": {
"anonymiseEventLog": false, "anonymiseEventLog": false,
"bulkOperations": false,
"caseInsensitiveInOperators": false, "caseInsensitiveInOperators": false,
"cleanClientApi": false, "cleanClientApi": false,
"crOnVariants": false, "crOnVariants": false,
@ -94,7 +93,6 @@ exports[`should create default config 1`] = `
"flagResolver": FlagResolver { "flagResolver": FlagResolver {
"experiments": { "experiments": {
"anonymiseEventLog": false, "anonymiseEventLog": false,
"bulkOperations": false,
"caseInsensitiveInOperators": false, "caseInsensitiveInOperators": false,
"cleanClientApi": false, "cleanClientApi": false,
"crOnVariants": false, "crOnVariants": false,

11
src/lib/routes/admin-api/project/project-archive.ts
View File

@ -14,7 +14,6 @@ import { IAuthRequest } from '../../unleash-types';
import { OpenApiService } from '../../../services/openapi-service'; import { OpenApiService } from '../../../services/openapi-service';
import { emptyResponse } from '../../../openapi/util/standard-responses'; import { emptyResponse } from '../../../openapi/util/standard-responses';
import { BatchFeaturesSchema, createRequestSchema } from '../../../openapi'; import { BatchFeaturesSchema, createRequestSchema } from '../../../openapi';
import NotFoundError from '../../../error/notfound-error';
import Controller from '../../controller'; import Controller from '../../controller';
const PATH = '/:projectId'; const PATH = '/:projectId';
@ -105,9 +104,6 @@ export default class ProjectArchiveController extends Controller {
req: IAuthRequest<IProjectParam, any, BatchFeaturesSchema>, req: IAuthRequest<IProjectParam, any, BatchFeaturesSchema>,
res: Response<void>, res: Response<void>,
): Promise<void> { ): Promise<void> {
if (!this.flagResolver.isEnabled('bulkOperations')) {
throw new NotFoundError('Bulk operations are not enabled');
}
const { projectId } = req.params; const { projectId } = req.params;
const { features } = req.body; const { features } = req.body;
const user = extractUsername(req); const user = extractUsername(req);
@ -119,9 +115,6 @@ export default class ProjectArchiveController extends Controller {
req: IAuthRequest<IProjectParam, any, BatchFeaturesSchema>, req: IAuthRequest<IProjectParam, any, BatchFeaturesSchema>,
res: Response<void>, res: Response<void>,
): Promise<void> { ): Promise<void> {
if (!this.flagResolver.isEnabled('bulkOperations')) {
throw new NotFoundError('Bulk operations are not enabled');
}
const { projectId } = req.params; const { projectId } = req.params;
const { features } = req.body; const { features } = req.body;
const user = extractUsername(req); const user = extractUsername(req);
@ -133,10 +126,6 @@ export default class ProjectArchiveController extends Controller {
req: IAuthRequest<IProjectParam, void, BatchFeaturesSchema>, req: IAuthRequest<IProjectParam, void, BatchFeaturesSchema>,
res: Response, res: Response,
): Promise<void> { ): Promise<void> {
if (!this.flagResolver.isEnabled('bulkOperations')) {
throw new NotFoundError('Bulk operations are not enabled');
}
const { features } = req.body; const { features } = req.body;
const { projectId } = req.params; const { projectId } = req.params;
const userName = extractUsername(req); const userName = extractUsername(req);

5
src/lib/routes/admin-api/project/project-features.ts
View File

@ -40,7 +40,6 @@ import {
} from '../../../openapi'; } from '../../../openapi';
import { OpenApiService, FeatureToggleService } from '../../../services'; import { OpenApiService, FeatureToggleService } from '../../../services';
import { querySchema } from '../../../schema/feature-schema'; import { querySchema } from '../../../schema/feature-schema';
import NotFoundError from '../../../error/notfound-error';
import { BatchStaleSchema } from '../../../openapi/spec/batch-stale-schema'; import { BatchStaleSchema } from '../../../openapi/spec/batch-stale-schema';
interface FeatureStrategyParams { interface FeatureStrategyParams {
@ -594,10 +593,6 @@ export default class ProjectFeaturesController extends Controller {
req: IAuthRequest<{ projectId: string }, void, BatchStaleSchema>, req: IAuthRequest<{ projectId: string }, void, BatchStaleSchema>,
res: Response, res: Response,
): Promise<void> { ): Promise<void> {
if (!this.flagResolver.isEnabled('bulkOperations')) {
throw new NotFoundError('Bulk operations are not enabled');
}
const { features, stale } = req.body; const { features, stale } = req.body;
const { projectId } = req.params; const { projectId } = req.params;
const userName = extractUsername(req); const userName = extractUsername(req);

4
src/lib/routes/admin-api/tag.ts
View File

@ -24,7 +24,6 @@ import {
import { emptyResponse } from '../../openapi/util/standard-responses'; import { emptyResponse } from '../../openapi/util/standard-responses';
import FeatureTagService from 'lib/services/feature-tag-service'; import FeatureTagService from 'lib/services/feature-tag-service';
import { TagsBulkAddSchema } from '../../openapi/spec/tags-bulk-add-schema'; import { TagsBulkAddSchema } from '../../openapi/spec/tags-bulk-add-schema';
import NotFoundError from '../../error/notfound-error';
import { IFlagResolver } from '../../types'; import { IFlagResolver } from '../../types';
const version = 1; const version = 1;
@ -214,9 +213,6 @@ class TagController extends Controller {
req: IAuthRequest<void, void, TagsBulkAddSchema>, req: IAuthRequest<void, void, TagsBulkAddSchema>,
res: Response<TagSchema>, res: Response<TagSchema>,
): Promise<void> { ): Promise<void> {
if (!this.flagResolver.isEnabled('bulkOperations')) {
throw new NotFoundError('Bulk operations are not enabled');
}
const { features, tags } = req.body; const { features, tags } = req.body;
const userName = extractUsername(req); const userName = extractUsername(req);
await this.featureTagService.updateTags( await this.featureTagService.updateTags(

4
src/lib/types/experimental.ts
View File

@ -49,10 +49,6 @@ const flags = {
process.env.UNLEASH_PRO_PLAN_AUTO_CHARGE, process.env.UNLEASH_PRO_PLAN_AUTO_CHARGE,
false, false,
), ),
bulkOperations: parseEnvVarBoolean(
process.env.UNLEASH_BULK_OPERATIONS,
false,
),
personalAccessTokensKillSwitch: parseEnvVarBoolean( personalAccessTokensKillSwitch: parseEnvVarBoolean(
process.env.UNLEASH_PAT_KILL_SWITCH, process.env.UNLEASH_PAT_KILL_SWITCH,
false, false,

1
src/server-dev.ts
View File

@ -39,7 +39,6 @@ process.nextTick(async () => {
anonymiseEventLog: false, anonymiseEventLog: false,
responseTimeWithAppNameKillSwitch: false, responseTimeWithAppNameKillSwitch: false,
newProjectOverview: true, newProjectOverview: true,
bulkOperations: true,
optimal304: true, optimal304: true,
optimal304Differ: false, optimal304Differ: false,
}, },

1
src/test/e2e/api/admin/feature-archive.e2e.test.ts
View File

@ -15,7 +15,6 @@ beforeAll(async () => {
experimental: { experimental: {
flags: { flags: {
strictSchemaValidation: true, strictSchemaValidation: true,
bulkOperations: true,
}, },
}, },
}); });

1
src/test/e2e/api/admin/project/features.e2e.test.ts
View File

@ -89,7 +89,6 @@ beforeAll(async () => {
experimental: { experimental: {
flags: { flags: {
strictSchemaValidation: true, strictSchemaValidation: true,
bulkOperations: true,
}, },
}, },
}, },

1
src/test/e2e/api/admin/tags.e2e.test.ts
View File

@ -11,7 +11,6 @@ beforeAll(async () => {
experimental: { experimental: {
flags: { flags: {
strictSchemaValidation: true, strictSchemaValidation: true,
bulkOperations: true,
}, },
}, },
}); });