Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-14 01:16:17 +02:00
Code Issues Projects Releases Wiki Activity

fix: register metrics middleware before pre-hook (#866)

Browse Source
This commit is contained in:
Ivar Conradi Østhus 2021-06-07 10:34:32 +02:00 committed by GitHub
parent e8598ee7bf
commit 3858b29d80
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/lib/app.ts
View File

@ -46,6 +46,12 @@ export default function getApp(
app.set('port', config.server.port); app.set('port', config.server.port);
app.locals.baseUriPath = baseUriPath; app.locals.baseUriPath = baseUriPath;
if (config.server.serverMetrics && eventBus) {
app.use(responseTimeMetrics(eventBus));
}
app.use(requestLogger(config));
if (typeof config.preHook === 'function') { if (typeof config.preHook === 'function') {
config.preHook(app, config, services); config.preHook(app, config, services);
} }
@ -58,10 +64,6 @@ export default function getApp(
app.use(cookieParser()); app.use(cookieParser());
app.use(express.json({ strict: false })); app.use(express.json({ strict: false }));
app.use(unleashDbSession(config, stores)); app.use(unleashDbSession(config, stores));
if (config.server.serverMetrics && eventBus) {
app.use(responseTimeMetrics(eventBus));
}
app.use(requestLogger(config));
app.use(secureHeaders(config)); app.use(secureHeaders(config));
app.use(express.urlencoded({ extended: true })); app.use(express.urlencoded({ extended: true }));
app.use(favicon(path.join(publicFolder, 'favicon.ico'))); app.use(favicon(path.join(publicFolder, 'favicon.ico')));

4
src/lib/metrics.ts
View File

@ -44,13 +44,13 @@ export default class MetricsMonitor {
name: 'http_request_duration_milliseconds', name: 'http_request_duration_milliseconds',
help: 'App response time', help: 'App response time',
labelNames: ['path', 'method', 'status'], labelNames: ['path', 'method', 'status'],
percentiles: [0.1, 0.5, 0.9, 0.99], percentiles: [0.1, 0.5, 0.9, 0.95, 0.99],
}); });
const dbDuration = new client.Summary({ const dbDuration = new client.Summary({
name: 'db_query_duration_seconds', name: 'db_query_duration_seconds',
help: 'DB query duration time', help: 'DB query duration time',
labelNames: ['store', 'action'], labelNames: ['store', 'action'],
percentiles: [0.1, 0.5, 0.9, 0.99], percentiles: [0.1, 0.5, 0.9, 0.95, 0.99],
}); });
const featureToggleUpdateTotal = new client.Counter({ const featureToggleUpdateTotal = new client.Counter({
name: 'feature_toggle_update_total', name: 'feature_toggle_update_total',