Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

fix: archived flags without metrics do not count towards onboarding (#8443)

Browse Source
This commit is contained in:
Jaanus Sellin 2024-10-14 14:09:57 +03:00 committed by GitHub
parent 735e6f0b23
commit 39fb1b5db5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/lib/features/onboarding/onboarding-read-model.ts
View File

@ -92,15 +92,6 @@ export class OnboardingReadModel implements IOnboardingReadModel {
return null; return null;
} }
const feature = await this.db('features')
.select('name')
.where('project', projectId)
.first();
if (!feature) {
return { status: 'onboarding-started' };
}
const db = this.db; const db = this.db;
const lastSeen = await db const lastSeen = await db
.select(db.raw('1')) .select(db.raw('1'))
@ -117,8 +108,17 @@ export class OnboardingReadModel implements IOnboardingReadModel {
if (lastSeen) { if (lastSeen) {
return { status: 'onboarded' }; return { status: 'onboarded' };
} else {
return { status: 'first-flag-created', feature: feature.name };
} }
const feature = await this.db('features')
.select('name')
.where('project', projectId)
.where('archived_at', null)
.first();
if (!feature) {
return { status: 'onboarding-started' };
}
return { status: 'first-flag-created', feature: feature.name };
} }
} }