Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-05 17:53:12 +02:00
Code Issues Projects Releases Wiki Activity

better use of types

Browse Source
This commit is contained in:
andreas-unleash 2022-11-07 14:39:53 +02:00
parent 065833e5d1
commit 3a9d03d394
1 changed files with 50 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
frontend/src/hooks/useChangeRequestAddStrategy.ts
View File

@ -3,7 +3,6 @@ import useToast from 'hooks/useToast';
import { formatUnknownError } from 'utils/formatUnknownError';
import {
IFeatureStrategy,
IFeatureStrategyPayload,
} from '../interfaces/strategy';
import { useChangeRequestApi } from './api/actions/useChangeRequestApi/useChangeRequestApi';
import { useChangeRequestOpen } from './api/getters/useChangeRequestOpen/useChangeRequestOpen';
@ -26,7 +25,6 @@ export const useChangeRequestAddStrategy = (
useState<{
strategy?: IFeatureStrategy;
strategies?: IFeatureStrategy[];
featureName?: string;
environment?: string;
fromEnvironment?: string;
isOpen: boolean;
@ -39,7 +37,6 @@ export const useChangeRequestAddStrategy = (
fromEnvironment?: string
) => {
setChangeRequestDialogDetails({
featureName,
environment,
fromEnvironment,
strategy,
@ -56,7 +53,6 @@ export const useChangeRequestAddStrategy = (
fromEnvironment: string
) => {
setChangeRequestDialogDetails({
featureName,
environment,
fromEnvironment,
strategies,
@ -71,53 +67,61 @@ export const useChangeRequestAddStrategy = (
}, []);
const onChangeRequestAddStrategyConfirm = useCallback(async () => {
try {
await addChangeRequest(
project,
changeRequestDialogDetails.environment!,
{
feature: changeRequestDialogDetails.featureName!,
action: action,
payload: changeRequestDialogDetails.strategy!,
}
);
refetch();
setChangeRequestDialogDetails({ isOpen: false });
setToastData({
type: 'success',
title: 'Changes added to the draft!',
});
} catch (error) {
setToastApiError(formatUnknownError(error));
setChangeRequestDialogDetails({ isOpen: false });
const { environment, strategy } = changeRequestDialogDetails;
if (environment && featureName && strategy) {
try {
await addChangeRequest(
project,
environment,
{
feature: featureName,
action: action,
payload: strategy,
}
);
refetch();
setChangeRequestDialogDetails({ isOpen: false });
setToastData({
type: 'success',
title: 'Changes added to the draft!',
});
} catch (error) {
setToastApiError(formatUnknownError(error));
setChangeRequestDialogDetails({ isOpen: false });
}
}
//eslint-disable-next-line
}, [addChangeRequest]);
const onChangeRequestAddStrategiesConfirm = useCallback(async () => {
try {
await Promise.all(
changeRequestDialogDetails.strategies!.map(strategy => {
return addChangeRequest(
project,
changeRequestDialogDetails.environment!,
{
feature: changeRequestDialogDetails.featureName!,
action: action,
payload: strategy,
}
);
})
);
refetch();
setChangeRequestDialogDetails({ isOpen: false });
setToastData({
type: 'success',
title: 'Changes added to the draft!',
});
} catch (error) {
setToastApiError(formatUnknownError(error));
setChangeRequestDialogDetails({ isOpen: false });
const { environment, strategies } = changeRequestDialogDetails;
if (environment && featureName && strategies) {
try {
await Promise.all(
changeRequestDialogDetails.strategies!.map(strategy => {
return addChangeRequest(
project,
environment,
{
feature: featureName,
action: action,
payload: strategy,
}
);
})
);
refetch();
setChangeRequestDialogDetails({ isOpen: false });
setToastData({
type: 'success',
title: 'Changes added to the draft!',
});
} catch (error) {
setToastApiError(formatUnknownError(error));
setChangeRequestDialogDetails({ isOpen: false });
}
}
//eslint-disable-next-line
}, [addChangeRequest]);
return {