Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-05 17:53:12 +02:00
Code Issues Projects Releases Wiki Activity

better use of types

Browse Source
This commit is contained in:
andreas-unleash 2022-11-07 14:39:53 +02:00
parent 065833e5d1
commit 3a9d03d394
1 changed files with 50 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
frontend/src/hooks/useChangeRequestAddStrategy.ts
View File

@ -3,7 +3,6 @@ import useToast from 'hooks/useToast';
import { formatUnknownError } from 'utils/formatUnknownError'; import { formatUnknownError } from 'utils/formatUnknownError';
import { import {
IFeatureStrategy, IFeatureStrategy,
IFeatureStrategyPayload,
} from '../interfaces/strategy'; } from '../interfaces/strategy';
import { useChangeRequestApi } from './api/actions/useChangeRequestApi/useChangeRequestApi'; import { useChangeRequestApi } from './api/actions/useChangeRequestApi/useChangeRequestApi';
import { useChangeRequestOpen } from './api/getters/useChangeRequestOpen/useChangeRequestOpen'; import { useChangeRequestOpen } from './api/getters/useChangeRequestOpen/useChangeRequestOpen';
@ -26,7 +25,6 @@ export const useChangeRequestAddStrategy = (
useState<{ useState<{
strategy?: IFeatureStrategy; strategy?: IFeatureStrategy;
strategies?: IFeatureStrategy[]; strategies?: IFeatureStrategy[];
featureName?: string;
environment?: string; environment?: string;
fromEnvironment?: string; fromEnvironment?: string;
isOpen: boolean; isOpen: boolean;
@ -39,7 +37,6 @@ export const useChangeRequestAddStrategy = (
fromEnvironment?: string fromEnvironment?: string
) => { ) => {
setChangeRequestDialogDetails({ setChangeRequestDialogDetails({
featureName,
environment, environment,
fromEnvironment, fromEnvironment,
strategy, strategy,
@ -56,7 +53,6 @@ export const useChangeRequestAddStrategy = (
fromEnvironment: string fromEnvironment: string
) => { ) => {
setChangeRequestDialogDetails({ setChangeRequestDialogDetails({
featureName,
environment, environment,
fromEnvironment, fromEnvironment,
strategies, strategies,
@ -71,53 +67,61 @@ export const useChangeRequestAddStrategy = (
}, []); }, []);
const onChangeRequestAddStrategyConfirm = useCallback(async () => { const onChangeRequestAddStrategyConfirm = useCallback(async () => {
try { const { environment, strategy } = changeRequestDialogDetails;
await addChangeRequest( if (environment && featureName && strategy) {
project, try {
changeRequestDialogDetails.environment!, await addChangeRequest(
{ project,
feature: changeRequestDialogDetails.featureName!, environment,
action: action, {
payload: changeRequestDialogDetails.strategy!, feature: featureName,
} action: action,
); payload: strategy,
refetch(); }
setChangeRequestDialogDetails({ isOpen: false }); );
setToastData({ refetch();
type: 'success', setChangeRequestDialogDetails({ isOpen: false });
title: 'Changes added to the draft!', setToastData({
}); type: 'success',
} catch (error) { title: 'Changes added to the draft!',
setToastApiError(formatUnknownError(error)); });
setChangeRequestDialogDetails({ isOpen: false }); } catch (error) {
setToastApiError(formatUnknownError(error));
setChangeRequestDialogDetails({ isOpen: false });
}
} }
//eslint-disable-next-line
}, [addChangeRequest]); }, [addChangeRequest]);
const onChangeRequestAddStrategiesConfirm = useCallback(async () => { const onChangeRequestAddStrategiesConfirm = useCallback(async () => {
try { const { environment, strategies } = changeRequestDialogDetails;
await Promise.all( if (environment && featureName && strategies) {
changeRequestDialogDetails.strategies!.map(strategy => { try {
return addChangeRequest( await Promise.all(
project, changeRequestDialogDetails.strategies!.map(strategy => {
changeRequestDialogDetails.environment!, return addChangeRequest(
{ project,
feature: changeRequestDialogDetails.featureName!, environment,
action: action, {
payload: strategy, feature: featureName,
} action: action,
); payload: strategy,
}) }
); );
refetch(); })
setChangeRequestDialogDetails({ isOpen: false }); );
setToastData({ refetch();
type: 'success', setChangeRequestDialogDetails({ isOpen: false });
title: 'Changes added to the draft!', setToastData({
}); type: 'success',
} catch (error) { title: 'Changes added to the draft!',
setToastApiError(formatUnknownError(error)); });
setChangeRequestDialogDetails({ isOpen: false }); } catch (error) {
setToastApiError(formatUnknownError(error));
setChangeRequestDialogDetails({ isOpen: false });
}
} }
//eslint-disable-next-line
}, [addChangeRequest]); }, [addChangeRequest]);
return { return {