Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

feat: flag impact metrics use update feature permission (#10615)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2025-09-04 09:58:45 +02:00 committed by GitHub
parent 2fd40e7372
commit 3b1592b329
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureImpactMetrics.tsx
View File

@ -10,7 +10,7 @@ import { useRequiredPathParam } from 'hooks/useRequiredPathParam.ts';
import { useFeatureImpactMetrics } from 'hooks/api/getters/useFeatureImpactMetrics/useFeatureImpactMetrics.ts'; import { useFeatureImpactMetrics } from 'hooks/api/getters/useFeatureImpactMetrics/useFeatureImpactMetrics.ts';
import { ChartItem } from '../../../impact-metrics/ChartItem.tsx'; import { ChartItem } from '../../../impact-metrics/ChartItem.tsx';
import PermissionButton from 'component/common/PermissionButton/PermissionButton.tsx'; import PermissionButton from 'component/common/PermissionButton/PermissionButton.tsx';
import { ADMIN } from 'component/providers/AccessProvider/permissions.ts'; import { UPDATE_FEATURE } from 'component/providers/AccessProvider/permissions.ts';
import useToast from 'hooks/useToast.tsx'; import useToast from 'hooks/useToast.tsx';
import { formatUnknownError } from 'utils/formatUnknownError.ts'; import { formatUnknownError } from 'utils/formatUnknownError.ts';
import type { ChartConfig } from '../../../impact-metrics/types.ts'; import type { ChartConfig } from '../../../impact-metrics/types.ts';
@ -28,6 +28,7 @@ type ModalState =
export const FeatureImpactMetrics: FC = () => { export const FeatureImpactMetrics: FC = () => {
const feature = useRequiredPathParam('featureId'); const feature = useRequiredPathParam('featureId');
const project = useRequiredPathParam('projectId');
const [modalState, setModalState] = useState<ModalState>({ const [modalState, setModalState] = useState<ModalState>({
type: 'closed', type: 'closed',
@ -109,7 +110,8 @@ export const FeatureImpactMetrics: FC = () => {
startIcon={<Add />} startIcon={<Add />}
onClick={handleAddChart} onClick={handleAddChart}
disabled={metadataLoading || !!metadataError} disabled={metadataLoading || !!metadataError}
permission={ADMIN} permission={UPDATE_FEATURE}
projectId={project}
> >
Add Chart Add Chart
</PermissionButton> </PermissionButton>
@ -123,6 +125,8 @@ export const FeatureImpactMetrics: FC = () => {
config={config} config={config}
onEdit={() => handleEditChart(config)} onEdit={() => handleEditChart(config)}
onDelete={() => handleDeleteChart(config.id)} onDelete={() => handleDeleteChart(config.id)}
permission={UPDATE_FEATURE}
projectId={project}
/> />
))} ))}
</> </>

16
frontend/src/component/impact-metrics/ChartItem.tsx
View File

@ -12,6 +12,8 @@ export interface ChartItemProps {
config: DisplayChartConfig; config: DisplayChartConfig;
onEdit: (config: ChartConfig) => void; onEdit: (config: ChartConfig) => void;
onDelete: (id: string) => void; onDelete: (id: string) => void;
permission?: string;
projectId?: string;
} }
const getConfigDescription = (config: DisplayChartConfig): string => { const getConfigDescription = (config: DisplayChartConfig): string => {
@ -104,7 +106,13 @@ const StyledChartActions = styled(Box)(({ theme }) => ({
gap: theme.spacing(0.5), gap: theme.spacing(0.5),
})); }));
export const ChartItem: FC<ChartItemProps> = ({ config, onEdit, onDelete }) => ( export const ChartItem: FC<ChartItemProps> = ({
config,
onEdit,
onDelete,
permission = ADMIN,
projectId,
}) => (
<StyledWidget> <StyledWidget>
<StyledHeader> <StyledHeader>
<StyledDragHandle className='grid-item-drag-handle'> <StyledDragHandle className='grid-item-drag-handle'>
@ -121,13 +129,15 @@ export const ChartItem: FC<ChartItemProps> = ({ config, onEdit, onDelete }) => (
<StyledChartActions> <StyledChartActions>
<PermissionIconButton <PermissionIconButton
onClick={() => onEdit(config)} onClick={() => onEdit(config)}
permission={ADMIN} permission={permission}
projectId={projectId}
> >
<Edit /> <Edit />
</PermissionIconButton> </PermissionIconButton>
<PermissionIconButton <PermissionIconButton
onClick={() => onDelete(config.id)} onClick={() => onDelete(config.id)}
permission={ADMIN} permission={permission}
projectId={projectId}
> >
<Delete /> <Delete />
</PermissionIconButton> </PermissionIconButton>