Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-04 13:48:56 +02:00
Code Issues Projects Releases Wiki Activity

feat: decouple error impact metrics from logger (#10311)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2025-07-04 13:41:19 +02:00 committed by GitHub
parent e516bbf14c
commit 3bb7426392
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/lib/middleware/request-logger.ts
View File

@ -8,21 +8,27 @@ import {
const requestLogger: (config: IUnleashConfig) => RequestHandler = (config) => { const requestLogger: (config: IUnleashConfig) => RequestHandler = (config) => {
const logger = config.getLogger('HTTP'); const logger = config.getLogger('HTTP');
const enable = config.server.enableRequestLogger; const requestLoggerEnabled = config.server.enableRequestLogger;
const impactMetrics = config.flagResolver.impactMetrics; const impactMetrics = config.flagResolver.impactMetrics;
return (req, res, next) => { return (req, res, next) => {
if (enable) { const impactMetricsEnabled =
res.on('finish', () => { config.flagResolver.isEnabled('impactMetrics');
const { pathname } = url.parse(req.originalUrl);
res.on('finish', () => {
if (impactMetricsEnabled && impactMetrics) {
if (res.statusCode >= 400 && res.statusCode < 500) { if (res.statusCode >= 400 && res.statusCode < 500) {
impactMetrics?.incrementCounter(CLIENT_ERROR_COUNT); impactMetrics.incrementCounter(CLIENT_ERROR_COUNT);
} }
if (res.statusCode >= 500) { if (res.statusCode >= 500) {
impactMetrics?.incrementCounter(SERVER_ERROR_COUNT); impactMetrics.incrementCounter(SERVER_ERROR_COUNT);
} }
}
if (requestLoggerEnabled) {
const { pathname } = url.parse(req.originalUrl);
logger.info(`${res.statusCode} ${req.method} ${pathname}`); logger.info(`${res.statusCode} ${req.method} ${pathname}`);
}); }
} });
next(); next();
}; };
}; };