Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

fix: increase performance of outdated SDK query (#7226)

Browse Source 
Joining might not always be the best solution. If a table contains too
much data, and you later run sorting on top of it, it will be slow.

In this case, we will first reduce the instances table to a minimal
version because instances usually share the same SDK versions. Only
after that, we join.

Based on some customer data, we reduced query time from 3000ms to 60ms.
However, this will vary based on the number of instances the customer
has.
This commit is contained in:
Jaanus Sellin 2024-05-31 12:39:52 +03:00 committed by GitHub
parent de74faac46
commit 3c73ce9dd9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/lib/db/client-instance-store.ts
View File

@ -222,15 +222,22 @@ export default class ClientInstanceStore implements IClientInstanceStore {
projectId: string,
): Promise<{ sdkVersion: string; applications: string[] }[]> {
const rows = await this.db
.with(
'instances',
this.db
.select('app_name', 'sdk_version')
.distinct()
.from('client_instances'),
)
.select([
'ci.sdk_version as sdkVersion',
'i.sdk_version as sdkVersion',
this.db.raw('ARRAY_AGG(DISTINCT cme.app_name) as applications'),
])
.from('client_metrics_env as cme')
.leftJoin('features as f', 'f.name', 'cme.feature_name')
.leftJoin('client_instances as ci', 'ci.app_name', 'cme.app_name')
.leftJoin('instances as i', 'i.app_name', 'cme.app_name')
.where('f.project', projectId)
.groupBy('ci.sdk_version');
.groupBy('i.sdk_version');
return rows;
}