From 3cb7791452d897da34445c0dec70c96fa4ebe609 Mon Sep 17 00:00:00 2001 From: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com> Date: Tue, 11 Feb 2025 13:48:17 +0100 Subject: [PATCH] fix(1-3363): frontend flag type should not return truthy for variant --- frontend/src/hooks/useUiFlag.ts | 7 +++++-- src/lib/types/experimental.ts | 15 +++++++++++---- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/frontend/src/hooks/useUiFlag.ts b/frontend/src/hooks/useUiFlag.ts index e266aa159e..49e8d80e74 100644 --- a/frontend/src/hooks/useUiFlag.ts +++ b/frontend/src/hooks/useUiFlag.ts @@ -2,8 +2,11 @@ import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig'; type flags = ReturnType['uiConfig']['flags']; -export const useUiFlag = (flag: K) => { +export const useUiFlag = (flag: K): boolean => { const { uiConfig } = useUiConfig(); + if (typeof uiConfig?.flags?.[flag] !== 'boolean') { + console.error(`Flag ${flag} is undefined or a variant.`); + } - return uiConfig?.flags?.[flag] || false; + return Boolean(uiConfig?.flags?.[flag]) || false; }; diff --git a/src/lib/types/experimental.ts b/src/lib/types/experimental.ts index d02632391c..77312fde2a 100644 --- a/src/lib/types/experimental.ts +++ b/src/lib/types/experimental.ts @@ -310,10 +310,17 @@ const flags: IFlags = { process.env.UNLEASH_EXPERIMENTAL_DATA_USAGE_MULTI_MONTH_VIEW, false, ), - uiGlobalFontSize: parseEnvVarBoolean( - process.env.EXPERIMENTAL_UI_GLOBAL_FONT_SIZE_NAME, - false, - ), + uiGlobalFontSize: { + name: 'uiGlobalFontSize', + enabled: parseEnvVarBoolean( + process.env.EXPERIMENTAL_UI_GLOBAL_FONT_SIZE_NAME, + false, + ), + payload: { + type: PayloadType.JSON, + value: '14', + }, + }, }; export const defaultExperimentalOptions: IExperimentalOptions = {