Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

feat: ignore onboarding events for existing customers (#8064)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-09-03 15:24:33 +02:00 committed by GitHub
parent e70b09ae7b
commit 3d63089cb2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 43 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/lib/features/onboarding/onboarding-service.e2e.test.ts
View File

@ -76,6 +76,21 @@ test('Default project should take first user created instead of project created
]);
});
test('Ignore events for existing customers', async () => {
jest.useFakeTimers();
jest.setSystemTime(new Date(2024, 8, 2)); // day before we added metrics
const { userStore } = stores;
await userStore.insert({});
jest.setSystemTime(new Date());
await onboardingService.insert({ type: 'first-user-login' });
const { rows: instanceEvents } = await db.rawDatabase.raw(
'SELECT * FROM onboarding_events_instance',
);
expect(instanceEvents).toMatchObject([]);
});
test('Ignore system user in onboarding events', async () => {
// system users are not counted towards onboarding metrics
await db.rawDatabase.raw('INSERT INTO users (is_system) VALUES (true)');

41
src/lib/features/onboarding/onboarding-service.ts
View File

@ -13,7 +13,9 @@ import type {
IOnboardingStore,
ProjectEvent,
} from './onboarding-store-type';
import { millisecondsToSeconds } from 'date-fns';
import { isBefore, millisecondsToSeconds } from 'date-fns';
const START_ONBOARDING_TRACKING_DATE = new Date(2024, 8, 3);
export class OnboardingService {
private flagResolver: IFlagResolver;
@ -92,18 +94,28 @@ export class OnboardingService {
| { flag: string; type: ProjectEvent['type'] }
| { type: 'first-user-login' | 'second-user-login' },
): Promise<void> {
await this.insertInstanceEvent(event);
const firstInstanceUserDate = await this.userStore.getFirstUserDate();
// the time we introduced onboarding tracking
if (
firstInstanceUserDate &&
isBefore(firstInstanceUserDate, START_ONBOARDING_TRACKING_DATE)
)
return;
await this.insertInstanceEvent(event, firstInstanceUserDate);
if ('flag' in event) {
await this.insertProjectEvent(event);
await this.insertProjectEvent(event, firstInstanceUserDate);
}
this.eventBus.emit('onboarding-event');
}
private async insertInstanceEvent(event: {
flag?: string;
type: InstanceEvent['type'];
}): Promise<void> {
const firstInstanceUserDate = await this.userStore.getFirstUserDate();
private async insertInstanceEvent(
event: {
flag?: string;
type: InstanceEvent['type'];
},
firstInstanceUserDate: Date | null,
): Promise<void> {
if (!firstInstanceUserDate) return;
const timeToEvent = millisecondsToSeconds(
@ -115,10 +127,13 @@ export class OnboardingService {
});
}
private async insertProjectEvent(event: {
flag: string;
type: ProjectEvent['type'];
}): Promise<void> {
private async insertProjectEvent(
event: {
flag: string;
type: ProjectEvent['type'];
},
firstInstanceUserDate: Date | null,
): Promise<void> {
const project = await this.projectReadModel.getFeatureProject(
event.flag,
);
@ -126,7 +141,7 @@ export class OnboardingService {
const startDate =
project.project === 'default'
? await this.userStore.getFirstUserDate()
? firstInstanceUserDate
: project.createdAt || null;
if (!startDate) return;