mirror of
https://github.com/Unleash/unleash.git
synced 2025-01-20 00:08:02 +01:00
fix: disallow empty list of envs and invalid env names in advanced playground (#4060)
This PR changes the OpenAPI schema for the advanced playground to not accept empty lists of environments and to not accept environment names that don't match the env name pattern we use. The pattern is the same as the one we use for controlling environment names on creation. However, there is a (small) chance that these may get out of sync later, so we could do something to only define this pattern once (and import it in the enterprise package), but that may be more work than is necessary, and I'd suggest we do that later. I've also added a minLength to the string items although it isn't strictly necessary. It's primarily to give the users better feedback if the name is empty.
This commit is contained in:
parent
559caee642
commit
3fb00b281c
@ -11,7 +11,12 @@ export const advancedPlaygroundRequestSchema = {
|
||||
properties: {
|
||||
environments: {
|
||||
type: 'array',
|
||||
items: { type: 'string' },
|
||||
items: {
|
||||
type: 'string',
|
||||
minLength: 1,
|
||||
pattern: '^[a-zA-Z0-9~_.-]+$',
|
||||
},
|
||||
minItems: 1,
|
||||
example: ['development', 'production'],
|
||||
description: 'The environments to evaluate toggles in.',
|
||||
},
|
||||
|
@ -843,8 +843,11 @@ The provider you choose for your addon dictates what properties the \`parameters
|
||||
"production",
|
||||
],
|
||||
"items": {
|
||||
"minLength": 1,
|
||||
"pattern": "^[a-zA-Z0-9~_.-]+$",
|
||||
"type": "string",
|
||||
},
|
||||
"minItems": 1,
|
||||
"type": "array",
|
||||
},
|
||||
"projects": {
|
||||
|
Loading…
Reference in New Issue
Block a user