Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

chore: remove flagCreator flag (#7807)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-08-08 12:19:32 +02:00 committed by GitHub
parent ce30c069ee
commit 3fe385e127
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 22 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewMetaData/FeatureOverviewMetaData.tsx
View File

@ -103,7 +103,6 @@ const FeatureOverviewMetaData = () => {
const [showDelDialog, setShowDelDialog] = useState(false); const [showDelDialog, setShowDelDialog] = useState(false);
const [showMarkCompletedDialogue, setShowMarkCompletedDialogue] = const [showMarkCompletedDialogue, setShowMarkCompletedDialogue] =
useState(false); useState(false);
const flagCreatorEnabled = useUiFlag('flagCreator');
const { locationSettings } = useLocationSettings(); const { locationSettings } = useLocationSettings();
const showDependentFeatures = useShowDependentFeatures(feature.project); const showDependentFeatures = useShowDependentFeatures(feature.project);
@ -225,9 +224,7 @@ const FeatureOverviewMetaData = () => {
</StyledDetailsContainer> </StyledDetailsContainer>
</BodyItemWithIcon> </BodyItemWithIcon>
<ConditionallyRender <ConditionallyRender
condition={ condition={Boolean(feature.createdBy)}
Boolean(feature.createdBy) && flagCreatorEnabled
}
show={() => ( show={() => (
<BodyItemWithIcon> <BodyItemWithIcon>
<StyledDetailsContainer> <StyledDetailsContainer>

42
frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.tsx
View File

@ -56,7 +56,6 @@ export const ProjectFeatureToggles = ({
}: IPaginatedProjectFeatureTogglesProps) => { }: IPaginatedProjectFeatureTogglesProps) => {
const projectId = useRequiredPathParam('projectId'); const projectId = useRequiredPathParam('projectId');
const featureLifecycleEnabled = useUiFlag('featureLifecycle'); const featureLifecycleEnabled = useUiFlag('featureLifecycle');
const flagCreatorEnabled = useUiFlag('flagCreator');
const { const {
features, features,
@ -76,7 +75,7 @@ export const ProjectFeatureToggles = ({
createdAt: tableState.createdAt, createdAt: tableState.createdAt,
type: tableState.type, type: tableState.type,
state: tableState.state, state: tableState.state,
...(flagCreatorEnabled ? { createdBy: tableState.createdBy } : {}), createdBy: tableState.createdBy,
}; };
const { favorite, unfavorite } = useFavoriteFeaturesApi(); const { favorite, unfavorite } = useFavoriteFeaturesApi();
@ -168,20 +167,16 @@ export const ProjectFeatureToggles = ({
width: '1%', width: '1%',
}, },
}), }),
...(flagCreatorEnabled columnHelper.accessor('createdBy', {
? [ id: 'createdBy',
columnHelper.accessor('createdBy', { header: 'By',
id: 'createdBy', cell: AvatarCell(onAvatarClick),
header: 'By', enableSorting: false,
cell: AvatarCell(onAvatarClick), meta: {
enableSorting: false, width: '1%',
meta: { align: 'center',
width: '1%', },
align: 'center', }),
},
}),
]
: []),
columnHelper.accessor('lastSeenAt', { columnHelper.accessor('lastSeenAt', {
id: 'lastSeenAt', id: 'lastSeenAt',
header: 'Last seen', header: 'Last seen',
@ -425,16 +420,11 @@ export const ProjectFeatureToggles = ({
id: 'createdAt', id: 'createdAt',
isVisible: columnVisibility.createdAt, isVisible: columnVisibility.createdAt,
}, },
...(flagCreatorEnabled {
? [ header: 'By',
{ id: 'createdBy',
header: 'By', isVisible: columnVisibility.createdBy,
id: 'createdBy', },
isVisible:
columnVisibility.createdBy,
},
]
: []),
{ {
header: 'Last seen', header: 'Last seen',
id: 'lastSeenAt', id: 'lastSeenAt',

16
frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectOverviewFilters.tsx
View File

@ -6,7 +6,6 @@ import {
type IFilterItem, type IFilterItem,
} from 'component/filter/Filters/Filters'; } from 'component/filter/Filters/Filters';
import { useProjectFlagCreators } from 'hooks/api/getters/useProjectFlagCreators/useProjectFlagCreators'; import { useProjectFlagCreators } from 'hooks/api/getters/useProjectFlagCreators/useProjectFlagCreators';
import { useUiFlag } from 'hooks/useUiFlag';
interface IProjectOverviewFilters { interface IProjectOverviewFilters {
state: FilterItemParamHolder; state: FilterItemParamHolder;
@ -22,7 +21,6 @@ export const ProjectOverviewFilters: VFC<IProjectOverviewFilters> = ({
const { tags } = useAllTags(); const { tags } = useAllTags();
const { flagCreators } = useProjectFlagCreators(project); const { flagCreators } = useProjectFlagCreators(project);
const [availableFilters, setAvailableFilters] = useState<IFilterItem[]>([]); const [availableFilters, setAvailableFilters] = useState<IFilterItem[]>([]);
const flagCreatorEnabled = useUiFlag('flagCreator');
useEffect(() => { useEffect(() => {
const tagsOptions = (tags || []).map((tag) => ({ const tagsOptions = (tags || []).map((tag) => ({
@ -89,24 +87,18 @@ export const ProjectOverviewFilters: VFC<IProjectOverviewFilters> = ({
singularOperators: ['IS', 'IS_NOT'], singularOperators: ['IS', 'IS_NOT'],
pluralOperators: ['IS_ANY_OF', 'IS_NONE_OF'], pluralOperators: ['IS_ANY_OF', 'IS_NONE_OF'],
}, },
]; {
if (flagCreatorEnabled) {
availableFilters.push({
label: 'Created by', label: 'Created by',
icon: 'person', icon: 'person',
options: flagCreatorsOptions, options: flagCreatorsOptions,
filterKey: 'createdBy', filterKey: 'createdBy',
singularOperators: ['IS', 'IS_NOT'], singularOperators: ['IS', 'IS_NOT'],
pluralOperators: ['IS_ANY_OF', 'IS_NONE_OF'], pluralOperators: ['IS_ANY_OF', 'IS_NONE_OF'],
}); },
} ];
setAvailableFilters(availableFilters); setAvailableFilters(availableFilters);
}, [ }, [JSON.stringify(tags), JSON.stringify(flagCreators)]);
JSON.stringify(tags),
JSON.stringify(flagCreators),
flagCreatorEnabled,
]);
return ( return (
<Filters <Filters

4
frontend/src/component/project/Project/PaginatedProjectFeatureToggles/useProjectFeatureSearch.ts
View File

@ -15,7 +15,6 @@ import {
} from 'utils/serializeQueryParams'; } from 'utils/serializeQueryParams';
import { usePersistentTableState } from 'hooks/usePersistentTableState'; import { usePersistentTableState } from 'hooks/usePersistentTableState';
import mapValues from 'lodash.mapvalues'; import mapValues from 'lodash.mapvalues';
import { useUiFlag } from 'hooks/useUiFlag';
import type { SearchFeaturesParams } from 'openapi'; import type { SearchFeaturesParams } from 'openapi';
type Attribute = type Attribute =
@ -28,7 +27,6 @@ export const useProjectFeatureSearch = (
storageKey = 'project-overview-v2', storageKey = 'project-overview-v2',
refreshInterval = 15 * 1000, refreshInterval = 15 * 1000,
) => { ) => {
const flagCreatorEnabled = useUiFlag('flagCreator');
const stateConfig = { const stateConfig = {
offset: withDefault(NumberParam, 0), offset: withDefault(NumberParam, 0),
limit: withDefault(NumberParam, DEFAULT_PAGE_LIMIT), limit: withDefault(NumberParam, DEFAULT_PAGE_LIMIT),
@ -41,7 +39,7 @@ export const useProjectFeatureSearch = (
state: FilterItemParam, state: FilterItemParam,
createdAt: FilterItemParam, createdAt: FilterItemParam,
type: FilterItemParam, type: FilterItemParam,
...(flagCreatorEnabled ? { createdBy: FilterItemParam } : {}), createdBy: FilterItemParam,
}; };
const [tableState, setTableState] = usePersistentTableState( const [tableState, setTableState] = usePersistentTableState(
`${storageKey}-${projectId}`, `${storageKey}-${projectId}`,

1
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -125,7 +125,6 @@ exports[`should create default config 1`] = `
}, },
}, },
"filterInvalidClientMetrics": false, "filterInvalidClientMetrics": false,
"flagCreator": false,
"googleAuthEnabled": false, "googleAuthEnabled": false,
"improveCreateFlagFlow": false, "improveCreateFlagFlow": false,
"insightsV2": false, "insightsV2": false,

5
src/lib/types/experimental.ts
View File

@ -59,7 +59,6 @@ export type IFlagKey =
| 'enableLegacyVariants' | 'enableLegacyVariants'
| 'navigationSidebar' | 'navigationSidebar'
| 'commandBarUI' | 'commandBarUI'
| 'flagCreator'
| 'anonymizeProjectOwners' | 'anonymizeProjectOwners'
| 'resourceLimits' | 'resourceLimits'
| 'extendedMetrics' | 'extendedMetrics'
@ -292,10 +291,6 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_COMMAND_BAR_UI, process.env.UNLEASH_EXPERIMENTAL_COMMAND_BAR_UI,
false, false,
), ),
flagCreator: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_FLAG_CREATOR,
false,
),
anonymizeProjectOwners: parseEnvVarBoolean( anonymizeProjectOwners: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_ANONYMIZE_PROJECT_OWNERS, process.env.UNLEASH_EXPERIMENTAL_ANONYMIZE_PROJECT_OWNERS,
false, false,

1
src/server-dev.ts
View File

@ -53,7 +53,6 @@ process.nextTick(async () => {
manyStrategiesPagination: true, manyStrategiesPagination: true,
enableLegacyVariants: false, enableLegacyVariants: false,
commandBarUI: true, commandBarUI: true,
flagCreator: true,
resourceLimits: true, resourceLimits: true,
extendedMetrics: true, extendedMetrics: true,
insightsV2: true, insightsV2: true,