Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-04-15 01:16:22 +02:00
Code Issues Projects Releases Wiki Activity

fix: update roles permission guard (#4070)

Browse Source 
https://linear.app/unleash/issue/2-1162/read-roles-permissions-should-give-you-access-to-read-roles

This updates the roles page permission guard to be the `READ_ROLES`
permission instead of `ADMIN`, which better reflects on the UI the real
permissions of the user.

Our current `AdminAlert` component is pretty limited however, and I plan
to improve it in
https://linear.app/unleash/issue/2-1165/improve-adminalert-usage-to-be-more-generic-accept-non-admin
to better reflect the permission we're missing (instead of alerting that
you need to be an admin).
This commit is contained in:
Nuno Góis 2023-06-22 15:43:26 +01:00 committed by GitHub
parent 4cedb00e04
commit 4163788bba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/src/component/admin/roles/Roles.tsx
View File

@ -17,6 +17,7 @@ import { PageHeader } from 'component/common/PageHeader/PageHeader';
import { Add } from '@mui/icons-material';
import ResponsiveButton from 'component/common/ResponsiveButton/ResponsiveButton';
import { IRole } from 'interfaces/role';
import { READ_ROLE } from '@server/types/permissions';
const StyledPageContent = styled(PageContent)(({ theme }) => ({
'& .page-header': {
@ -84,7 +85,7 @@ export const Roles = () => {
return (
<div>
<ConditionallyRender
condition={hasAccess(ADMIN)}
condition={hasAccess(READ_ROLE)}
show={
<StyledPageContent
headerClass="page-header"