Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

fix: set favicon icon to CDN if prefix is set (#1553)

Browse Source
This commit is contained in:
Fredrik Strand Oseberg 2022-05-02 12:49:48 +02:00 committed by GitHub
parent 042d0137f3
commit 42e32a9118
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6386 additions and 5426 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/lib/util/rewriteHTML.test.ts
View File

@ -4,7 +4,7 @@ const input = `<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
<link rel="icon" href="::faviconPrefix::/favicon.ico" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="baseUriPath" content="::baseUriPath::" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
@ -14,7 +14,7 @@ const input = `<!DOCTYPE html>
<link
href="https://fonts.googleapis.com/icon?family=Material+Icons"
rel="stylesheet"
/>
/>
<link
href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700"
rel="stylesheet"
@ -68,3 +68,20 @@ test('rewriteHTML substitutes asset paths correctly without baseUriPath', () =>
),
).toBe(true);
});
test('rewriteHTML swaps out faviconPath if cdnPrefix is set', () => {
const result = rewriteHTML(input, '', 'https://cdn.getunleash.io/v4.1.0');
expect(
result.includes(
'<link rel="icon" href="https://cdn.getunleash.io/favicon.ico" />',
),
).toBe(true);
});
test('rewriteHTML sets favicon path to root', () => {
const result = rewriteHTML(input, '');
console.log(result);
expect(result.includes('<link rel="icon" href="/favicon.ico" />')).toBe(
true,
);
});

4
src/lib/util/rewriteHTML.ts
View File

@ -6,6 +6,10 @@ export const rewriteHTML = (
let result = input;
result = result.replace(/::baseUriPath::/gi, rewriteValue);
result = result.replace(/::cdnPrefix::/gi, cdnPrefix || '');
const faviconPrefix = cdnPrefix ? 'https://cdn.getunleash.io' : '';
result = result.replace(/::faviconPrefix::/gi, faviconPrefix);
result = result.replace(
/\/static/gi,
`${cdnPrefix || rewriteValue}/static`,

11787
yarn.lock
View File

File diff suppressed because it is too large Load Diff