Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

chore: remove variant dependencies flag (#6896)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-04-25 11:07:16 +02:00 committed by GitHub
parent af54e272d2
commit 44521c1c74
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 1 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/src/component/feature/Dependencies/AddDependencyDialogue.test.tsx
View File

@ -14,9 +14,6 @@ const setupApi = () => {
versionInfo: {
current: { oss: 'irrelevant', enterprise: 'some value' },
},
flags: {
variantDependencies: true,
},
});
testServerRoute(

6
frontend/src/component/feature/Dependencies/AddDependencyDialogue.tsx
View File

@ -4,7 +4,6 @@ import { Dialogue } from 'component/common/Dialogue/Dialogue';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import { useChangeRequestsEnabled } from 'hooks/useChangeRequestsEnabled';
import { DependenciesUpgradeAlert } from './DependenciesUpgradeAlert';
import { useUiFlag } from 'hooks/useUiFlag';
import type { IDependency } from '../../../interfaces/featureToggle';
import { ParentVariantOptions } from './ParentVariantOptions';
import { type ParentValue, REMOVE_DEPENDENCY_OPTION } from './constants';
@ -64,12 +63,9 @@ export const AddDependencyDialogue = ({
const { isChangeRequestConfiguredInAnyEnv } =
useChangeRequestsEnabled(project);
const variantDependenciesEnabled = useUiFlag('variantDependencies');
const showStatus =
parent !== REMOVE_DEPENDENCY_OPTION.key && variantDependenciesEnabled;
const showStatus = parent !== REMOVE_DEPENDENCY_OPTION.key;
const showVariants =
parent !== REMOVE_DEPENDENCY_OPTION.key &&
variantDependenciesEnabled &&
parentValue.status === 'enabled_with_variants';
const selectStatus = (value: string) => {

3
frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewSidePanel/FeatureOverviewSidePanelDetails/FeatureOverviewSidePanelDetails.test.tsx
View File

@ -13,9 +13,6 @@ const setupApi = () => {
versionInfo: {
current: { oss: 'irrelevant', enterprise: 'some value' },
},
flags: {
variantDependencies: true,
},
});
testServerRoute(server, '/api/admin/projects/default/features/feature', {});
testServerRoute(

1
frontend/src/interfaces/uiConfig.ts
View File

@ -78,7 +78,6 @@ export type UiFlags = {
projectOverviewRefactor?: string;
displayTrafficDataUsage?: boolean;
disableShowContextFieldSelectionValues?: boolean;
variantDependencies?: boolean;
projectOverviewRefactorFeedback?: boolean;
featureLifecycle?: boolean;
scimApi?: boolean;

1
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -149,7 +149,6 @@ exports[`should create default config 1`] = `
"strictSchemaValidation": false,
"useMemoizedActiveTokens": false,
"userAccessUIEnabled": false,
"variantDependencies": false,
},
"externalResolver": {
"getVariant": [Function],

5
src/lib/types/experimental.ts
View File

@ -52,7 +52,6 @@ export type IFlagKey =
| 'scimApi'
| 'displayEdgeBanner'
| 'projectOverviewRefactor'
| 'variantDependencies'
| 'disableShowContextFieldSelectionValues'
| 'bearerTokenMiddleware'
| 'projectOverviewRefactorFeedback'
@ -262,10 +261,6 @@ const flags: IFlags = {
.UNLEASH_EXPERIMENTAL_DISABLE_SHOW_CONTEXT_FIELD_SELECTION_VALUES,
false,
),
variantDependencies: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_VARIANT_DEPENDENCIES,
false,
),
bearerTokenMiddleware: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_BEARER_TOKEN_MIDDLEWARE,
false,

1
src/server-dev.ts
View File

@ -49,7 +49,6 @@ process.nextTick(async () => {
outdatedSdksBanner: true,
projectOverviewRefactor: true,
disableShowContextFieldSelectionValues: false,
variantDependencies: true,
projectOverviewRefactorFeedback: true,
featureLifecycle: true,
projectListFilterMyProjects: true,