Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: seed setup and remove admin/features call (#3567)

Browse Source 
## About the changes
Seed setup fails because of compilation errors, we need to skip errors
until we fix them. Also, this removes one usage of `/api/admin/features`
that was used only for testing
This commit is contained in:
Gastón Fournier 2023-04-20 11:37:56 +02:00 committed by GitHub
parent 551c00b6b2
commit 44b19e92ee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -51,7 +51,7 @@
"test:coverage": "NODE_ENV=test PORT=4243 jest --coverage --testLocationInResults --outputFile=\"coverage/report.json\" --forceExit --testTimeout=10000", "test:coverage": "NODE_ENV=test PORT=4243 jest --coverage --testLocationInResults --outputFile=\"coverage/report.json\" --forceExit --testTimeout=10000",
"pretest:coverage:jest": "yarn build:frontend", "pretest:coverage:jest": "yarn build:frontend",
"test:coverage:jest": "NODE_ENV=test PORT=4243 jest --silent --ci --json --coverage --testLocationInResults --outputFile=\"report.json\" --forceExit --testTimeout=10000", "test:coverage:jest": "NODE_ENV=test PORT=4243 jest --silent --ci --json --coverage --testLocationInResults --outputFile=\"report.json\" --forceExit --testTimeout=10000",
"seed:setup": "ts-node src/test/e2e/seed/segment.seed.ts", "seed:setup": "ts-node --compilerOptions '{\"strictNullChecks\": false}' src/test/e2e/seed/segment.seed.ts",
"seed:serve": "UNLEASH_DATABASE_NAME=unleash_test UNLEASH_DATABASE_SCHEMA=seed yarn run start:dev", "seed:serve": "UNLEASH_DATABASE_NAME=unleash_test UNLEASH_DATABASE_SCHEMA=seed yarn run start:dev",
"clean": "del-cli --force dist", "clean": "del-cli --force dist",
"preversion": "./scripts/check-release.sh", "preversion": "./scripts/check-release.sh",

17
src/test/e2e/seed/segment.seed.ts
View File

@ -33,13 +33,6 @@ const fetchSegments = (app: IUnleashTest): Promise<ISegment[]> => {
return app.services.segmentService.getAll(); return app.services.segmentService.getAll();
}; };
const fetchFeatures = (app: IUnleashTest): Promise<IFeatureToggleClient[]> => {
return app.request
.get('/api/admin/features')
.expect(200)
.then((res) => res.body.features);
};
const createSegment = ( const createSegment = (
app: IUnleashTest, app: IUnleashTest,
postData: UpsertSegmentSchema, postData: UpsertSegmentSchema,
@ -52,11 +45,12 @@ const createFeatureToggle = (
app: IUnleashTest, app: IUnleashTest,
postData: object, postData: object,
expectStatusCode = 201, expectStatusCode = 201,
): Promise<unknown> => { ): Promise<IFeatureToggleClient> => {
return app.request return app.request
.post('/api/admin/features') .post('/api/admin/features')
.send(postData) .send(postData)
.expect(expectStatusCode); .expect(expectStatusCode)
.then((res) => res.body);
}; };
const addSegmentToStrategy = ( const addSegmentToStrategy = (
@ -116,13 +110,12 @@ const seedSegmentsDatabase = async (
}), }),
); );
await Promise.all( const features = await Promise.all(
seedFeatures(spec).map((seed) => { seedFeatures(spec).map(async (seed) => {
return createFeatureToggle(app, seed); return createFeatureToggle(app, seed);
}), }),
); );
const features = await fetchFeatures(app);
const segments = await fetchSegments(app); const segments = await fetchSegments(app);
assert(features.length === spec.featuresCount); assert(features.length === spec.featuresCount);
assert(segments.length === spec.segmentsPerFeature); assert(segments.length === spec.segmentsPerFeature);