1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-18 13:48:58 +02:00

Add default to strategy change

This commit is contained in:
Thomas Heartman 2025-07-03 12:57:15 +02:00
parent 88bdb41eaa
commit 46e8a174ae
3 changed files with 38 additions and 8 deletions

View File

@ -96,7 +96,15 @@ export const FeatureChange: FC<{
change: IFeatureChange;
feature: IChangeRequestFeature;
onNavigate?: () => void;
}> = ({ index, change, feature, changeRequest, actions, onNavigate }) => {
}> = ({
index,
change,
feature,
changeRequest,
actions,
onNavigate,
isDefaultChange,
}) => {
const lastIndex = feature.defaultChange
? feature.changes.length + 1
: feature.changes.length;
@ -190,7 +198,7 @@ export const FeatureChange: FC<{
)}
{change.action === 'updateEnabled' && (
<StatusChangeComponent
isDefaultChange
isDefaultChange={isDefaultChange}
enabled={change.payload.enabled}
actions={actions}
/>
@ -204,6 +212,7 @@ export const FeatureChange: FC<{
change.action === 'updateStrategy' ? (
<StrategyChangeComponent
actions={actions}
isDefaultChange={isDefaultChange}
change={change}
featureName={feature.name}
environmentName={changeRequest.environment}

View File

@ -262,7 +262,8 @@ const UpdateStrategy: FC<{
const AddStrategy: FC<{
change: IChangeRequestAddStrategy;
actions?: ReactNode;
}> = ({ change, actions }) => (
isDefaultChange?: boolean;
}> = ({ change, actions, isDefaultChange }) => (
<>
<ChangeItemCreateEditDeleteWrapper>
<ChangeItemInfo>
@ -288,7 +289,14 @@ const AddStrategy: FC<{
/>
</div>
</ChangeItemInfo>
<div>{actions}</div>
<div>
{isDefaultChange ? (
<Typography variant='body2' color='text.secondary'>
Default strategy will be added
</Typography>
) : null}
{actions}
</div>
</ChangeItemCreateEditDeleteWrapper>
<StrategyExecution strategy={change.payload} />
{change.payload.variants?.length ? (
@ -316,6 +324,7 @@ export const LegacyStrategyChange: FC<{
featureName: string;
projectId: string;
changeRequestState: ChangeRequestState;
isDefaultChange?: boolean;
}> = ({
actions,
change,
@ -323,6 +332,7 @@ export const LegacyStrategyChange: FC<{
environmentName,
projectId,
changeRequestState,
isDefaultChange,
}) => {
const currentStrategy = useCurrentStrategy(
change,
@ -334,7 +344,11 @@ export const LegacyStrategyChange: FC<{
return (
<>
{change.action === 'addStrategy' && (
<AddStrategy change={change} actions={actions} />
<AddStrategy
change={change}
actions={actions}
isDefaultChange={isDefaultChange}
/>
)}
{change.action === 'deleteStrategy' && (
<DeleteStrategy

View File

@ -239,13 +239,14 @@ const UpdateStrategy: FC<{
const AddStrategy: FC<{
change: IChangeRequestAddStrategy;
isDefaultChange?: boolean;
actions?: ReactNode;
}> = ({ change, actions }) => (
}> = ({ change, isDefaultChange, actions }) => (
<>
<ChangeItemWrapper>
<ChangeItemInfo>
<AddedStrategy disabled={change.payload?.disabled}>
Adding strategy
Adding {isDefaultChange && 'default'} strategy
</AddedStrategy>
<ChangeStrategyName
name={change.payload.name}
@ -300,6 +301,7 @@ export const StrategyChange: FC<{
featureName: string;
projectId: string;
changeRequestState: ChangeRequestState;
isDefaultChange?: boolean;
}> = ({
actions,
change,
@ -307,6 +309,7 @@ export const StrategyChange: FC<{
environmentName,
projectId,
changeRequestState,
isDefaultChange,
}) => {
const currentStrategy = useCurrentStrategy(
change,
@ -328,7 +331,11 @@ export const StrategyChange: FC<{
return (
<StyledTabs>
{change.action === 'addStrategy' && (
<AddStrategy change={change} actions={actionsWithTabs} />
<AddStrategy
change={change}
actions={actionsWithTabs}
isDefaultChange={isDefaultChange}
/>
)}
{change.action === 'deleteStrategy' && (
<DeleteStrategy