mirror of
https://github.com/Unleash/unleash.git
synced 2025-05-03 01:18:43 +02:00
Merge pull request #805 from Unleash/fix-rollout-datatype
fix: change rollout datatype to string
This commit is contained in:
commit
47e43dc23c
@ -114,7 +114,7 @@ describe('feature', () => {
|
||||
expect(req.body.name).to.equal('flexibleRollout');
|
||||
expect(req.body.parameters.groupId).to.equal(featureToggleName);
|
||||
expect(req.body.parameters.stickiness).to.equal('default');
|
||||
expect(req.body.parameters.rollout).to.equal(30);
|
||||
expect(req.body.parameters.rollout).to.equal('30');
|
||||
|
||||
if (enterprise) {
|
||||
expect(req.body.constraints.length).to.equal(1);
|
||||
@ -160,7 +160,7 @@ describe('feature', () => {
|
||||
req => {
|
||||
expect(req.body.parameters.groupId).to.equal('new-group-id');
|
||||
expect(req.body.parameters.stickiness).to.equal('sessionId');
|
||||
expect(req.body.parameters.rollout).to.equal(60);
|
||||
expect(req.body.parameters.rollout).to.equal('60');
|
||||
|
||||
if (enterprise) {
|
||||
expect(req.body.constraints.length).to.equal(1);
|
||||
|
@ -44,7 +44,7 @@ const FlexibleStrategy = ({
|
||||
e: React.ChangeEvent<{}>,
|
||||
value: number | number[]
|
||||
) => {
|
||||
updateParameter('rollout', value);
|
||||
updateParameter('rollout', value.toString());
|
||||
};
|
||||
|
||||
const resolveStickiness = () =>
|
||||
@ -62,7 +62,8 @@ const FlexibleStrategy = ({
|
||||
|
||||
const stickinessOptions = resolveStickiness();
|
||||
|
||||
const rollout = parameters.rollout !== undefined ? parameters.rollout : 100;
|
||||
const rollout =
|
||||
parameters.rollout !== undefined ? parameters.rollout : '100';
|
||||
const stickiness = parameters.stickiness;
|
||||
const groupId = parameters.groupId;
|
||||
|
||||
@ -70,7 +71,7 @@ const FlexibleStrategy = ({
|
||||
<div>
|
||||
<RolloutSlider
|
||||
name="Rollout"
|
||||
value={1 * rollout}
|
||||
value={parseInt(rollout)}
|
||||
disabled={!editable}
|
||||
onChange={updateRollout}
|
||||
/>
|
||||
|
@ -28,7 +28,7 @@ export interface IConstraint {
|
||||
|
||||
export interface IParameter {
|
||||
groupId?: string;
|
||||
rollout?: number;
|
||||
rollout?: string;
|
||||
stickiness?: string;
|
||||
|
||||
[index: string]: any;
|
||||
|
Loading…
Reference in New Issue
Block a user