From 4801b64824a91503d5542892e46dd954298b6b91 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gast=C3=B3n=20Fournier?= <gaston@getunleash.io>
Date: Fri, 17 Nov 2023 14:56:09 +0100
Subject: [PATCH] feat(banners): enable customer banners (#5348)

## About the changes
This feature allows our Enterprise customers to configure banners to be
displayed on their Unleash instance for all their users to see and
interact with. Previously known as "internal message banners".
---
 frontend/src/component/admin/adminRoutes.ts             | 1 -
 frontend/src/hooks/api/getters/useBanners/useBanners.ts | 4 +---
 src/lib/types/experimental.ts                           | 4 ----
 3 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/frontend/src/component/admin/adminRoutes.ts b/frontend/src/component/admin/adminRoutes.ts
index 50a422a594..26907667ed 100644
--- a/frontend/src/component/admin/adminRoutes.ts
+++ b/frontend/src/component/admin/adminRoutes.ts
@@ -77,7 +77,6 @@ export const adminRoutes: INavigationMenuItem[] = [
     {
         path: '/admin/banners',
         title: 'Banners',
-        flag: 'banners',
         menu: { adminSettings: true, mode: ['enterprise'] },
         group: 'instance',
     },
diff --git a/frontend/src/hooks/api/getters/useBanners/useBanners.ts b/frontend/src/hooks/api/getters/useBanners/useBanners.ts
index f6e6399fb6..fe0948151c 100644
--- a/frontend/src/hooks/api/getters/useBanners/useBanners.ts
+++ b/frontend/src/hooks/api/getters/useBanners/useBanners.ts
@@ -3,17 +3,15 @@ import { formatApiPath } from 'utils/formatPath';
 import handleErrorResponses from '../httpErrorResponseHandler';
 import { useConditionalSWR } from '../useConditionalSWR/useConditionalSWR';
 import useUiConfig from '../useUiConfig/useUiConfig';
-import { useUiFlag } from 'hooks/useUiFlag';
 import { IInternalBanner } from 'interfaces/banner';
 
 const ENDPOINT = 'api/admin/banners';
 
 export const useBanners = () => {
     const { isEnterprise } = useUiConfig();
-    const bannersEnabled = useUiFlag('banners');
 
     const { data, error, mutate } = useConditionalSWR(
-        isEnterprise() && bannersEnabled,
+        isEnterprise(),
         { banners: [] },
         formatApiPath(ENDPOINT),
         fetcher,
diff --git a/src/lib/types/experimental.ts b/src/lib/types/experimental.ts
index c67d7133cd..d6825d5eb7 100644
--- a/src/lib/types/experimental.ts
+++ b/src/lib/types/experimental.ts
@@ -144,10 +144,6 @@ const flags: IFlags = {
         process.env.UNLEASH_EXPERIMENTAL_USE_LAST_SEEN_REFACTOR,
         false,
     ),
-    banners: parseEnvVarBoolean(
-        process.env.UNLEASH_EXPERIMENTAL_BANNERS,
-        false,
-    ),
     disableEnvsOnRevive: parseEnvVarBoolean(
         process.env.UNLEASH_EXPERIMENTAL_DISABLE_ENVS_ON_REVIVE,
         false,