diff --git a/frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/MilestoneProgressionForm/MilestoneProgressionTimeInput.tsx b/frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/MilestoneProgressionForm/MilestoneProgressionTimeInput.tsx index 321a445300..870d6e51f0 100644 --- a/frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/MilestoneProgressionForm/MilestoneProgressionTimeInput.tsx +++ b/frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/MilestoneProgressionForm/MilestoneProgressionTimeInput.tsx @@ -75,8 +75,7 @@ export const MilestoneProgressionTimeInput = ({ return ( filtered by handleApplicationChange(String(e.target.value)) @@ -287,12 +286,15 @@ export const SafeguardForm = ({ - handleThresholdChange(Number(e.target.value)) - } + onChange={(e) => { + const value = e.target.value; + handleThresholdChange(Number(value)); + }} placeholder='Value' variant='outlined' size='small' diff --git a/frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/hooks/useMilestoneProgressionForm.ts b/frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/hooks/useMilestoneProgressionForm.ts index 9fb16ee5d5..a275af091e 100644 --- a/frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/hooks/useMilestoneProgressionForm.ts +++ b/frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/hooks/useMilestoneProgressionForm.ts @@ -1,5 +1,5 @@ -import { useState, useCallback } from 'react'; -import { isPast, addMinutes } from 'date-fns'; +import { useCallback, useState } from 'react'; +import { addMinutes, isPast } from 'date-fns'; import type { MilestoneStatus } from '../ReleasePlanMilestone/ReleasePlanMilestoneStatus.tsx'; import { formatDateYMDHM } from 'utils/formatDate.ts'; @@ -112,10 +112,7 @@ export const useMilestoneProgressionForm = ( event: React.ChangeEvent, ) => { const inputValue = event.target.value; - if (inputValue === '' || /^\d+$/.test(inputValue)) { - const value = inputValue === '' ? 0 : Number.parseInt(inputValue); - setTimeValue(value); - } + setTimeValue(Number(inputValue)); }; const clearErrors = useCallback(() => { diff --git a/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ModeSelector/ModeSelector.tsx b/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ModeSelector/ModeSelector.tsx index c603332797..5ec8e97e9f 100644 --- a/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ModeSelector/ModeSelector.tsx +++ b/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ModeSelector/ModeSelector.tsx @@ -15,7 +15,7 @@ export const ModeSelector: FC = ({ }) => { if (metricType === 'unknown') return null; return ( - + Mode