From 49c25cbaa6021691a14874222f44b1d29fc2cc26 Mon Sep 17 00:00:00 2001
From: olav <mail@olav.io>
Date: Mon, 21 Feb 2022 15:22:37 +0100
Subject: [PATCH] refactor: remove lazy loading for metrics page (#733)

---
 .../feature/FeatureView/FeatureView.tsx       | 59 +++++++++----------
 1 file changed, 27 insertions(+), 32 deletions(-)

diff --git a/frontend/src/component/feature/FeatureView/FeatureView.tsx b/frontend/src/component/feature/FeatureView/FeatureView.tsx
index 71e88d2a65..84aba96216 100644
--- a/frontend/src/component/feature/FeatureView/FeatureView.tsx
+++ b/frontend/src/component/feature/FeatureView/FeatureView.tsx
@@ -1,5 +1,5 @@
 import { Tab, Tabs, useMediaQuery } from '@material-ui/core';
-import React, { Suspense, useState } from 'react';
+import React, { useState } from 'react';
 import { Archive, FileCopy, Label, WatchLater } from '@material-ui/icons';
 import { Link, Route, useHistory, useParams } from 'react-router-dom';
 import useFeatureApi from '../../../hooks/api/actions/useFeatureApi/useFeatureApi';
@@ -19,6 +19,7 @@ import FeatureLog from './FeatureLog/FeatureLog';
 import FeatureOverview from './FeatureOverview/FeatureOverview';
 import FeatureStrategies from './FeatureStrategies/FeatureStrategies';
 import FeatureVariants from './FeatureVariants/FeatureVariants';
+import { FeatureMetrics } from './FeatureMetrics/FeatureMetrics';
 import { useStyles } from './FeatureView.styles';
 import FeatureSettings from './FeatureSettings/FeatureSettings';
 import useLoading from '../../../hooks/useLoading';
@@ -203,33 +204,31 @@ const FeatureView = () => {
                             </Tabs>
                         </div>
                     </div>
-                    <Suspense fallback={null}>
-                        <Route
-                            exact
-                            path={`/projects/:projectId/features/:featureId`}
-                            component={FeatureOverview}
-                        />
-                        <Route
-                            path={`/projects/:projectId/features/:featureId/strategies`}
-                            component={FeatureStrategies}
-                        />
-                        <Route
-                            path={`/projects/:projectId/features/:featureId/metrics`}
-                            component={FeatureMetricsLazy}
-                        />
-                        <Route
-                            path={`/projects/:projectId/features/:featureId/logs`}
-                            component={FeatureLog}
-                        />
-                        <Route
-                            path={`/projects/:projectId/features/:featureId/variants`}
-                            component={FeatureVariants}
-                        />
-                        <Route
-                            path={`/projects/:projectId/features/:featureId/settings`}
-                            component={FeatureSettings}
-                        />
-                    </Suspense>
+                    <Route
+                        exact
+                        path={`/projects/:projectId/features/:featureId`}
+                        component={FeatureOverview}
+                    />
+                    <Route
+                        path={`/projects/:projectId/features/:featureId/strategies`}
+                        component={FeatureStrategies}
+                    />
+                    <Route
+                        path={`/projects/:projectId/features/:featureId/metrics`}
+                        component={FeatureMetrics}
+                    />
+                    <Route
+                        path={`/projects/:projectId/features/:featureId/logs`}
+                        component={FeatureLog}
+                    />
+                    <Route
+                        path={`/projects/:projectId/features/:featureId/variants`}
+                        component={FeatureVariants}
+                    />
+                    <Route
+                        path={`/projects/:projectId/features/:featureId/settings`}
+                        component={FeatureSettings}
+                    />
                     <Dialogue
                         onClick={() => archiveToggle()}
                         open={showDelDialog}
@@ -256,8 +255,4 @@ const FeatureView = () => {
     );
 };
 
-const FeatureMetricsLazy = React.lazy(
-    () => import('./FeatureMetrics/FeatureMetrics')
-);
-
 export default FeatureView;