Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-05-22 01:16:07 +02:00
Code Issues Projects Releases Wiki Activity

task: enclose ETag in double quotes. (#3385)

Browse Source 
According to the
[RFC](https://www.rfc-editor.org/rfc/rfc7232#section-2.3) Etags should
be enclosed in double quotes. This PR makes sure we do actually wrap it
in double quotes
This commit is contained in:
Christopher Kolstad 2023-03-24 16:11:42 +01:00 committed by GitHub
parent 59ff86cafc
commit 49fbf4a635
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/routes/client-api/feature.ts
View File

@ -1,7 +1,7 @@
import memoizee from 'memoizee';
import { Response } from 'express';
// eslint-disable-next-line import/no-extraneous-dependencies
import hasSum from 'hash-sum';
import hashSum from 'hash-sum';
// eslint-disable-next-line import/no-extraneous-dependencies
import { diff } from 'deep-object-diff';
import Controller from '../controller';
@ -318,8 +318,8 @@ export default class FeatureController extends Controller {
const revisionId = await this.eventService.getMaxRevisionId();
// TODO: We will need to standardize this to be able to implement this a cross languages (Edge in Rust?).
const queryHash = hasSum(query);
const etag = `${queryHash}:${revisionId}`;
const queryHash = hashSum(query);
const etag = `"${queryHash}:${revisionId}"`;
return { revisionId, etag, queryHash };
}

10
src/test/e2e/api/client/feature.optimal304.e2e.test.ts
View File

@ -122,14 +122,14 @@ test('returns calculated hash', async () => {
.get('/api/client/features')
.expect('Content-Type', /json/)
.expect(200);
expect(res.headers.etag).toBe('ae443048:19');
expect(res.body.meta.etag).toBe('ae443048:19');
expect(res.headers.etag).toBe('"ae443048:19"');
expect(res.body.meta.etag).toBe('"ae443048:19"');
});
test('returns 304 for pre-calculated hash', async () => {
return app.request
.get('/api/client/features')
.set('if-none-match', 'ae443048:19')
.set('if-none-match', '"ae443048:19"')
.expect(304);
});
@ -149,6 +149,6 @@ test('returns 200 when content updates and hash does not match anymore', async (
.set('if-none-match', 'ae443048:19')
.expect(200);
expect(res.headers.etag).toBe('ae443048:20');
expect(res.body.meta.etag).toBe('ae443048:20');
expect(res.headers.etag).toBe('"ae443048:20"');
expect(res.body.meta.etag).toBe('"ae443048:20"');
});