Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

fix: allow for empty groupId in form (#7798)

Browse Source 
`groupId` parameter because of the change in validation wasn't parsed
correctly. Intent was to fill it when it is empty, when the form is loaded.
By mistake the same logic applies when you manually remove all
characters from the text field.
This commit is contained in:
Tymoteusz Czech 2024-08-07 16:34:30 +02:00 committed by GitHub
parent ff9b7298b6
commit 4daede8e1c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
frontend/src/component/feature/StrategyTypes/FlexibleStrategy/FlexibleStrategy.tsx
View File

@ -1,4 +1,4 @@
import { useMemo } from 'react';
import { useEffect, useMemo } from 'react';
import { Box, styled } from '@mui/material';
import type { IFeatureStrategyParameters } from 'interfaces/strategy';
import RolloutSlider from '../RolloutSlider/RolloutSlider';
@ -82,7 +82,7 @@ const FlexibleStrategy = ({
return parseParameterString(parameters.stickiness);
}, [loading, defaultStickiness, parameters.stickiness]);
const groupId = useMemo(() => {
useEffect(() => {
if (!parameters.groupId && !loading) {
if (isDefaultStrategyEdit || !featureId) {
updateParameter('groupId', '');
@ -90,9 +90,9 @@ const FlexibleStrategy = ({
updateParameter('groupId', featureId);
}
}
}, [isDefaultStrategyEdit, featureId, loading]);
return parseParameterString(parameters.groupId);
}, [parameters.groupId, isDefaultStrategyEdit, featureId, loading]);
const groupId = parseParameterString(parameters.groupId);
if (loading) {
return <Loader />;
@ -126,7 +126,10 @@ const FlexibleStrategy = ({
value={groupId}
disabled={!editable}
onChange={(e) =>
updateParameter('groupId', e.target.value)
updateParameter(
'groupId',
parseParameterString(e.target.value),
)
}
data-testid={FLEXIBLE_STRATEGY_GROUP_ID}
error={Boolean(errors?.getFormError('groupId'))}