Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

feat: check toggle limit on import (#4665)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2023-09-12 13:53:04 +02:00 committed by GitHub
parent 0cd0d2f153
commit 4dcbb4b997
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/lib/features/export-import-toggles/export-import-service.ts
View File

@ -370,30 +370,27 @@ export default class ExportImportService {
private async createOrUpdateToggles(dto: ImportTogglesSchema, user: User) { private async createOrUpdateToggles(dto: ImportTogglesSchema, user: User) {
const existingFeatures = await this.getExistingProjectFeatures(dto); const existingFeatures = await this.getExistingProjectFeatures(dto);
const username = extractUsernameFromUser(user); const username = extractUsernameFromUser(user);
await Promise.all(
dto.data.features.map((feature) => { for (const feature of dto.data.features) {
if (existingFeatures.includes(feature.name)) { if (existingFeatures.includes(feature.name)) {
const { archivedAt, createdAt, ...rest } = feature; const { archivedAt, createdAt, ...rest } = feature;
return this.featureToggleService.updateFeatureToggle( await this.featureToggleService.updateFeatureToggle(
dto.project, dto.project,
rest as FeatureToggleDTO, rest as FeatureToggleDTO,
username, username,
feature.name, feature.name,
); );
} } else {
return this.featureToggleService await this.featureToggleService.validateName(feature.name);
.validateName(feature.name)
.then(() => {
const { archivedAt, createdAt, ...rest } = feature; const { archivedAt, createdAt, ...rest } = feature;
return this.featureToggleService.createFeatureToggle( await this.featureToggleService.createFeatureToggle(
dto.project, dto.project,
rest as FeatureToggleDTO, rest as FeatureToggleDTO,
extractUsernameFromUser(user), username,
);
});
}),
); );
} }
}
}
private async verifyContextFields(dto: ImportTogglesSchema) { private async verifyContextFields(dto: ImportTogglesSchema) {
const unsupportedContextFields = await this.getUnsupportedContextFields( const unsupportedContextFields = await this.getUnsupportedContextFields(

15
src/lib/features/export-import-toggles/export-import.e2e.test.ts
View File

@ -104,7 +104,10 @@ const createVariants = async (feature: string, variants: IVariant[]) => {
); );
}; };
const createProjects = async (projects: string[] = [DEFAULT_PROJECT]) => { const createProjects = async (
projects: string[] = [DEFAULT_PROJECT],
featureLimit = 2,
) => {
await db.stores.environmentStore.create({ await db.stores.environmentStore.create({
name: DEFAULT_ENV, name: DEFAULT_ENV,
type: 'production', type: 'production',
@ -115,6 +118,7 @@ const createProjects = async (projects: string[] = [DEFAULT_PROJECT]) => {
description: '', description: '',
id: project, id: project,
mode: 'open' as const, mode: 'open' as const,
featureLimit,
}); });
await app.linkProjectToEnvironment(project, DEFAULT_ENV); await app.linkProjectToEnvironment(project, DEFAULT_ENV);
} }
@ -725,6 +729,13 @@ test('import multiple features with same tag', async () => {
}); });
}); });
test('import too many feature exceeding limit', async () => {
const featureLimit = 1;
await createProjects([DEFAULT_PROJECT], featureLimit);
await app.importToggles(importWithMultipleFeatures, 403);
});
test('can update toggles on subsequent import', async () => { test('can update toggles on subsequent import', async () => {
await createProjects(); await createProjects();
await app.importToggles(defaultImportPayload); await app.importToggles(defaultImportPayload);
@ -828,7 +839,7 @@ test('reject import with duplicate features', async () => {
); );
expect(body.details[0].description).toBe( expect(body.details[0].description).toBe(
'Feature first_feature already exists', 'A toggle with that name already exists',
); );
}); });