Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: do not allow empty ('') constrain values.

Browse Source 
related #640
This commit is contained in:
Ivar Conradi Østhus 2020-10-30 10:30:28 +01:00
parent 7d46dcbb21
commit 4f3a94cb86
2 changed files with 58 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/routes/admin-api/feature-schema.js
View File

@ -8,7 +8,12 @@ const nameSchema = joi.object().keys({ name: nameType });
const constraintSchema = joi.object().keys({
contextName: joi.string(),
operator: joi.string(),
values: joi.array().items(joi.string()),
values: joi.array().items(
joi
.string()
.min(1)
.max(100),
),
});
const strategiesSchema = joi.object().keys({

52
lib/routes/admin-api/feature-schema.test.js
View File

@ -172,3 +172,55 @@ test('should keep constraints', t => {
t.deepEqual(value, toggle);
t.falsy(error);
});
test('should not accept empty constraint values', t => {
const toggle = {
name: 'app.constraints.empty.value',
type: 'release',
enabled: false,
stale: false,
strategies: [
{
name: 'default',
constraints: [
{
contextName: 'environment',
operator: 'IN',
values: [''],
},
],
},
],
};
const { error } = featureShema.validate(toggle);
t.deepEqual(
error.details[0].message,
'"strategies[0].constraints[0].values[0]" is not allowed to be empty',
);
});
test('should not accept empty list of constraint values', t => {
const toggle = {
name: 'app.constraints.empty.value.list',
type: 'release',
enabled: false,
stale: false,
strategies: [
{
name: 'default',
constraints: [
{
contextName: 'environment',
operator: 'IN',
values: [],
},
],
},
],
};
const { value, error } = featureShema.validate(toggle);
t.deepEqual(value, toggle);
t.falsy(error);
});