mirror of
https://github.com/Unleash/unleash.git
synced 2025-02-23 00:22:19 +01:00
fix: clean up history view a bit
This commit is contained in:
parent
d70d3ab978
commit
509b3a6186
@ -8,6 +8,27 @@ import { formatFullDateTimeWithLocale } from '../common/util';
|
||||
|
||||
import styles from './history.scss';
|
||||
|
||||
const HistoryMeta = ({ entry, timeFormatted }) => (
|
||||
<div>
|
||||
<dl>
|
||||
<dt>Changed at:</dt>
|
||||
<dd>{timeFormatted}</dd>
|
||||
<dt>Changed by: </dt>
|
||||
<dd title={entry.createdBy}>{entry.createdBy}</dd>
|
||||
<dt>Type: </dt>
|
||||
<dd>{entry.type}</dd>
|
||||
<dt>Name: </dt>
|
||||
<dd>{entry.data.name}</dd>
|
||||
</dl>
|
||||
<strong>Change</strong>
|
||||
<HistoryItemDiff entry={entry} />
|
||||
</div>
|
||||
);
|
||||
HistoryMeta.propTypes = {
|
||||
entry: PropTypes.object.isRequired,
|
||||
timeFormatted: PropTypes.string.isRequired,
|
||||
};
|
||||
|
||||
class HistoryList extends Component {
|
||||
static propTypes = {
|
||||
title: PropTypes.string,
|
||||
@ -26,7 +47,7 @@ class HistoryList extends Component {
|
||||
}
|
||||
render() {
|
||||
const showData = this.props.settings.showData;
|
||||
const { history, hideName } = this.props;
|
||||
const { history } = this.props;
|
||||
if (!history || history.length < 0) {
|
||||
return null;
|
||||
}
|
||||
@ -35,7 +56,6 @@ class HistoryList extends Component {
|
||||
<span
|
||||
className={commonStyles.truncate}
|
||||
style={{ display: 'inline-block', verticalAlign: 'middle', width: '100%' }}
|
||||
title={v}
|
||||
>
|
||||
{v}
|
||||
</span>
|
||||
@ -48,40 +68,24 @@ class HistoryList extends Component {
|
||||
} else {
|
||||
entries = (
|
||||
<Table
|
||||
sortable
|
||||
rows={history.map(entry =>
|
||||
Object.assign(
|
||||
{
|
||||
diff: <HistoryItemDiff entry={entry} />,
|
||||
name: entry.data.name,
|
||||
meta: (
|
||||
<HistoryMeta
|
||||
entry={entry}
|
||||
timeFormatted={this.formatFulldateTime(entry.createdAt)}
|
||||
/>
|
||||
),
|
||||
},
|
||||
entry
|
||||
)
|
||||
)}
|
||||
className={commonStyles.fullwidth}
|
||||
style={{ border: 0, tableLayout: 'fixed', minWidth: '840px' }}
|
||||
style={{ border: 0, tableLayout: 'fixed' }}
|
||||
>
|
||||
<TableHeader name="type" cellFormatter={truncateTableCell} style={{ width: '115px' }}>
|
||||
Type
|
||||
</TableHeader>
|
||||
<TableHeader name="createdBy" cellFormatter={truncateTableCell} style={{ width: '115px' }}>
|
||||
User
|
||||
</TableHeader>
|
||||
{hideName ? (
|
||||
[]
|
||||
) : (
|
||||
<TableHeader name="name" cellFormatter={truncateTableCell} style={{ width: '153px' }}>
|
||||
Feature Toggle
|
||||
</TableHeader>
|
||||
)}
|
||||
<TableHeader name="diff">Diff</TableHeader>
|
||||
<TableHeader
|
||||
numeric
|
||||
name="createdAt"
|
||||
cellFormatter={this.formatFulldateTime.bind(this)}
|
||||
style={{ width: '165px' }}
|
||||
>
|
||||
Time
|
||||
<TableHeader name="meta" cellFormatter={truncateTableCell}>
|
||||
Change
|
||||
</TableHeader>
|
||||
</Table>
|
||||
);
|
||||
|
@ -33,18 +33,17 @@
|
||||
|
||||
|
||||
dl {
|
||||
padding: 0.5em;
|
||||
padding: 0em;
|
||||
}
|
||||
|
||||
dt {
|
||||
float: left;
|
||||
clear: left;
|
||||
width: 100px;
|
||||
font-weight: bold;
|
||||
}
|
||||
|
||||
dd {
|
||||
margin: 0 0 0 110px;
|
||||
margin: 0 0 0 83px;
|
||||
padding: 0 0 0.5em 0;
|
||||
}
|
||||
}
|
||||
@ -52,3 +51,7 @@
|
||||
.history-item:nth-child(odd) {
|
||||
background-color: #efefef;
|
||||
}
|
||||
|
||||
.history-item {
|
||||
padding: 5px;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user