Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: some integrations only counted errors not all results (#8295)

Browse Source
This commit is contained in:
David Leek 2024-09-27 14:57:26 +02:00 committed by GitHub
parent 81840ed574
commit 530af3d7d6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/lib/addons/datadog.ts
View File

@ -113,16 +113,16 @@ export default class DatadogAddon extends Addon {
state = 'failed';
const failedMessage = `Datadog Events API request failed with status code: ${res.status}.`;
stateDetails.push(failedMessage);
if (this.flagResolver.isEnabled('addonUsageMetrics')) {
this.eventBus.emit(ADDON_EVENTS_HANDLED, {
result: state,
destination: 'datadog',
});
}
this.logger.warn(failedMessage);
}
if (this.flagResolver.isEnabled('addonUsageMetrics')) {
this.eventBus.emit(ADDON_EVENTS_HANDLED, {
result: state,
destination: 'datadog',
});
}
this.registerEvent({
integrationId,
state,

6
src/lib/addons/slack-app.ts
View File

@ -179,6 +179,9 @@ export default class SlackAppAddon extends Addon {
stateDetails.push(eventErrorMessage);
this.logger.warn(eventErrorMessage);
const errorMessage = this.parseError(error);
stateDetails.push(errorMessage);
this.logger.warn(errorMessage, error);
} finally {
if (this.flagResolver.isEnabled('addonUsageMetrics')) {
this.eventBus.emit(ADDON_EVENTS_HANDLED, {
result: state,
@ -186,9 +189,6 @@ export default class SlackAppAddon extends Addon {
});
}
stateDetails.push(errorMessage);
this.logger.warn(errorMessage, error);
} finally {
this.registerEvent({
integrationId,
state,

14
src/lib/addons/slack.ts
View File

@ -131,16 +131,16 @@ export default class SlackAddon extends Addon {
state = 'successWithErrors';
const successWithErrorsMessage = `Some (${failedRequests.length} of ${results.length}) Slack webhook requests failed. Status codes: ${codes}.`;
stateDetails.push(successWithErrorsMessage);
if (this.flagResolver.isEnabled('addonUsageMetrics')) {
this.eventBus.emit(ADDON_EVENTS_HANDLED, {
result: state,
destination: 'slack',
});
}
this.logger.warn(successWithErrorsMessage);
}
if (this.flagResolver.isEnabled('addonUsageMetrics')) {
this.eventBus.emit(ADDON_EVENTS_HANDLED, {
result: state,
destination: 'slack',
});
}
this.registerEvent({
integrationId,
state,

14
src/lib/addons/teams.ts
View File

@ -107,16 +107,16 @@ export default class TeamsAddon extends Addon {
state = 'failed';
const failedMessage = `Teams webhook request failed with status code: ${res.status}.`;
stateDetails.push(failedMessage);
if (this.flagResolver.isEnabled('addonUsageMetrics')) {
this.eventBus.emit(ADDON_EVENTS_HANDLED, {
result: state,
destination: 'teams',
});
}
this.logger.warn(failedMessage);
}
if (this.flagResolver.isEnabled('addonUsageMetrics')) {
this.eventBus.emit(ADDON_EVENTS_HANDLED, {
result: state,
destination: 'teams',
});
}
this.registerEvent({
integrationId,
state,