1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-14 01:16:17 +02:00

chore: mark SSO as an Enterprise only feature (#9071)

https://linear.app/unleash/issue/2-3124/mark-sso-as-an-enterprise-only-feature

For all intents and purposes, SSO seems to have always been an
Enterprise only feature. It just wasn't very clear previously.

See: https://github.com/Unleash/unleash/pull/9045/files#r1899635618


![image](https://github.com/user-attachments/assets/7ffed499-83d6-4dc2-ae11-6b0d930a82d1)
This commit is contained in:
Nuno Góis 2025-01-09 13:07:28 +00:00 committed by GitHub
parent 0dbecd78a0
commit 537ef42f7d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 38 additions and 46 deletions

View File

@ -58,7 +58,7 @@ export const adminRoutes: INavigationMenuItem[] = [
{ {
path: '/admin/auth', path: '/admin/auth',
title: 'Single sign-on', title: 'Single sign-on',
menu: { adminSettings: true, mode: ['pro', 'enterprise'] }, menu: { adminSettings: true, mode: ['enterprise'] },
group: 'access', group: 'access',
}, },
{ {

View File

@ -1,6 +1,5 @@
import { Tab, Tabs } from '@mui/material'; import { Tab, Tabs } from '@mui/material';
import { PageContent } from 'component/common/PageContent/PageContent'; import { PageContent } from 'component/common/PageContent/PageContent';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig'; import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
import { OidcAuth } from './OidcAuth/OidcAuth'; import { OidcAuth } from './OidcAuth/OidcAuth';
import { SamlAuth } from './SamlAuth/SamlAuth'; import { SamlAuth } from './SamlAuth/SamlAuth';
@ -45,15 +44,16 @@ export const AuthSettings = () => {
const [activeTab, setActiveTab] = useState(0); const [activeTab, setActiveTab] = useState(0);
usePageTitle(`Single sign-on: ${tabs[activeTab].label}`); usePageTitle(`Single sign-on: ${tabs[activeTab].label}`);
if (!isEnterprise()) {
return <PremiumFeature feature='sso' page />;
}
return ( return (
<div> <div>
<PermissionGuard permissions={[ADMIN, UPDATE_AUTH_CONFIGURATION]}> <PermissionGuard permissions={[ADMIN, UPDATE_AUTH_CONFIGURATION]}>
<PageContent <PageContent
withTabs withTabs
header={ header={
<ConditionallyRender
condition={isEnterprise()}
show={
<Tabs <Tabs
value={activeTab} value={activeTab}
onChange={(_, tabId) => { onChange={(_, tabId) => {
@ -77,12 +77,7 @@ export const AuthSettings = () => {
))} ))}
</Tabs> </Tabs>
} }
/>
}
> >
<ConditionallyRender
condition={isEnterprise()}
show={
<div> <div>
{tabs.map((tab, index) => ( {tabs.map((tab, index) => (
<TabPanel <TabPanel
@ -94,9 +89,6 @@ export const AuthSettings = () => {
</TabPanel> </TabPanel>
))} ))}
</div> </div>
}
elseShow={<PremiumFeature feature='sso' />}
/>
</PageContent> </PageContent>
</PermissionGuard> </PermissionGuard>
</div> </div>

View File

@ -89,7 +89,7 @@ const PremiumFeatures = {
label: 'User groups', label: 'User groups',
}, },
sso: { sso: {
plan: FeaturePlan.PRO, plan: FeaturePlan.ENTERPRISE,
url: 'https://docs.getunleash.io/reference/rbac#user-group-sso-integration', url: 'https://docs.getunleash.io/reference/rbac#user-group-sso-integration',
label: 'Single Sign-On', label: 'Single Sign-On',
}, },