From 53a4f61260cbc5857ade647290f1ad37ef2e014f Mon Sep 17 00:00:00 2001 From: Mateusz Kwasniewski Date: Thu, 27 Mar 2025 13:46:29 +0100 Subject: [PATCH] feat: enabled change requests reacting to available environments (#9631) --- .../CreateProjectDialog.tsx | 29 +++++++++++-------- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/frontend/src/component/project/Project/CreateProject/NewCreateProjectForm/CreateProjectDialog.tsx b/frontend/src/component/project/Project/CreateProject/NewCreateProjectForm/CreateProjectDialog.tsx index a5fccf1cdb..c6e0254bc9 100644 --- a/frontend/src/component/project/Project/CreateProject/NewCreateProjectForm/CreateProjectDialog.tsx +++ b/frontend/src/component/project/Project/CreateProject/NewCreateProjectForm/CreateProjectDialog.tsx @@ -213,17 +213,6 @@ export const CreateProjectDialog = ({ const globalChangeRequestConfigEnabled = useUiFlag( 'globalChangeRequestConfig', ); - useEffect(() => { - if (!globalChangeRequestConfigEnabled) return; - activeEnvironments.forEach((environment) => { - if (Number.isInteger(environment.requiredApprovals)) { - updateProjectChangeRequestConfig.enableChangeRequests( - environment.name, - Number(environment.requiredApprovals), - ); - } - }); - }, [JSON.stringify(activeEnvironments)]); const numberOfConfiguredChangeRequestEnvironments = Object.keys( projectChangeRequestConfiguration, @@ -241,7 +230,23 @@ export const CreateProjectDialog = ({ : activeEnvironments.filter((env) => projectEnvironments.has(env.name), ) - ).map(({ name, type }) => ({ name, type })); + ).map(({ name, type, requiredApprovals }) => ({ + name, + type, + requiredApprovals, + })); + + useEffect(() => { + if (!globalChangeRequestConfigEnabled) return; + availableChangeRequestEnvironments.forEach((environment) => { + if (Number.isInteger(environment.requiredApprovals)) { + updateProjectChangeRequestConfig.enableChangeRequests( + environment.name, + Number(environment.requiredApprovals), + ); + } + }); + }, [JSON.stringify(availableChangeRequestEnvironments)]); return (