Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

feat: enable dark mode for all (#3614)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2023-04-25 10:13:06 +02:00 committed by GitHub
parent ae60cf05b5
commit 545e231cae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 24 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
frontend/src/component/menu/Header/Header.tsx
View File

@ -239,11 +239,6 @@ const Header: VFC = () => {
/>
</StyledLinks>
<StyledUserContainer>
<ConditionallyRender
condition={Boolean(
uiConfig.flags.ENABLE_DARK_MODE_SUPPORT
)}
show={
<Tooltip
title={
themeMode === 'dark'
@ -252,19 +247,14 @@ const Header: VFC = () => {
}
arrow
>
<IconButton
onClick={onSetThemeMode}
sx={focusable}
>
<IconButton onClick={onSetThemeMode} sx={focusable}>
<ConditionallyRender
condition={themeMode === 'dark'}
show={<DarkModeOutlined />}
elseShow={<LightModeOutlined />}
/>
</IconButton>
</Tooltip>
}
/>
</Tooltip>{' '}
<ConditionallyRender
condition={!isOss()}
show={<Notifications />}

20
frontend/src/component/providers/UIProvider/UIProvider.tsx
View File

@ -3,16 +3,15 @@ import UIContext, { createEmptyToast, themeMode } from 'contexts/UIContext';
import { IToast } from 'interfaces/toast';
import { getLocalStorageItem } from 'utils/storage';
const resolveMode = (darkmode: boolean): themeMode => {
const resolveMode = (): themeMode => {
const value = getLocalStorageItem('unleash-theme');
if (value) {
return value as themeMode;
}
let osDark;
if (darkmode) {
osDark = window.matchMedia('(prefers-color-scheme: dark)').matches;
}
const osDark =
window.matchMedia &&
window.matchMedia('(prefers-color-scheme: dark)').matches;
if (osDark) {
return 'dark';
@ -20,17 +19,10 @@ const resolveMode = (darkmode: boolean): themeMode => {
return 'light';
};
interface IUiProviderProps {
darkmode: boolean;
}
const UIProvider: React.FC<IUiProviderProps> = ({
children,
darkmode = false,
}) => {
const UIProvider: React.FC = ({ children }) => {
const [toastData, setToast] = useState<IToast>(createEmptyToast());
const [showFeedback, setShowFeedback] = useState(false);
const [themeMode, setThemeMode] = useState(resolveMode(darkmode));
const [themeMode, setThemeMode] = useState(resolveMode());
const context = React.useMemo(
() => ({

6
frontend/src/component/providers/UIProvider/UIProviderContainer.tsx
View File

@ -8,9 +8,5 @@ export const UIProviderContainer: React.FC = ({ children }) => {
return null;
}
return (
<UIProvider darkmode={uiConfig.flags.ENABLE_DARK_MODE_SUPPORT || false}>
{children}
</UIProvider>
);
return <UIProvider>{children}</UIProvider>;
};

2
frontend/src/component/tags/TagTypeList/__tests__/TagTypeList.test.tsx
View File

@ -13,7 +13,7 @@ test('renders an empty list correctly', () => {
<MemoryRouter>
<ThemeProvider>
<AnnouncerProvider>
<UIProvider darkmode={false}>
<UIProvider>
<AccessProviderMock
permissions={[{ permission: ADMIN }]}
>

1
frontend/src/interfaces/uiConfig.ts
View File

@ -36,7 +36,6 @@ export interface IFlags {
T?: boolean;
UNLEASH_CLOUD?: boolean;
UG?: boolean;
ENABLE_DARK_MODE_SUPPORT?: boolean;
embedProxyFrontend?: boolean;
maintenanceMode?: boolean;
messageBanner?: boolean;

5
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -66,7 +66,6 @@ exports[`should create default config 1`] = `
"isEnabled": [Function],
},
"flags": {
"ENABLE_DARK_MODE_SUPPORT": false,
"anonymiseEventLog": false,
"bulkOperations": false,
"caseInsensitiveInOperators": false,
@ -93,7 +92,6 @@ exports[`should create default config 1`] = `
},
"flagResolver": FlagResolver {
"experiments": {
"ENABLE_DARK_MODE_SUPPORT": false,
"anonymiseEventLog": false,
"bulkOperations": false,
"caseInsensitiveInOperators": false,
@ -168,9 +166,6 @@ exports[`should create default config 1`] = `
"strategySegmentsLimit": 5,
"ui": {
"environment": "Open Source",
"flags": {
"ENABLE_DARK_MODE_SUPPORT": false,
},
},
"versionCheck": {
"enable": true,

3
src/lib/create-config.ts
View File

@ -105,9 +105,6 @@ function loadUI(options: IUnleashOptions): IUIConfig {
environment: 'Open Source',
};
ui.flags = {
ENABLE_DARK_MODE_SUPPORT: false,
};
return mergeAll([ui, uiO]);
}

1
src/lib/types/experimental.ts
View File

@ -4,7 +4,6 @@ export type IFlags = Partial<typeof flags>;
export type IFlagKey = keyof IFlags;
const flags = {
ENABLE_DARK_MODE_SUPPORT: false,
anonymiseEventLog: false,
embedProxy: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_EMBED_PROXY,

2
src/lib/util/flag-resolver.test.ts
View File

@ -7,7 +7,7 @@ test('should produce empty exposed flags', () => {
const result = resolver.getAll();
expect(result.ENABLE_DARK_MODE_SUPPORT).toBe(false);
expect(result.anonymiseEventLog).toBe(false);
});
test('should produce UI flags with extra dynamic flags', () => {