Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-28 00:06:53 +01:00
Code Issues Projects Releases Wiki Activity

fix: Created by on application-created adds the ip as created by (#7231)

Browse Source 
To avoid leaking potential PII information in the event log, this replaces the IP for the system user as the "created by" field
This commit is contained in:
Gastón Fournier 2024-06-02 15:57:47 +02:00 committed by GitHub
parent 89e5760483
commit 54c6ac8163
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/features/metrics/instance/instance-service.ts
View File

@ -103,7 +103,7 @@ export default class ClientInstanceService {
): Promise<void> { ): Promise<void> {
const value = await clientRegisterSchema.validateAsync(data); const value = await clientRegisterSchema.validateAsync(data);
value.clientIp = clientIp; value.clientIp = clientIp;
value.createdBy = clientIp; value.createdBy = SYSTEM_USER.username!;
this.seenClients[this.clientKey(value)] = value; this.seenClients[this.clientKey(value)] = value;
this.eventStore.emit(CLIENT_REGISTER, value); this.eventStore.emit(CLIENT_REGISTER, value);
} }